X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=ONAP-XACML%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fpolicy%2Fxacml%2Fstd%2Fpap%2FStdPDPGroupStatus.java;h=dd9bf0a2cf98081383b9e115a46e53cd080930fd;hb=cd417e811577a3efd26a57c3cad3a48d42d9e2d6;hp=ae4649e1164f74f0bc54bb917103a033498080a3;hpb=9df8b88412f6e890320bc446ba1c83a13e99822d;p=policy%2Fengine.git

diff --git a/ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPGroupStatus.java b/ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPGroupStatus.java
index ae4649e11..dd9bf0a2c 100644
--- a/ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPGroupStatus.java
+++ b/ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPGroupStatus.java
@@ -2,7 +2,7 @@
  * ============LICENSE_START=======================================================
  * ONAP-XACML
  * ================================================================================
- * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -71,18 +71,30 @@ public class StdPDPGroupStatus implements PDPGroupStatus {
 
 	public StdPDPGroupStatus(PDPGroupStatus stat) {
 		this.status = stat.getStatus();
-		this.failedPDPs.clear(); this.failedPDPs.addAll(stat.getFailedPDPs());
-		this.failedPIPConfigs.clear(); this.failedPIPConfigs.addAll(stat.getFailedPipConfigs());
-		this.failedPolicies.clear(); this.failedPolicies.addAll(stat.getFailedPolicies());
-		this.inSynchPDPs.clear(); this.inSynchPDPs.addAll(stat.getInSynchPDPs());
-		this.lastUpdateFailedPDPs.clear(); this.lastUpdateFailedPDPs.addAll(stat.getLastUpdateFailedPDPs());
-		this.loadedPIPConfigs.clear(); this.loadedPIPConfigs.addAll(stat.getLoadedPipConfigs());
-		this.loadedPolicies.clear(); this.loadedPolicies.addAll(stat.getLoadedPolicies());
-		this.loadErrors.clear(); this.loadErrors.addAll(stat.getLoadErrors());
-		this.loadWarnings.clear(); this.loadWarnings.addAll(stat.getLoadWarnings());
-		this.outOfSynchPDPs.clear(); this.outOfSynchPDPs.addAll(stat.getOutOfSynchPDPs());
-		this.unknownPDPs.clear(); this.unknownPDPs.addAll(stat.getUpdatingPDPs());
-		this.updatingPDPs.clear(); this.updatingPDPs.addAll(stat.getUpdatingPDPs());
+		this.failedPDPs.clear(); 
+		this.failedPDPs.addAll(stat.getFailedPDPs());
+		this.failedPIPConfigs.clear(); 
+		this.failedPIPConfigs.addAll(stat.getFailedPipConfigs());
+		this.failedPolicies.clear(); 
+		this.failedPolicies.addAll(stat.getFailedPolicies());
+		this.inSynchPDPs.clear(); 
+		this.inSynchPDPs.addAll(stat.getInSynchPDPs());
+		this.lastUpdateFailedPDPs.clear(); 
+		this.lastUpdateFailedPDPs.addAll(stat.getLastUpdateFailedPDPs());
+		this.loadedPIPConfigs.clear(); 
+		this.loadedPIPConfigs.addAll(stat.getLoadedPipConfigs());
+		this.loadedPolicies.clear(); 
+		this.loadedPolicies.addAll(stat.getLoadedPolicies());
+		this.loadErrors.clear(); 
+		this.loadErrors.addAll(stat.getLoadErrors());
+		this.loadWarnings.clear(); 
+		this.loadWarnings.addAll(stat.getLoadWarnings());
+		this.outOfSynchPDPs.clear(); 
+		this.outOfSynchPDPs.addAll(stat.getOutOfSynchPDPs());
+		this.unknownPDPs.clear(); 
+		this.unknownPDPs.addAll(stat.getUpdatingPDPs());
+		this.updatingPDPs.clear(); 
+		this.updatingPDPs.addAll(stat.getUpdatingPDPs());
 	}
 
 	public Set<PDPPIPConfig> getLoadedPIPConfigs() {
@@ -286,16 +298,16 @@ public class StdPDPGroupStatus implements PDPGroupStatus {
 	@Override
 	@JsonIgnore
 	public boolean isGroupOk() {
-		if (this.policiesOK() == false) {
+		if (!this.policiesOK()) {
 			return false;
 		}
-		if (this.pipConfigOK() == false) {
+		if (!this.pipConfigOK()) {
 			return false;
 		}
-		if (this.pdpsOK() == false) {
+		if (!this.pdpsOK()) {
 			return false;
 		}
-		if (this.loadErrors.isEmpty() == false) {
+		if (!this.loadErrors.isEmpty()) {
 			return false;
 		}
 		return this.status == Status.OK;