X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=ONAP-XACML%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fpolicy%2Fxacml%2Fstd%2Fpap%2FStdPDPGroupStatus.java;h=ae4649e1164f74f0bc54bb917103a033498080a3;hb=4d503f398d2f309cc077b55b5f1cce4c4bd773e6;hp=296f738f4f164699bf8c086b5a04d069d16d5a1b;hpb=38261bb20e49c39f710aef47b5415dcdf14a1729;p=policy%2Fengine.git diff --git a/ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPGroupStatus.java b/ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPGroupStatus.java index 296f738f4..ae4649e11 100644 --- a/ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPGroupStatus.java +++ b/ONAP-XACML/src/main/java/org/onap/policy/xacml/std/pap/StdPDPGroupStatus.java @@ -58,9 +58,11 @@ public class StdPDPGroupStatus implements PDPGroupStatus { private Set unknownPDPs = new HashSet<>(); - // Constructor needed for JSON deserialization + public StdPDPGroupStatus() { - + // + // Constructor needed for JSON deserialization + // } public StdPDPGroupStatus(Status status) { @@ -177,7 +179,7 @@ public class StdPDPGroupStatus implements PDPGroupStatus { @Override public boolean policiesOK() { - if (this.failedPolicies.size() > 0) { + if (!this.failedPolicies.isEmpty()) { return false; } return true; @@ -203,7 +205,7 @@ public class StdPDPGroupStatus implements PDPGroupStatus { @Override public boolean pipConfigOK() { - if (this.failedPIPConfigs.size() > 0) { + if (!this.failedPIPConfigs.isEmpty()) { return false; } return true; @@ -266,16 +268,16 @@ public class StdPDPGroupStatus implements PDPGroupStatus { @Override public boolean pdpsOK() { - if (this.outOfSynchPDPs.size() > 0) { + if (!this.outOfSynchPDPs.isEmpty()) { return false; } - if (this.failedPDPs.size() > 0) { + if (!this.failedPDPs.isEmpty()) { return false; } - if (this.lastUpdateFailedPDPs.size() > 0) { + if (!this.lastUpdateFailedPDPs.isEmpty()) { return false; } - if (this.unknownPDPs.size() > 0) { + if (!this.unknownPDPs.isEmpty()) { return false; } return true; @@ -296,7 +298,7 @@ public class StdPDPGroupStatus implements PDPGroupStatus { if (this.loadErrors.isEmpty() == false) { return false; } - return (this.status == Status.OK); + return this.status == Status.OK; } public void reset() {