X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=ONAP-PAP-REST%2Fsrc%2Ftest%2Fjava%2Forg%2Fonap%2Fpolicy%2Fpap%2Fxacml%2Frest%2Felk%2FElkConnectorImplTest.java;h=2f3d580f75cfccb3bc5e03b28b494a09e6c671ea;hb=4068da123ee33b532b4b52f15545c76a978f977e;hp=c0f59273c57c3e81e9e087bccd96ed9965ad2d22;hpb=e688c3ab14a546dcc7acc189007ac4d42e349332;p=policy%2Fengine.git

diff --git a/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/elk/ElkConnectorImplTest.java b/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/elk/ElkConnectorImplTest.java
index c0f59273c..2f3d580f7 100644
--- a/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/elk/ElkConnectorImplTest.java
+++ b/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/elk/ElkConnectorImplTest.java
@@ -2,7 +2,7 @@
  * ============LICENSE_START=======================================================
  * ONAP-PAP-REST
  * ================================================================================
- * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,74 +27,120 @@ import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 import io.searchbox.client.JestResult;
 
+import java.io.IOException;
 import java.lang.reflect.Method;
 
+import org.junit.Rule;
 import org.junit.Test;
+import org.junit.rules.ExpectedException;
 import org.onap.policy.pap.xacml.rest.elk.client.ElkConnector.PolicyIndexType;
 import org.onap.policy.pap.xacml.rest.elk.client.ElkConnectorImpl;
+import org.onap.policy.rest.adapter.PolicyRestAdapter;
 
 public class ElkConnectorImplTest {
 
-	@Test
-	public void isAlphaNumericTest() {
-		try {
-			Method method = ElkConnectorImpl.class.getDeclaredMethod("isAlphaNumeric", String.class);
-			method.setAccessible(true);
-			assertTrue((boolean) method.invoke(new ElkConnectorImpl(), "abc123"));
-			assertFalse((boolean) method.invoke(new ElkConnectorImpl(), "abc123*"));
-			assertFalse((boolean) method.invoke(new ElkConnectorImpl(), "abc123{}"));
-			assertFalse((boolean) method.invoke(new ElkConnectorImpl(), "abc123\n"));
-			assertFalse((boolean) method.invoke(new ElkConnectorImpl(), "abc123<"));
-			assertFalse((boolean) method.invoke(new ElkConnectorImpl(), "abc123:"));
-		} catch (Exception e) {
-			fail();
-		}
-	}
-
-	@Test
-	public void searchTest(){
-		JestResult r1=null, r2=null, r3=null, r4=null;
-
-		// Should always work if the above test passes and ELK server is up
-		try{
-			r1 = new ElkConnectorImpl().search(PolicyIndexType.decision, "abc123");
-		} catch (Exception e) {
-			// ELK server is down. Don't continue the test
-			if(e instanceof IllegalStateException){
-				return;
-			}
-			fail();
-		}
-
-		// Should always work
-		try{
-			r2 = new ElkConnectorImpl().search(PolicyIndexType.decision, "The_quick_brown_fox_jumps_over_the_lazy_dog");
-		} catch (Exception e) {
-			fail();
-		}
-
-		// Should throw exception
-		try{
-			r3 = new ElkConnectorImpl().search(PolicyIndexType.decision, "abc123{}");
-		} catch (Exception e) {
-			if(! (e instanceof IllegalArgumentException)){
-				fail();
-			}
-		}
-		
-		// Should throw exception
-		try{
-			r4 = new ElkConnectorImpl().search(PolicyIndexType.decision, "The quick brown fox jumps over the lazy dog");
-		} catch (Exception e) {
-			if(! (e instanceof IllegalArgumentException)){
-				fail();
-			}
-		}
-
-		assertNotNull(r1);
-		assertNotNull(r2);
-		assertNull(r3);
-		assertNull(r4);
-	}
+    @Test
+    public void isAlphaNumericTest() {
+        try {
+            Method method = ElkConnectorImpl.class.getDeclaredMethod("isAlphaNumeric", String.class);
+            method.setAccessible(true);
+            assertTrue((boolean) method.invoke(new ElkConnectorImpl(), "abc123"));
+            assertFalse((boolean) method.invoke(new ElkConnectorImpl(), "abc123*"));
+            assertFalse((boolean) method.invoke(new ElkConnectorImpl(), "abc123{}"));
+            assertFalse((boolean) method.invoke(new ElkConnectorImpl(), "abc123\n"));
+            assertFalse((boolean) method.invoke(new ElkConnectorImpl(), "abc123<"));
+            assertFalse((boolean) method.invoke(new ElkConnectorImpl(), "abc123:"));
+        } catch (Exception e) {
+            fail();
+        }
+    }
 
+    @Test
+    public void searchTest(){
+        JestResult r1=null, r2=null, r3=null, r4=null;
+
+        // Should always work if the above test passes and ELK server is up
+        try{
+            r1 = new ElkConnectorImpl().search(PolicyIndexType.decision, "abc123");
+        } catch (Exception e) {
+            // ELK server is down. Don't continue the test
+            if(e instanceof IllegalStateException){
+                return;
+            }
+            fail();
+        }
+
+        // Should always work
+        try{
+            r2 = new ElkConnectorImpl().search(PolicyIndexType.decision, "The_quick_brown_fox_jumps_over_the_lazy_dog");
+        } catch (Exception e) {
+            fail();
+        }
+
+        // Should throw exception
+        try{
+            r3 = new ElkConnectorImpl().search(PolicyIndexType.decision, "abc123{}");
+        } catch (Exception e) {
+            if(! (e instanceof IllegalArgumentException)){
+                fail();
+            }
+        }
+
+        // Should throw exception
+        try{
+            r4 = new ElkConnectorImpl().search(PolicyIndexType.decision, "The quick brown fox jumps over the lazy dog");
+        } catch (Exception e) {
+            if(! (e instanceof IllegalArgumentException)){
+                fail();
+            }
+        }
+
+        assertNotNull(r1);
+        assertNotNull(r2);
+        assertNull(r3);
+        assertNull(r4);
+    }
+
+    @Rule
+    public ExpectedException thrown = ExpectedException.none();
+
+    @Test
+    public void testDelete() {
+        thrown.expect(NullPointerException.class);
+
+        ElkConnectorImpl impl = new ElkConnectorImpl();
+        PolicyRestAdapter adapter = new PolicyRestAdapter();
+        impl.delete(adapter);
+        fail("Expected exception to be thrown");
+    }
+
+
+    @Test
+    public void testPut() throws IOException {
+        thrown.expect(NullPointerException.class);
+
+        ElkConnectorImpl impl = new ElkConnectorImpl();
+        PolicyRestAdapter adapter = new PolicyRestAdapter();
+        impl.put(adapter);
+        fail("Expected exception to be thrown");
+    }
+
+    @Test
+    public void testUpdate() {
+        thrown.expect(IllegalStateException.class);
+
+        ElkConnectorImpl impl = new ElkConnectorImpl();
+        PolicyRestAdapter adapter = new PolicyRestAdapter();
+        impl.update(adapter);
+        fail("Expected exception to be thrown");
+    }
+
+    @Test
+    public void testSearchWithFilter() {
+        thrown.expect(IllegalStateException.class);
+
+        ElkConnectorImpl impl = new ElkConnectorImpl();
+        impl.search(PolicyIndexType.config, "search", null);
+        fail("Expected exception to be thrown");
+    }
 }