X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=ONAP-PAP-REST%2Fsrc%2Ftest%2Fjava%2Forg%2Fonap%2Fpolicy%2Fpap%2Fxacml%2Frest%2Fcontroller%2FDictionaryImportControllerTest.java;h=7ab1b170ea61a7e835d2a1313ef7f5d6fee02a19;hb=4068da123ee33b532b4b52f15545c76a978f977e;hp=6a28c271ad444cd8292a2ec01515ef4544f0352e;hpb=f0fec2a861ea0a92b27b40882ea38f9422cde0c6;p=policy%2Fengine.git diff --git a/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/DictionaryImportControllerTest.java b/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/DictionaryImportControllerTest.java index 6a28c271a..7ab1b170e 100644 --- a/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/DictionaryImportControllerTest.java +++ b/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/DictionaryImportControllerTest.java @@ -43,98 +43,98 @@ import org.onap.policy.rest.dao.CommonClassDao; import org.springframework.mock.web.MockHttpServletResponse; public class DictionaryImportControllerTest extends Mockito{ - - private static Logger logger = FlexLogger.getLogger(DictionaryImportController.class); - - private static CommonClassDao commonClassDao; - private HttpServletRequest request = null; - private HttpServletResponse response = null; - private DictionaryImportController controller = null; - @Before - public void setUp() throws Exception { - logger.info("setUp: Entering"); - commonClassDao = Mockito.mock(CommonClassDao.class); - doNothing().when(commonClassDao).save(new Object()); - controller = new DictionaryImportController(); - new DictionaryImportController(commonClassDao); - request = Mockito.mock(HttpServletRequest.class); - response = new MockHttpServletResponse(); - } - - @Test - public void testIsValidDictionaryName(){ - DictionaryImportController cotroller = new DictionaryImportController(); - //test invalid name - assertTrue(!cotroller.isValidDictionaryName("wrong-name")); - //test valid name - assertTrue(cotroller.isValidDictionaryName("ActionList")); - } + private static Logger logger = FlexLogger.getLogger(DictionaryImportController.class); - @Test - public void testImportDictionaryData() throws ServletException, IOException{ - List fileNames = new ArrayList<>(); - fileNames.add("Attribute.csv"); - fileNames.add("ActionPolicyDictionary.csv"); - fileNames.add("OnapName.csv"); - fileNames.add("MSPolicyDictionary.csv"); - fileNames.add("OptimizationPolicyDictionary.csv"); - fileNames.add("ClosedLoopService.csv"); - fileNames.add("ClosedLoopSite.csv"); - fileNames.add("VarbindDictionary.csv"); - fileNames.add("BRMSParamDictionary.csv"); - fileNames.add("BRMSControllerDictionary.csv"); - fileNames.add("BRMSDependencyDictionary.csv"); - fileNames.add("PrefixList.csv"); - fileNames.add("SecurityZone.csv"); - fileNames.add("ServiceList.csv"); - fileNames.add("ServiceGroup.csv"); - fileNames.add("AddressGroup.csv"); - fileNames.add("ProtocolList.csv"); - fileNames.add("TermList.csv"); - fileNames.add("SearchCriteria.csv"); - fileNames.add("VNFType.csv"); - fileNames.add("VSCLAction.csv"); - fileNames.add("PEPOptions.csv"); - fileNames.add("Settings.csv"); - fileNames.add("Zone.csv"); - fileNames.add("ActionList.csv"); - for(int i =0; i < fileNames.size(); i++){ - File file = new File("src/test/resources/dictionaryImport/"+fileNames.get(i)); - try(FileInputStream targetStream = new FileInputStream(file)){ - PushPolicyControllerTest pushController = new PushPolicyControllerTest(); - when(request.getInputStream()).thenReturn(pushController.getInputStream(getBytes(targetStream))); - when(request.getParameter("userId")).thenReturn("demo"); - when(request.getParameter("dictionaryName")).thenReturn(fileNames.get(i)); - controller.importDictionaryData(request, response); - assertTrue(HttpServletResponse.SC_OK == response.getStatus()); - } catch (IOException e) { - fail(); - } - } - when(request.getParameter("dictionaryName")).thenReturn("WrongName"); - controller.importDictionaryData(request, response); - assertTrue(HttpServletResponse.SC_BAD_REQUEST == response.getStatus()); - - when(request.getParameter("dictionaryName")).thenReturn(""); - controller.importDictionaryData(request, response); - assertTrue(HttpServletResponse.SC_BAD_REQUEST == response.getStatus()); - - when(request.getInputStream()).thenReturn(null); - when(request.getParameter("dictionaryName")).thenReturn("Attribute.csv"); - controller.importDictionaryData(request, response); - assertTrue(HttpServletResponse.SC_INTERNAL_SERVER_ERROR == response.getStatus()); - } - - public static byte[] getBytes(InputStream is) throws IOException { - int len; - int size = 1024; - byte[] buf; - ByteArrayOutputStream bos = new ByteArrayOutputStream(); - buf = new byte[size]; - while ((len = is.read(buf, 0, size)) != -1) - bos.write(buf, 0, len); - buf = bos.toByteArray(); - return buf; - } + private static CommonClassDao commonClassDao; + private HttpServletRequest request = null; + private HttpServletResponse response = null; + private DictionaryImportController controller = null; + + @Before + public void setUp() throws Exception { + logger.info("setUp: Entering"); + commonClassDao = Mockito.mock(CommonClassDao.class); + doNothing().when(commonClassDao).save(new Object()); + controller = new DictionaryImportController(); + new DictionaryImportController(commonClassDao); + request = Mockito.mock(HttpServletRequest.class); + response = new MockHttpServletResponse(); + } + + @Test + public void testIsValidDictionaryName(){ + DictionaryImportController cotroller = new DictionaryImportController(); + //test invalid name + assertTrue(!cotroller.isValidDictionaryName("wrong-name")); + //test valid name + assertTrue(cotroller.isValidDictionaryName("ActionList")); + } + + @Test + public void testImportDictionaryData() throws ServletException, IOException{ + List fileNames = new ArrayList<>(); + fileNames.add("Attribute.csv"); + fileNames.add("ActionPolicyDictionary.csv"); + fileNames.add("OnapName.csv"); + fileNames.add("MSPolicyDictionary.csv"); + fileNames.add("OptimizationPolicyDictionary.csv"); + fileNames.add("ClosedLoopService.csv"); + fileNames.add("ClosedLoopSite.csv"); + fileNames.add("VarbindDictionary.csv"); + fileNames.add("BRMSParamDictionary.csv"); + fileNames.add("BRMSControllerDictionary.csv"); + fileNames.add("BRMSDependencyDictionary.csv"); + fileNames.add("PrefixList.csv"); + fileNames.add("SecurityZone.csv"); + fileNames.add("ServiceList.csv"); + fileNames.add("ServiceGroup.csv"); + fileNames.add("AddressGroup.csv"); + fileNames.add("ProtocolList.csv"); + fileNames.add("TermList.csv"); + fileNames.add("SearchCriteria.csv"); + fileNames.add("VNFType.csv"); + fileNames.add("VSCLAction.csv"); + fileNames.add("PEPOptions.csv"); + fileNames.add("Settings.csv"); + fileNames.add("Zone.csv"); + fileNames.add("ActionList.csv"); + for(int i =0; i < fileNames.size(); i++){ + File file = new File("src/test/resources/dictionaryImport/"+fileNames.get(i)); + try(FileInputStream targetStream = new FileInputStream(file)){ + PushPolicyControllerTest pushController = new PushPolicyControllerTest(); + when(request.getInputStream()).thenReturn(pushController.getInputStream(getBytes(targetStream))); + when(request.getParameter("userId")).thenReturn("demo"); + when(request.getParameter("dictionaryName")).thenReturn(fileNames.get(i)); + controller.importDictionaryData(request, response); + assertTrue(HttpServletResponse.SC_OK == response.getStatus()); + } catch (IOException e) { + fail(); + } + } + when(request.getParameter("dictionaryName")).thenReturn("WrongName"); + controller.importDictionaryData(request, response); + assertTrue(HttpServletResponse.SC_BAD_REQUEST == response.getStatus()); + + when(request.getParameter("dictionaryName")).thenReturn(""); + controller.importDictionaryData(request, response); + assertTrue(HttpServletResponse.SC_BAD_REQUEST == response.getStatus()); + + when(request.getInputStream()).thenReturn(null); + when(request.getParameter("dictionaryName")).thenReturn("Attribute.csv"); + controller.importDictionaryData(request, response); + assertTrue(HttpServletResponse.SC_INTERNAL_SERVER_ERROR == response.getStatus()); + } + + public static byte[] getBytes(InputStream is) throws IOException { + int len; + int size = 1024; + byte[] buf; + ByteArrayOutputStream bos = new ByteArrayOutputStream(); + buf = new byte[size]; + while ((len = is.read(buf, 0, size)) != -1) + bos.write(buf, 0, len); + buf = bos.toByteArray(); + return buf; + } }