X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=ONAP-PAP-REST%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fpolicy%2Fpap%2Fxacml%2Frest%2Fpolicycontroller%2FPolicyCreation.java;h=415c7792d6632a493a5ca867f1132cc14e25bfc2;hb=0c8425b25c093f638351a14f84a7b1df731cd0de;hp=d989470a2baf05c45f555edce3a5dab300a0ed0c;hpb=1bfd18f999cda39a7b27bef8972864aafe59aecb;p=policy%2Fengine.git

diff --git a/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/policycontroller/PolicyCreation.java b/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/policycontroller/PolicyCreation.java
index d989470a2..415c7792d 100644
--- a/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/policycontroller/PolicyCreation.java
+++ b/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/policycontroller/PolicyCreation.java
@@ -20,6 +20,7 @@
 package org.onap.policy.pap.xacml.rest.policycontroller;
 
 import java.io.File;
+import java.util.Date;
 import java.util.HashMap;
 import java.util.LinkedHashMap;
 import java.util.LinkedList;
@@ -115,7 +116,7 @@ public class PolicyCreation extends AbstractPolicyCreation{
 				policyData.setTtlDate("NA");
 			}else{
 				String dateTTL = policyData.getTtlDate();
-				String newDate = convertDate(dateTTL, false);
+				String newDate = convertDate(dateTTL);
 				policyData.setTtlDate(newDate);
 			}
 
@@ -184,6 +185,7 @@ public class PolicyCreation extends AbstractPolicyCreation{
 					policyVersionDao.setActiveVersion(version);
 					policyVersionDao.setHigherVersion(version);
 					policyVersionDao.setModifiedBy(modifiedBy);
+					policyVersionDao.setModifiedDate(new Date());
 				}else{
 					body = "policyExists";
 					status = HttpStatus.CONFLICT;
@@ -193,6 +195,15 @@ public class PolicyCreation extends AbstractPolicyCreation{
 					return new ResponseEntity<String>(body, status);
 				}		
 			}else{
+				// if policy does not exist and the request is updatePolicy return error
+				if(policyData.isEditPolicy()){
+					body = "policyNotAvailableForEdit";
+					status = HttpStatus.NOT_FOUND;
+					response.setStatus(HttpServletResponse.SC_NOT_FOUND);
+					response.addHeader("error", body);
+					response.addHeader("message", policyData.getPolicyName() + " does not exist on the PAP and cannot be updated.");
+					return new ResponseEntity<>(body, status);
+				}
 				version = 1;
 				if(userId == null){
 					createdBy = "API";
@@ -220,14 +231,12 @@ public class PolicyCreation extends AbstractPolicyCreation{
 			policyData.setRuleCombiningAlgId("urn:oasis:names:tc:xacml:3.0:rule-combining-algorithm:permit-overrides");
 			if(policyData.getApiflag() == null){
 				//set the Rule Combining Algorithm Id to be sent to PAP-REST via JSON	
-				if(policyData.getAttributes() != null){
-					if(policyData.getAttributes().size() > 0){
-						for(Object attribute : policyData.getAttributes()){
-							if(attribute instanceof LinkedHashMap<?, ?>){
-								String key = ((LinkedHashMap<?, ?>) attribute).get("key").toString();
-								String value = ((LinkedHashMap<?, ?>) attribute).get("value").toString();
-								attributeMap.put(key, value);	
-							}
+				if(policyData.getAttributes() != null && !policyData.getAttributes().isEmpty()){
+					for(Object attribute : policyData.getAttributes()){
+						if(attribute instanceof LinkedHashMap<?, ?>){
+							String key = ((LinkedHashMap<?, ?>) attribute).get("key").toString();
+							String value = ((LinkedHashMap<?, ?>) attribute).get("value").toString();
+							attributeMap.put(key, value);	
 						}
 					}
 				}
@@ -303,7 +312,7 @@ public class PolicyCreation extends AbstractPolicyCreation{
 					List<String> dynamicRuleAlgorithmField2 = new LinkedList<>();
 
 
-					if(policyData.getRuleAlgorithmschoices().size() > 0){
+					if(!policyData.getRuleAlgorithmschoices().isEmpty()){
 						for(Object attribute : policyData.getRuleAlgorithmschoices()){
 							if(attribute instanceof LinkedHashMap<?, ?>){
 								String label = ((LinkedHashMap<?, ?>) attribute).get("id").toString();
@@ -320,22 +329,35 @@ public class PolicyCreation extends AbstractPolicyCreation{
 
 					String actionDictValue = policyData.getActionAttributeValue();
 					ActionPolicyDict jsonData = ((ActionPolicyDict) commonClassDao.getEntityItem(ActionPolicyDict.class, "attributeName", actionDictValue));
-					String actionBodyString = jsonData.getBody();
-					String actionDictHeader = jsonData.getHeader();
-					String actionDictType = jsonData.getType();
-					String actionDictUrl = jsonData.getUrl();
-					String actionDictMethod = jsonData.getMethod();
-					policyData.setActionDictHeader(actionDictHeader);
-					policyData.setActionDictType(actionDictType);
-					policyData.setActionDictUrl(actionDictUrl);
-					policyData.setActionDictMethod(actionDictMethod);
+					if(jsonData!=null){
+						String actionBodyString = jsonData.getBody();
+						String actionDictHeader = jsonData.getHeader();
+						String actionDictType = jsonData.getType();
+						String actionDictUrl = jsonData.getUrl();
+						String actionDictMethod = jsonData.getMethod();
+						policyData.setActionDictHeader(actionDictHeader);
+						policyData.setActionDictType(actionDictType);
+						policyData.setActionDictUrl(actionDictUrl);
+						policyData.setActionDictMethod(actionDictMethod);
+						if (actionBodyString != null) {
+							policyData.setActionBody(actionBodyString);
+						}
+					}
 					policyData.setActionAttribute(actionDictValue);
 					policyData.setDynamicRuleAlgorithmLabels(dynamicRuleAlgorithmLabels);
 					policyData.setDynamicRuleAlgorithmCombo(dynamicRuleAlgorithmCombo);
 					policyData.setDynamicRuleAlgorithmField1(dynamicRuleAlgorithmField1);
 					policyData.setDynamicRuleAlgorithmField2(dynamicRuleAlgorithmField2);
-					if (actionBodyString != null) {
-						policyData.setActionBody(actionBodyString);
+				}else{
+					// API request. 
+					String comboDictValue = policyData.getActionAttribute();
+					ActionPolicyDict jsonData = ((ActionPolicyDict) commonClassDao.getEntityItem(ActionPolicyDict.class, "attributeName", comboDictValue));
+					if(jsonData!=null){
+						policyData.setActionBody(jsonData.getBody());
+						policyData.setActionDictHeader(jsonData.getHeader());
+						policyData.setActionDictType(jsonData.getType());
+						policyData.setActionDictUrl(jsonData.getUrl());
+						policyData.setActionDictMethod(jsonData.getMethod());
 					}
 				}
 				newPolicy = new ActionPolicy(policyData);