X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=ONAP-PAP-REST%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fpolicy%2Fpap%2Fxacml%2Frest%2Fhandler%2FAPIRequestHandler.java;h=46c2b1160dd26a59483853a1341db4c44b8bf6ed;hb=92febb7abd1e6dfe89633d3d92cd70fabf5f0434;hp=cc9cc16a0a1beea27adee5579fde7e9ccdb63b70;hpb=2fc1a1510259202e8854beb8c04ef045bd28c79b;p=policy%2Fengine.git

diff --git a/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/handler/APIRequestHandler.java b/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/handler/APIRequestHandler.java
index cc9cc16a0..46c2b1160 100644
--- a/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/handler/APIRequestHandler.java
+++ b/ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/handler/APIRequestHandler.java
@@ -2,14 +2,14 @@
  * ============LICENSE_START=======================================================
  * ONAP-PAP-REST
  * ================================================================================
- * Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2017-2019 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -17,15 +17,13 @@
  * limitations under the License.
  * ============LICENSE_END=========================================================
  */
+
 package org.onap.policy.pap.xacml.rest.handler;
 
 import java.io.IOException;
-import java.sql.SQLException;
-
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
-
-import org.onap.policy.common.logging.ONAPLoggingContext;
+import org.onap.policy.common.logging.OnapLoggingContext;
 import org.onap.policy.pap.xacml.rest.service.ImportService;
 import org.onap.policy.pap.xacml.rest.service.MetricService;
 import org.onap.policy.xacml.api.pap.OnapPDPGroup;
@@ -34,7 +32,15 @@ public class APIRequestHandler {
 
     private OnapPDPGroup newGroup;
 
-    public void doGet(HttpServletRequest request, HttpServletResponse response, String apiflag) throws IOException{
+    /**
+     * Do get.
+     *
+     * @param request the request
+     * @param response the response
+     * @param apiflag the apiflag
+     * @throws IOException Signals that an I/O exception has occurred.
+     */
+    public void doGet(HttpServletRequest request, HttpServletResponse response, String apiflag) throws IOException {
         // Request from the API to get Dictionary Items
         if ("api".equalsIgnoreCase(apiflag)) {
             DictionaryHandler dictionaryHandler = DictionaryHandler.getInstance();
@@ -42,25 +48,33 @@ public class APIRequestHandler {
             return;
         }
         // Request from the API to get the ActiveVersion from the PolicyVersion table
-        if ("version".equalsIgnoreCase(apiflag)){
+        if ("version".equalsIgnoreCase(apiflag)) {
             PushPolicyHandler pushHandler = new PushPolicyHandler();
             pushHandler.getActiveVersion(request, response);
             return;
         }
         // Request from the API to get the URI from the gitpath
-        if ("uri".equalsIgnoreCase(apiflag)){
+        if ("uri".equalsIgnoreCase(apiflag)) {
             PushPolicyHandler pushHandler = new PushPolicyHandler();
             pushHandler.getSelectedURI(request, response);
             return;
         }
-        if ("getMetrics".equalsIgnoreCase(apiflag)){
+        if ("getMetrics".equalsIgnoreCase(apiflag)) {
             MetricService.doGetPolicyMetrics(response);
-            return;
         }
     }
 
+    /**
+     * Do put.
+     *
+     * @param request the request
+     * @param response the response
+     * @param service the service
+     * @throws IOException Signals that an I/O exception has occurred.
+     */
     public void doPut(HttpServletRequest request, HttpServletResponse response, String service) throws IOException {
-        if ("MICROSERVICE".equalsIgnoreCase(service) || "BRMSPARAM".equalsIgnoreCase(service) || "OPTIMIZATION".equalsIgnoreCase(service)){
+        if ("MICROSERVICE".equalsIgnoreCase(service) || "BRMSPARAM".equalsIgnoreCase(service)
+                || "OPTIMIZATION".equalsIgnoreCase(service)) {
             ImportService importService = new ImportService();
             importService.doImportMicroServicePut(request, response);
             return;
@@ -68,22 +82,29 @@ public class APIRequestHandler {
         if ("dictionaryItem".equalsIgnoreCase(service)) {
             DictionaryHandler dictionaryHandler = DictionaryHandler.getInstance();
             dictionaryHandler.doDictionaryAPIPut(request, response);
-            return;
         } else {
             SavePolicyHandler savePolicy = SavePolicyHandler.getInstance();
             savePolicy.doPolicyAPIPut(request, response);
         }
     }
 
-    public void doDelete(HttpServletRequest request, HttpServletResponse response, ONAPLoggingContext loggingContext, String apiflag) throws IOException, SQLException{
+    /**
+     * Do delete.
+     *
+     * @param request the request
+     * @param response the response
+     * @param loggingContext the logging context
+     * @param apiflag the apiflag
+     * @throws IOException Signals that an I/O exception has occurred.
+     */
+    public void doDelete(HttpServletRequest request, HttpServletResponse response, OnapLoggingContext loggingContext,
+            String apiflag) throws IOException {
         DeleteHandler deleteHandler = DeleteHandler.getInstance();
         if ("deletePapApi".equalsIgnoreCase(apiflag)) {
-            deleteHandler.doAPIDeleteFromPAP(request, response);
-            return;
+            deleteHandler.doApiDeleteFromPap(request, response);
         } else if ("deletePdpApi".equalsIgnoreCase(apiflag)) {
-            deleteHandler.doAPIDeleteFromPDP(request, response, loggingContext);
+            deleteHandler.doApiDeleteFromPdp(request, response, loggingContext);
             setNewGroup(deleteHandler.getDeletedGroup());
-            return;
         }
     }