X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;f=ECOMP-PDP-REST%2Fsrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fpolicy%2Fpdp%2Frest%2Fapi%2Fservices%2FGetMetricsService.java;h=5a90bfac9c5a24a7c2769ed51b35699b81a5701a;hb=e92ff832cf993db876f22b2d27562fedf59f5043;hp=dc431b0d51a3dcac6e431bdb6ac6c93194fb19fd;hpb=570290dc6ba8198e653022c2f6f8e5d01cfa8d1b;p=policy%2Fengine.git

diff --git a/ECOMP-PDP-REST/src/main/java/org/openecomp/policy/pdp/rest/api/services/GetMetricsService.java b/ECOMP-PDP-REST/src/main/java/org/openecomp/policy/pdp/rest/api/services/GetMetricsService.java
index dc431b0d5..5a90bfac9 100644
--- a/ECOMP-PDP-REST/src/main/java/org/openecomp/policy/pdp/rest/api/services/GetMetricsService.java
+++ b/ECOMP-PDP-REST/src/main/java/org/openecomp/policy/pdp/rest/api/services/GetMetricsService.java
@@ -34,12 +34,11 @@ import org.openecomp.policy.xacml.api.XACMLErrorConstants;
 import org.springframework.http.HttpStatus;
 
 public class GetMetricsService {
-	private static Logger LOGGER = FlexLogger
-			.getLogger(GetDictionaryService.class.getName());
+	private static final Logger LOGGER = FlexLogger
+			.getLogger(GetMetricsService.class.getName());
 
 	private MetricsResponse response = null;
 	private HttpStatus status = HttpStatus.BAD_REQUEST;
-	private String message = null;
 	private MetricsRequestParameters metricsParameters = null;
 
 	public GetMetricsService(String requestID) {
@@ -49,7 +48,7 @@ public class GetMetricsService {
 				requestUUID = UUID.fromString(requestID);
 			} catch (IllegalArgumentException e) {
 				requestUUID = UUID.randomUUID();
-				LOGGER.info("Generated Random UUID: " + requestUUID.toString());
+				LOGGER.info("Generated Random UUID: " + requestUUID.toString(), e);
 			}
 		} else {
 			requestUUID = UUID.randomUUID();
@@ -72,11 +71,9 @@ public class GetMetricsService {
 	}
 
 	private void specialCheck() {
-		if (response != null) {
-			if (response.getResponseMessage() != null
-					&& response.getResponseMessage().contains("PE300")) {
+		if (response != null && (response.getResponseMessage() != null
+					&& response.getResponseMessage().contains("PE300"))) {
 				status = HttpStatus.BAD_REQUEST;
-			}
 		}
 	}
 
@@ -100,11 +97,12 @@ public class GetMetricsService {
 				metricsParameters.getRequestID(), "metrics");
 
 		JSONObject json = null;
+		String message = null;
 		if (result != null) {
 			if (result.length() > 81 && result.contains("{")) {
 				try {
 					String responseMessage = result.substring(0, 82);
-					String jsonString = result.substring(result.indexOf("{"),
+					String jsonString = result.substring(result.indexOf('{'),
 							result.length());
 					json = new JSONObject(jsonString);