X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;ds=sidebyside;f=src%2Fmain%2Fjava%2Forg%2Fonap%2Fdmaap%2Fdbcapi%2Fservice%2FDR_SubService.java;h=9d233a53afdba219265b588943f87bea88606955;hb=d6ac6f8b10e90411dd650d6f7a9ee51179e39bfc;hp=d6012a7c944cc2ef0825a766d22860788a0fbb79;hpb=30e5f1d5366905fbb3e01c2b8a0a069f464fcc3e;p=dmaap%2Fdbcapi.git diff --git a/src/main/java/org/onap/dmaap/dbcapi/service/DR_SubService.java b/src/main/java/org/onap/dmaap/dbcapi/service/DR_SubService.java index d6012a7..9d233a5 100644 --- a/src/main/java/org/onap/dmaap/dbcapi/service/DR_SubService.java +++ b/src/main/java/org/onap/dmaap/dbcapi/service/DR_SubService.java @@ -3,6 +3,8 @@ * org.onap.dmaap * ================================================================================ * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved. + * + * Modifications Copyright (C) 2019 IBM. * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -63,11 +65,11 @@ public class DR_SubService extends BaseLoggingClass { public List getAllDr_Subs() { logger.debug( "enter getAllDR_Subs()"); - return new ArrayList(dr_subs.values()); + return new ArrayList<>(dr_subs.values()); } public ArrayList getDr_SubsByFeedId( String pubId ) { - ArrayList someSubs = new ArrayList(); + ArrayList someSubs = new ArrayList<>(); for( DR_Sub sub : dr_subs.values() ) { if ( pubId.equals( sub.getFeedId() )) { someSubs.add( sub ); @@ -94,9 +96,9 @@ public class DR_SubService extends BaseLoggingClass { prov = new DrProvConnection(); prov.makeSubPostConnection( provURL ); String resp = prov.doPostDr_Sub( sub, apiError ); - if ( unit_test.equals( "Yes" ) ) { + if ( "Yes".equals(unit_test) ) { resp = simulateResp( sub, "POST" ); - apiError.setCode(200); + apiError.setCode(201); } logger.debug( "addDr_Sub resp=" + resp ); @@ -108,7 +110,7 @@ public class DR_SubService extends BaseLoggingClass { snew.setLastMod(); addEgressRoute( snew, apiError ); dr_subs.put( snew.getSubId(), snew ); - apiError.setCode(200); + apiError.setCode(201); } else { apiError.setCode(400); }