X-Git-Url: https://gerrit.onap.org/r/gitweb?a=blobdiff_plain;ds=sidebyside;f=datarouter-prov%2Fsrc%2Fmain%2Fjava%2Forg%2Fonap%2Fdmaap%2Fdatarouter%2Fprovisioning%2Fbeans%2FEgressRoute.java;h=2b6462db7630c8946302a20f9edb084a6eef1923;hb=6c78b3e6a0a67c73f931337356a172cc69cee0e8;hp=a78a9c18bb70828d044b6594e818451589fadf4c;hpb=f20778ffa99aa9c6f30a0f84112a5392b259ea63;p=dmaap%2Fdatarouter.git

diff --git a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/EgressRoute.java b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/EgressRoute.java
index a78a9c18..2b6462db 100644
--- a/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/EgressRoute.java
+++ b/datarouter-prov/src/main/java/org/onap/dmaap/datarouter/provisioning/beans/EgressRoute.java
@@ -49,13 +49,14 @@ public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
     private final int subid;
     private final int nodeid;
 
+    /**
+     * EgressRoute constructor.
+     * @param subid subscription id
+     * @param nodeid node id
+     */
     public EgressRoute(int subid, int nodeid) {
         this.subid = subid;
         this.nodeid = nodeid;
-        // Note: unlike for Feeds, it subscriptions can be removed from the tables, so it is
-        // possible that an orphan ERT entry can exist if a sub is removed.
-        //        if (Subscription.getSubscriptionById(subid) == null)
-        //            throw new IllegalArgumentException("No such subscription: "+subid);
     }
 
     public EgressRoute(int subid, String node) {
@@ -101,7 +102,7 @@ public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
      * @return an EgressRoute, or null if there is no route for this subscription
      */
     public static EgressRoute getEgressRoute(int sub) {
-        EgressRoute v = null;
+        EgressRoute er = null;
         DB db = new DB();
         String sql = "select NODEID from EGRESS_ROUTES where SUBID = ?";
         try (Connection conn = db.getConnection();
@@ -110,7 +111,7 @@ public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
             try (ResultSet rs = ps.executeQuery()) {
                 if (rs.next()) {
                     int node = rs.getInt("NODEID");
-                    v = new EgressRoute(sub, node);
+                    er = new EgressRoute(sub, node);
                 }
             } finally {
                 db.release(conn);
@@ -118,14 +119,14 @@ public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
         } catch (SQLException e) {
             intlogger.error("PROV0009 EgressRoute.getEgressRoute: " + e.getMessage(), e);
         }
-        return v;
+        return er;
     }
 
     @Override
-    public boolean doDelete(Connection c) {
+    public boolean doDelete(Connection conn) {
         boolean rv = true;
         String sql = "delete from EGRESS_ROUTES where SUBID = ?";
-        try (PreparedStatement ps = c.prepareStatement(sql)) {
+        try (PreparedStatement ps = conn.prepareStatement(sql)) {
             ps.setInt(1, subid);
             ps.execute();
         } catch (SQLException e) {
@@ -136,15 +137,14 @@ public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
     }
 
     @Override
-    public boolean doInsert(Connection c) {
+    public boolean doInsert(Connection conn) {
         boolean rv = false;
         String sql = "insert into EGRESS_ROUTES (SUBID, NODEID) values (?, ?)";
-        try (PreparedStatement ps = c.prepareStatement(sql)) {
+        try (PreparedStatement ps = conn.prepareStatement(sql)) {
             // Create the NETWORK_ROUTES row
             ps.setInt(1, this.subid);
             ps.setInt(2, this.nodeid);
             ps.execute();
-            ps.close();
             rv = true;
         } catch (SQLException e) {
             intlogger.warn("PROV0005 doInsert: " + e.getMessage(), e);
@@ -153,10 +153,10 @@ public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
     }
 
     @Override
-    public boolean doUpdate(Connection c) {
+    public boolean doUpdate(Connection conn) {
         boolean rv = true;
         String sql = "update EGRESS_ROUTES set NODEID = ? where SUBID = ?";
-        try (PreparedStatement ps = c.prepareStatement(sql)) {
+        try (PreparedStatement ps = conn.prepareStatement(sql)) {
             ps.setInt(1, nodeid);
             ps.setInt(2, subid);
             ps.executeUpdate();
@@ -189,8 +189,8 @@ public class EgressRoute extends NodeClass implements Comparable<EgressRoute> {
     }
 
     @Override
-    public int compareTo(EgressRoute o) {
-        return this.subid - o.subid;
+    public int compareTo(EgressRoute er) {
+        return this.subid - er.subid;
     }
 
     @Override