Code Improvements-Vnfsdk-refrepo sonar issue fixes

[vnfsdk/refrepo.git] / vnfmarket-be / vnf-sdk-marketplace / src / main / java / org / onap / vnfsdk / marketplace / onboarding / hooks / validatelifecycle / LifecycleTestExceutor.java

diff --git a/vnfmarket-be/vnf-sdk-marketplace/src/main/java/org/onap/vnfsdk/marketplace/onboarding/hooks/validatelifecycle/LifecycleTestExceutor.java b/vnfmarket-be/vnf-sdk-marketplace/src/main/java/org/onap/vnfsdk/marketplace/onboarding/hooks/validatelifecycle/LifecycleTestExceutor.java
index bf6d287..4d2e074 100644 (file)
--- a/vnfmarket-be/vnf-sdk-marketplace/src/main/java/org/onap/vnfsdk/marketplace/onboarding/hooks/validatelifecycle/LifecycleTestExceutor.java
+++ b/vnfmarket-be/vnf-sdk-marketplace/src/main/java/org/onap/vnfsdk/marketplace/onboarding/hooks/validatelifecycle/LifecycleTestExceutor.java
@@ -16,7 +16,6 @@
 package org.onap.vnfsdk.marketplace.onboarding.hooks.validatelifecycle;
 
 import java.io.File;
-import java.io.IOException;
 import java.util.Map;
 
 import org.apache.http.entity.ContentType;
@@ -55,7 +54,7 @@ public class LifecycleTestExceutor {
        @SuppressWarnings("unchecked")
        public static String uploadPackageToCatalouge(OnBoradingRequest onBoradFuncTestReq) {
                String packagePath = onBoradFuncTestReq.getPackagePath() + File.separator + onBoradFuncTestReq.getPackageName();
-               logger.info("Package file path uploadPackageToCatalouge:" + packagePath);
+               logger.info("Package file path uploadPackageToCatalouge:{}" , packagePath);
 
                String catalougeCsarId = null;
 
@@ -87,14 +86,14 @@ public class LifecycleTestExceutor {
                                Integer.parseInt(oMsbDetails.getDefaultServer().getPort()), CommonConstant.CATALOUGE_UPLOAD_URL,
                                builder.build());
                if (!checkValidResponse(rsp)) {
-                       logger.error("Failed to upload package to catalouge:" + rsp.getStatusCode());
+                       logger.error("Failed to upload package to catalouge:{}" , rsp.getStatusCode());
                        return catalougeCsarId;
                }
 
-               logger.info("Response for uploadPackageToCatalouge :" + rsp.getResult());
+               logger.info("Response for uploadPackageToCatalouge :{}" , rsp.getResult());
                catalougeCsarId = getCsarIdValue(rsp.getResult());
 
-               logger.info("CSARID for uploadPackageToCatalouge :" + catalougeCsarId);
+               logger.info("CSARID for uploadPackageToCatalouge :{}" , catalougeCsarId);
                return catalougeCsarId;
        }
 
@@ -105,7 +104,7 @@ public class LifecycleTestExceutor {
         *            oLifeCycleTestReq
         * @return result of the test or null (in case of failure)
         */
-       public static String execlifecycleTest(OnBoradingRequest onBoradFuncTestReq, LifeCycleTestReq oLifeCycleTestReq) {
+       public static String execlifecycleTest(OnBoradingRequest onBoradFuncTestReq, LifeCycleTestReq oLifeCycleTestReq) { //NOSONAR
 
                String result = null;
                if ((null == onBoradFuncTestReq.getPackagePath()) || (null == onBoradFuncTestReq.getPackageName())) {
@@ -114,7 +113,7 @@ public class LifecycleTestExceutor {
                }
 
                String packagePath = onBoradFuncTestReq.getPackagePath() + File.separator + onBoradFuncTestReq.getPackageName();
-               logger.info("Package file path Function test:" + packagePath);
+               logger.info("Package file path Function test:{}" , packagePath);
 
                // Validate package path
                if (!FileUtil.validatePath(packagePath)) {
@@ -135,12 +134,12 @@ public class LifecycleTestExceutor {
                                oMsbDetails.getDefaultServer().getPort(), CommonConstant.LifeCycleTest.LIFECYCLE_TEST_URL, rawDataJson);
 
                if (!checkValidResponse(oResponse)) {
-                       logger.error("execlifecycleTest response is faliure :" + oResponse.getStatusCode());
+                       logger.error("execlifecycleTest response is faliure :{}" , oResponse.getStatusCode());
                        return result;
                }
 
                result = oResponse.getResult();
-               logger.info("Response execlifecycleTest :" + oResponse.getResult());
+               logger.info("Response execlifecycleTest :{}" , oResponse.getResult());
                return result;
        }