[DMAAP-CLIENT] First sonar issues review part2
[dmaap/messagerouter/dmaapclient.git] / src / test / java / org / onap / dmaap / mr / tools / MessageCommandTest.java
index 933ee48..c6c9af4 100644 (file)
@@ -4,12 +4,14 @@
  * ================================================================================
  * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
+ * Modifications Copyright © 2021 Orange.
+ * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 
 package org.onap.dmaap.mr.tools;
 
-import static org.junit.Assert.assertTrue;
-
-import java.io.IOException;
-import java.io.PrintStream;
-import java.util.Arrays;
-import java.util.Iterator;
-import java.util.List;
-import java.util.concurrent.TimeUnit;
-
+import com.att.nsa.cmdtool.CommandNotReadyException;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
@@ -36,181 +30,188 @@ import org.junit.runner.RunWith;
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
+import org.onap.dmaap.mr.client.MRBatchingPublisher;
+import org.onap.dmaap.mr.client.MRClientFactory;
+import org.onap.dmaap.mr.client.MRConsumer;
+import org.onap.dmaap.mr.client.MRTopicManager.TopicInfo;
 import org.powermock.api.mockito.PowerMockito;
 import org.powermock.core.classloader.annotations.PowerMockIgnore;
 import org.powermock.core.classloader.annotations.PrepareForTest;
 import org.powermock.modules.junit4.PowerMockRunner;
 
-import com.att.nsa.cmdtool.CommandNotReadyException;
-import org.onap.dmaap.mr.client.MRBatchingPublisher;
-import org.onap.dmaap.mr.client.MRClientFactory;
-import org.onap.dmaap.mr.client.MRConsumer;
-import org.onap.dmaap.mr.client.MRTopicManager.TopicInfo;
+import java.io.IOException;
+import java.io.PrintStream;
+import java.util.Arrays;
+import java.util.Iterator;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+import static org.junit.Assert.assertTrue;
 
 @RunWith(PowerMockRunner.class)
 @PowerMockIgnore("jdk.internal.reflect.*")
-@PrepareForTest({ MRClientFactory.class, ToolsUtil.class })
+@PrepareForTest({MRClientFactory.class, ToolsUtil.class})
 public class MessageCommandTest {
-       @InjectMocks
-       private MessageCommand command;
-       @Mock
-       private MRConsumer tm;
-       @Mock
-       private TopicInfo ti;
-       @Mock
-       private MRBatchingPublisher pub;
-       @Mock
-       private MRConsumer cc;
-       @Mock
-       private PrintStream printStream;
-
-       @Before
-       public void setUp() throws Exception {
-               MockitoAnnotations.initMocks(this);
-               PowerMockito.mockStatic(MRClientFactory.class);
-               PowerMockito.mockStatic(ToolsUtil.class);
-               PowerMockito.when(MRClientFactory.createConsumer(Arrays.asList("localhost"), "testtopic", "2", "3", -1, -1,
-                               null, null, null)).thenReturn(cc);
-
-       }
-
-       @After
-       public void tearDown() throws Exception {
-
-       }
-
-       @Test
-       public void testGetMatches() {
-
-               command.getMatches();
-               assertTrue(true);
-
-       }
-
-       @Test
-       public void testCheckReady() {
-
-               try {
-                       command.checkReady(new MRCommandContext());
-               } catch (CommandNotReadyException e) {
-                       // TODO Auto-generated catch block
-                       e.printStackTrace();
-               }
-               assertTrue(true);
-
-       }
-
-       @Test
-       public void testExecute() {
-
-               String[] parts1 = { "read", "testtopic", "2", "3" };
-               String[] parts2 = { "write", "testtopic", "2", "3" };
-               List<String[]> parts = Arrays.asList(parts1, parts2);
-               for (Iterator iterator = parts.iterator(); iterator.hasNext();) {
-                       String[] part = (String[]) iterator.next();
-
-                       MRCommandContext context = new MRCommandContext();
-                       PowerMockito.when(ToolsUtil.createBatchPublisher(context, "testtopic")).thenReturn(pub);
-                       try {
-                               command.execute(part, context, printStream);
-                       } catch (CommandNotReadyException e) {
-                               assertTrue(true);
-                       }
-               }
-               assertTrue(true);
-
-       }
-
-       @Test
-       public void testExecute_error1() {
-               try {
-                       PowerMockito.doThrow(new Exception()).when(cc).fetch();
-               } catch (IOException e) {
-                       // TODO Auto-generated catch block
-                       e.printStackTrace();
-               } catch (Exception e) {
-                       // TODO Auto-generated catch block
-                       e.printStackTrace();
-               }
-               String[] parts1 = { "read", "testtopic", "2", "3" };
-               String[] parts2 = { "write", "testtopic", "2", "3" };
-               List<String[]> parts = Arrays.asList(parts1, parts2);
-               for (Iterator iterator = parts.iterator(); iterator.hasNext();) {
-                       String[] part = (String[]) iterator.next();
-
-                       MRCommandContext context = new MRCommandContext();
-                       PowerMockito.when(ToolsUtil.createBatchPublisher(context, "testtopic")).thenReturn(pub);
-                       try {
-                               command.execute(part, context, printStream);
-                       } catch (CommandNotReadyException e) {
-                               // TODO Auto-generated catch block
-                               e.printStackTrace();
-                       }
-               }
-               assertTrue(true);
-
-       }
-
-       @Test
-       public void testExecute_error2() {
-               try {
-                       PowerMockito.doThrow(new IOException()).when(pub).close(500, TimeUnit.MILLISECONDS);
-                       PowerMockito.doThrow(new IOException()).when(pub).send("2", "3");
-
-               } catch (IOException e) {
-                       // TODO Auto-generated catch block
-                       e.printStackTrace();
-               } catch (InterruptedException e) {
-                       // TODO Auto-generated catch block
-                       e.printStackTrace();
-               }
-               String[] parts1 = { "read", "testtopic", "2", "3" };
-               String[] parts2 = { "write", "testtopic", "2", "3" };
-               List<String[]> parts = Arrays.asList(parts1, parts2);
-               for (Iterator iterator = parts.iterator(); iterator.hasNext();) {
-                       String[] part = (String[]) iterator.next();
-
-                       MRCommandContext context = new MRCommandContext();
-                       PowerMockito.when(ToolsUtil.createBatchPublisher(context, "testtopic")).thenReturn(pub);
-                       try {
-                               command.execute(part, context, printStream);
-                       } catch (CommandNotReadyException e) {
-                               // TODO Auto-generated catch block
-                               e.printStackTrace();
-                       }
-               }
-               assertTrue(true);
-
-       }
-
-       /*
-        * @Test public void testExecute_error3() {
-        * 
-        * try { PowerMockito.doThrow(new IOException()).when(pub).send("2", "3");
-        * PowerMockito.doThrow(new InterruptedException()).when(pub).close(500,
-        * TimeUnit.MILLISECONDS); } catch (IOException e) { // TODO Auto-generated
-        * catch block e.printStackTrace(); } catch (InterruptedException e) { //
-        * TODO Auto-generated catch block e.printStackTrace(); } String[] parts1 =
-        * { "read", "testtopic", "2", "3" }; String[] parts2 = { "write",
-        * "testtopic", "2", "3" }; List<String[]> parts = Arrays.asList(parts1,
-        * parts2); for (Iterator iterator = parts.iterator(); iterator.hasNext();)
-        * { String[] part = (String[]) iterator.next(); PrintStream printStream =
-        * new PrintStream(System.out);
-        * 
-        * MRCommandContext context = new MRCommandContext();
-        * PowerMockito.when(ToolsUtil.createBatchPublisher(context,
-        * "testtopic")).thenReturn(pub); try { command.execute(part, context,
-        * printStream); } catch (CommandNotReadyException e) { // TODO
-        * Auto-generated catch block e.printStackTrace(); } } assertTrue(true);
-        * 
-        * }
-        */
-
-       @Test
-       public void testDisplayHelp() {
-
-               command.displayHelp(printStream);
-
-       }
+    @InjectMocks
+    private MessageCommand command;
+    @Mock
+    private MRConsumer tm;
+    @Mock
+    private TopicInfo ti;
+    @Mock
+    private MRBatchingPublisher pub;
+    @Mock
+    private MRConsumer cc;
+    @Mock
+    private PrintStream printStream;
+
+    @Before
+    public void setUp() throws Exception {
+        MockitoAnnotations.initMocks(this);
+        PowerMockito.mockStatic(MRClientFactory.class);
+        PowerMockito.mockStatic(ToolsUtil.class);
+        PowerMockito.when(MRClientFactory.createConsumer(Arrays.asList("localhost"), "testtopic", "2", "3", -1, -1,
+                null, null, null)).thenReturn(cc);
+
+    }
+
+    @After
+    public void tearDown() throws Exception {
+
+    }
+
+    @Test
+    public void testGetMatches() {
+
+        command.getMatches();
+        assertTrue(true);
+
+    }
+
+    @Test
+    public void testCheckReady() {
+
+        try {
+            command.checkReady(new MRCommandContext());
+        } catch (CommandNotReadyException e) {
+            // TODO Auto-generated catch block
+            e.printStackTrace();
+        }
+        assertTrue(true);
+
+    }
+
+    @Test
+    public void testExecute() {
+
+        String[] parts1 = {"read", "testtopic", "2", "3"};
+        String[] parts2 = {"write", "testtopic", "2", "3"};
+        List<String[]> parts = Arrays.asList(parts1, parts2);
+        for (Iterator iterator = parts.iterator(); iterator.hasNext(); ) {
+            String[] part = (String[]) iterator.next();
+
+            MRCommandContext context = new MRCommandContext();
+            PowerMockito.when(ToolsUtil.createBatchPublisher(context, "testtopic")).thenReturn(pub);
+            try {
+                command.execute(part, context, printStream);
+            } catch (CommandNotReadyException e) {
+                assertTrue(true);
+            }
+        }
+        assertTrue(true);
+
+    }
+
+    @Test
+    public void testExecute_error1() {
+        try {
+            PowerMockito.doThrow(new Exception()).when(cc).fetch();
+        } catch (IOException e) {
+            // TODO Auto-generated catch block
+            e.printStackTrace();
+        } catch (Exception e) {
+            // TODO Auto-generated catch block
+            e.printStackTrace();
+        }
+        String[] parts1 = {"read", "testtopic", "2", "3"};
+        String[] parts2 = {"write", "testtopic", "2", "3"};
+        List<String[]> parts = Arrays.asList(parts1, parts2);
+        for (Iterator iterator = parts.iterator(); iterator.hasNext(); ) {
+            String[] part = (String[]) iterator.next();
+
+            MRCommandContext context = new MRCommandContext();
+            PowerMockito.when(ToolsUtil.createBatchPublisher(context, "testtopic")).thenReturn(pub);
+            try {
+                command.execute(part, context, printStream);
+            } catch (CommandNotReadyException e) {
+                // TODO Auto-generated catch block
+                e.printStackTrace();
+            }
+        }
+        assertTrue(true);
+
+    }
+
+    @Test
+    public void testExecute_error2() {
+        try {
+            PowerMockito.doThrow(new IOException()).when(pub).close(500, TimeUnit.MILLISECONDS);
+            PowerMockito.doThrow(new IOException()).when(pub).send("2", "3");
+
+        } catch (IOException e) {
+            // TODO Auto-generated catch block
+            e.printStackTrace();
+        } catch (InterruptedException e) {
+            // TODO Auto-generated catch block
+            e.printStackTrace();
+        }
+        String[] parts1 = {"read", "testtopic", "2", "3"};
+        String[] parts2 = {"write", "testtopic", "2", "3"};
+        List<String[]> parts = Arrays.asList(parts1, parts2);
+        for (Iterator iterator = parts.iterator(); iterator.hasNext(); ) {
+            String[] part = (String[]) iterator.next();
+
+            MRCommandContext context = new MRCommandContext();
+            PowerMockito.when(ToolsUtil.createBatchPublisher(context, "testtopic")).thenReturn(pub);
+            try {
+                command.execute(part, context, printStream);
+            } catch (CommandNotReadyException e) {
+                // TODO Auto-generated catch block
+                e.printStackTrace();
+            }
+        }
+        assertTrue(true);
+
+    }
+
+    /*
+     * @Test public void testExecute_error3() {
+     *
+     * try { PowerMockito.doThrow(new IOException()).when(pub).send("2", "3");
+     * PowerMockito.doThrow(new InterruptedException()).when(pub).close(500,
+     * TimeUnit.MILLISECONDS); } catch (IOException e) { // TODO Auto-generated
+     * catch block e.printStackTrace(); } catch (InterruptedException e) { //
+     * TODO Auto-generated catch block e.printStackTrace(); } String[] parts1 =
+     * { "read", "testtopic", "2", "3" }; String[] parts2 = { "write",
+     * "testtopic", "2", "3" }; List<String[]> parts = Arrays.asList(parts1,
+     * parts2); for (Iterator iterator = parts.iterator(); iterator.hasNext();)
+     * { String[] part = (String[]) iterator.next(); PrintStream printStream =
+     * new PrintStream(System.out);
+     *
+     * MRCommandContext context = new MRCommandContext();
+     * PowerMockito.when(ToolsUtil.createBatchPublisher(context,
+     * "testtopic")).thenReturn(pub); try { command.execute(part, context,
+     * printStream); } catch (CommandNotReadyException e) { // TODO
+     * Auto-generated catch block e.printStackTrace(); } } assertTrue(true);
+     *
+     * }
+     */
+
+    @Test
+    public void testDisplayHelp() {
+
+        command.displayHelp(printStream);
+        assertTrue(true);
+    }
 
 }