Sonar improvements and class renaming

[clamp.git] / src / test / java / org / onap / clamp / clds / it / PolicyClientIT.java

diff --git a/src/test/java/org/onap/clamp/clds/it/PolicyClientIT.java b/src/test/java/org/onap/clamp/clds/it/PolicyClientIT.java
index 7960c6a..19fad48 100644 (file)
--- a/src/test/java/org/onap/clamp/clds/it/PolicyClientIT.java
+++ b/src/test/java/org/onap/clamp/clds/it/PolicyClientIT.java
@@ -34,19 +34,21 @@ import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.onap.clamp.clds.AbstractIT;
+import org.onap.clamp.clds.client.req.OperationalPolicyReq;
+import org.onap.clamp.clds.client.req.StringMatchPolicyReq;
 import org.onap.clamp.clds.client.req.TcaMPolicyReq;
 import org.onap.clamp.clds.model.CldsEvent;
-import org.onap.clamp.clds.model.prop.*;
+import org.onap.clamp.clds.model.prop.ModelProperties;
+import org.onap.clamp.clds.model.prop.Policy;
+import org.onap.clamp.clds.model.prop.PolicyChain;
+import org.onap.clamp.clds.model.prop.StringMatch;
+import org.onap.clamp.clds.model.prop.Tca;
+import org.onap.clamp.clds.util.ResourceFileUtil;
 import org.onap.policy.api.AttributeType;
 import org.skyscreamer.jsonassert.JSONAssert;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
 import org.springframework.test.context.junit4.SpringRunner;
-import org.onap.clamp.clds.client.req.OperationalPolicyReq;
-import org.onap.clamp.clds.client.req.StringMatchPolicyReq;
-import org.onap.clamp.clds.transform.TransformUtil;
-
-import static org.junit.Assert.assertEquals;
 
 /**
  * Test Policy API in org.onap.clamp.ClampDesigner.client package - replicate
@@ -60,10 +62,13 @@ public class PolicyClientIT extends AbstractIT {
     String modelName;
     String controlName;
 
+    /**
+     * Initialize Test.
+     */
     @Before
     public void setUp() throws IOException {
-        modelProp = TransformUtil.getResourceAsString("example/modelProp.json");
-        modelBpmnProp = TransformUtil.getResourceAsString("example/modelBpmnProp.json");
+        modelProp = ResourceFileUtil.getResourceAsString("example/modelProp.json");
+        modelBpmnProp = ResourceFileUtil.getResourceAsString("example/modelBpmnProp.json");
         modelName = "example-model06";
         controlName = "ClosedLoop_FRWL_SIG_fad4dcae_e498_11e6_852e_0050568c4ccf";
     }
@@ -75,11 +80,11 @@ public class PolicyClientIT extends AbstractIT {
             String stringMatchPolicyRequestUuid = UUID.randomUUID().toString();
 
             String policyJson = StringMatchPolicyReq.format(refProp, prop);
-            String correctValue = TransformUtil.getResourceAsString("expected/stringmatch.json");
+            String correctValue = ResourceFileUtil.getResourceAsString("expected/stringmatch.json");
             JSONAssert.assertEquals(policyJson, correctValue, true);
             String responseMessage = "";
             try {
-                responseMessage = policyClient.sendMicroService(policyJson, prop, stringMatchPolicyRequestUuid);
+                responseMessage = policyClient.sendMicroServiceInJson(policyJson, prop, stringMatchPolicyRequestUuid);
             } catch (Exception e) {
                 assertTrue(e.getMessage().contains("Policy send failed: PE500 "));
             }
@@ -96,7 +101,7 @@ public class PolicyClientIT extends AbstractIT {
 
                 Map<AttributeType, Map<String, String>> attributes = OperationalPolicyReq.formatAttributes(refProp,
                         prop, policy.getId(), policyChain);
-                String responseMessage = policyClient.sendBrms(attributes, prop, operationalPolicyRequestUuid);
+                String responseMessage = policyClient.sendBrmsPolicy(attributes, prop, operationalPolicyRequestUuid);
                 System.out.println(responseMessage);
             }
         }
@@ -104,15 +109,15 @@ public class PolicyClientIT extends AbstractIT {
 
     private void createUpdateTcaPolicy(String actionCd) throws Exception {
         ModelProperties prop = new ModelProperties(modelName, controlName, actionCd, false, modelBpmnProp, modelProp);
-        Tca tca = prop.getTca();
+        Tca tca = prop.getType(Tca.class);
         if (tca.isFound()) {
             String tcaPolicyRequestUuid = UUID.randomUUID().toString();
             String policyJson = TcaMPolicyReq.formatTca(refProp, prop);
-            String correctValue = TransformUtil.getResourceAsString("expected/tca.json");
+            String correctValue = ResourceFileUtil.getResourceAsString("expected/tca.json");
             JSONAssert.assertEquals(policyJson, correctValue, true);
             String responseMessage = "";
             try {
-                responseMessage = policyClient.sendMicroService(policyJson, prop, tcaPolicyRequestUuid);
+                responseMessage = policyClient.sendMicroServiceInJson(policyJson, prop, tcaPolicyRequestUuid);
             } catch (Exception e) {
                 assertTrue(e.getMessage().contains("Policy send failed: PE500 "));
             }
@@ -153,7 +158,7 @@ public class PolicyClientIT extends AbstractIT {
     private void deleteTcaPolicy(String actionCd) throws Exception {
         ModelProperties prop = new ModelProperties(modelName, controlName, actionCd, false, modelBpmnProp, modelProp);
 
-        Tca tca = prop.getTca();
+        Tca tca = prop.getType(Tca.class);
         if (tca.isFound()) {
             prop.setCurrentModelElementId(tca.getId());
             String responseMessage = "";
@@ -168,6 +173,9 @@ public class PolicyClientIT extends AbstractIT {
     }
 
     // @Test
+    /**
+     * Temporarily disabled Test.
+     */
     public void testCreateUpdateDeleteStringMatchPolicy() throws Exception {
 
         createUpdateStringMatch(CldsEvent.ACTION_SUBMIT);
@@ -178,6 +186,9 @@ public class PolicyClientIT extends AbstractIT {
     }
 
     // @Test
+    /**
+     * Temporarily disabled Test.
+     */
     public void testCreateUpdateDeleteOperationalPolicy() throws Exception {
 
         createUpdateOperationalPolicy(CldsEvent.ACTION_SUBMIT);