Fix checkstyle violations in sdc/jtosca

[sdc/sdc-tosca.git] / src / main / java / org / onap / sdc / toscaparser / api / elements / constraints / MaxLength.java

diff --git a/src/main/java/org/onap/sdc/toscaparser/api/elements/constraints/MaxLength.java b/src/main/java/org/onap/sdc/toscaparser/api/elements/constraints/MaxLength.java
index 2cb20eb..9068b65 100644 (file)
--- a/src/main/java/org/onap/sdc/toscaparser/api/elements/constraints/MaxLength.java
+++ b/src/main/java/org/onap/sdc/toscaparser/api/elements/constraints/MaxLength.java
@@ -7,9 +7,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -21,55 +21,54 @@
 package org.onap.sdc.toscaparser.api.elements.constraints;
 
 import org.onap.sdc.toscaparser.api.common.JToscaValidationIssue;
+import org.onap.sdc.toscaparser.api.utils.ThreadLocalsHolder;
 
+import java.util.Collections;
 import java.util.LinkedHashMap;
 
-import org.onap.sdc.toscaparser.api.utils.ThreadLocalsHolder;
-
 public class MaxLength extends Constraint {
-       // Constraint class for "min_length"
-       
-       // Constrains the property or parameter to a value of a maximum length.
-
-       @Override
-       protected void _setValues() {
-
-               constraintKey = MAX_LENGTH;
-
-               validTypes.add("Integer");
-               
-               validPropTypes.add(Schema.STRING);
-               validPropTypes.add(Schema.MAP);
-               
-       }
-       
-       public MaxLength(String name,String type,Object c) {
-               super(name,type,c);
-               
-               if(!validTypes.contains(constraintValue.getClass().getSimpleName())) {
-               ThreadLocalsHolder.getCollector().appendValidationIssue(new JToscaValidationIssue("JE112", "InvalidSchemaError: The property \"max_length\" expects an integer")); 
-               }
-       }
-       
-       @SuppressWarnings("unchecked")
-       @Override
-       protected boolean _isValid(Object value) {
-           if(value instanceof String && constraintValue instanceof Integer &&
-                       ((String)value).length() <= (Integer)constraintValue) {
-               return true;
-           }
-           else if(value instanceof LinkedHashMap && constraintValue instanceof Integer &&
-                       ((LinkedHashMap<String,Object>)value).size() <= (Integer)constraintValue) {
-               return true;
-           }
-               return false;
-       }
-
-       @Override
-       protected String _errMsg(Object value) {
-           return String.format("Length of value \"%s\" of property \"%s\" must be no greater than \"%s\"",
-                                                value.toString(),propertyName,constraintValue.toString());
-       }
+    // Constraint class for "min_length"
+
+    // Constrains the property or parameter to a value of a maximum length.
+
+    @Override
+    protected void setValues() {
+
+        setConstraintKey(MAX_LENGTH);
+
+        addValidTypes(Collections.singletonList("Integer"));
+
+
+        validPropTypes.add(Schema.STRING);
+        validPropTypes.add(Schema.MAP);
+
+    }
+
+    public MaxLength(String name, String type, Object c) {
+        super(name, type, c);
+
+        if (!validTypes.contains(constraintValue.getClass().getSimpleName())) {
+            ThreadLocalsHolder.getCollector().appendValidationIssue(new JToscaValidationIssue("JE112", "InvalidSchemaError: The property \"max_length\" expects an integer"));
+        }
+    }
+
+    @SuppressWarnings("unchecked")
+    @Override
+    protected boolean isValid(Object value) {
+        if (value instanceof String && constraintValue instanceof Integer
+                && ((String) value).length() <= (Integer) constraintValue) {
+            return true;
+        } else {
+            return value instanceof LinkedHashMap && constraintValue instanceof Integer
+                    && ((LinkedHashMap<String, Object>) value).size() <= (Integer) constraintValue;
+        }
+    }
+
+    @Override
+    protected String errMsg(Object value) {
+        return String.format("Length of value \"%s\" of property \"%s\" must be no greater than \"%s\"",
+                value.toString(), propertyName, constraintValue.toString());
+    }
 
 }