[DMAAP-CLIENT] First sonar issues review part2

[dmaap/messagerouter/dmaapclient.git] / src / main / java / org / onap / dmaap / mr / dme / client / PreferredRouteRequestHandler.java

diff --git a/src/main/java/org/onap/dmaap/mr/dme/client/PreferredRouteRequestHandler.java b/src/main/java/org/onap/dmaap/mr/dme/client/PreferredRouteRequestHandler.java
index dd0b286..bb5309f 100644 (file)
--- a/src/main/java/org/onap/dmaap/mr/dme/client/PreferredRouteRequestHandler.java
+++ b/src/main/java/org/onap/dmaap/mr/dme/client/PreferredRouteRequestHandler.java
@@ -4,11 +4,13 @@
  *  ================================================================================
  *  Copyright © 2017 AT&T Intellectual Property. All rights reserved.
  *  ================================================================================
+ *  Modifications Copyright © 2021 Orange.
+ *  ================================================================================
  *  Licensed under the Apache License, Version 2.0 (the "License");
  *  you may not use this file except in compliance with the License.
  *  You may obtain a copy of the License at
  *        http://www.apache.org/licenses/LICENSE-2.0
- *  
+ *
  *  Unless required by applicable law or agreed to in writing, software
  *  distributed under the License is distributed on an "AS IS" BASIS,
  *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -17,38 +19,34 @@
  *  ============LICENSE_END=========================================================
  *
  *  ECOMP is a trademark and service mark of AT&T Intellectual Property.
- *  
+ *
  *******************************************************************************/
-package org.onap.dmaap.mr.dme.client;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+package org.onap.dmaap.mr.dme.client;
 
 import com.att.aft.dme2.api.util.DME2ExchangeRequestContext;
 import com.att.aft.dme2.api.util.DME2ExchangeRequestHandler;
 import org.onap.dmaap.mr.client.MRClientFactory;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class PreferredRouteRequestHandler implements DME2ExchangeRequestHandler {
-       private Logger logger = LoggerFactory.getLogger(this.getClass().getName());
-
-       @Override
-       public void handleRequest(DME2ExchangeRequestContext requestData) {
-
-               if (requestData != null) {
-
-                       requestData.setPreferredRouteOffer(readRoute("preferredRouteKey"));
-               }
-       }
-
-       public String readRoute(String routeKey) {
-
-               try {
-
-                       MRClientFactory.prop.load(MRClientFactory.routeReader);
 
-               } catch (Exception ex) {
-                       logger.error("Request Router Error ", ex);
-               }
-               return MRClientFactory.prop.getProperty(routeKey);
-       }
+    private static final Logger logger = LoggerFactory.getLogger(PreferredRouteRequestHandler.class);
+
+    @Override
+    public void handleRequest(DME2ExchangeRequestContext requestData) {
+        if (requestData != null) {
+            requestData.setPreferredRouteOffer(readRoute("preferredRouteKey"));
+        }
+    }
+
+    public String readRoute(String routeKey) {
+        try {
+            MRClientFactory.prop.load(MRClientFactory.routeReader);
+        } catch (Exception ex) {
+            logger.error("Request Router Error ", ex);
+        }
+        return MRClientFactory.prop.getProperty(routeKey);
+    }
 }