Fixed various sonar identified code smells

[clamp.git] / src / main / java / org / onap / clamp / clds / camel / CamelProxy.java

diff --git a/src/main/java/org/onap/clamp/clds/camel/CamelProxy.java b/src/main/java/org/onap/clamp/clds/camel/CamelProxy.java
index a74f4c7..f626598 100644 (file)
--- a/src/main/java/org/onap/clamp/clds/camel/CamelProxy.java
+++ b/src/main/java/org/onap/clamp/clds/camel/CamelProxy.java
@@ -5,6 +5,8 @@
  * Copyright (C) 2018 AT&T Intellectual Property. All rights
  *                             reserved.
  * ================================================================================
+ * Modifications Copyright (c) 2019 Samsung
+ * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
@@ -18,7 +20,7 @@
  * limitations under the License.
  * ============LICENSE_END============================================
  * ===================================================================
- * 
+ *
  */
 
 package org.onap.clamp.clds.camel;
@@ -29,41 +31,32 @@ import org.apache.camel.ExchangeProperty;
  * This interface describes the CamelProxy parameters that must be passed to the
  * Camel flow.
  */
+@FunctionalInterface
 public interface CamelProxy {
 
     /**
      * This method is called when invoking a camel flow.
-     * 
-     * @param actionCommand
-     *            The action coming from the Clamp UI (like SUBMIT, UPDATE,
-     *            DELETE, ...)
-     * @param modelProperties
-     *            The Model properties created based on the BPMN Json and
-     *            Properties Json
-     * @param modelBpmnProperties
-     *            The Json with all the properties describing the flow
-     * @param modelName
-     *            The model name
-     * @param controlName
-     *            The control loop name
-     * @param docText
-     *            The Global properties JSON containing YAML (coming from CLamp
-     *            template)
-     * @param isTest
-     *            Is a test or not (flag coming from the UI)
-     * @param userId
-     *            The user ID coming from the UI
-     * @param isInsertTestEvent
-     *            Is a test or not (flag coming from the UI)
-     * @param eventAction
-     *            The latest event action in database (like CREATE, SUBMIT, ...)
+     *
+     * @param actionCommand       The action coming from the Clamp UI (like SUBMIT, UPDATE,
+     *                            DELETE, ...)
+     * @param modelProperties     The Model properties created based on the BPMN Json and
+     *                            Properties Json
+     * @param modelBpmnProperties The Json with all the properties describing the flow
+     * @param modelName           The model name
+     * @param controlName         The control loop name
+     * @param docText             The Global properties JSON containing YAML (coming from CLamp
+     *                            template)
+     * @param isTest              Is a test or not (flag coming from the UI)
+     * @param userId              The user ID coming from the UI
+     * @param isInsertTestEvent   Is a test or not (flag coming from the UI)
+     * @param eventAction         The latest event action in database (like CREATE, SUBMIT, ...)
      * @return A string containing the result of the Camel flow execution
      */
     String executeAction(@ExchangeProperty("actionCd") String actionCommand,
-            @ExchangeProperty("modelProp") String modelProperties,
-            @ExchangeProperty("modelBpmnProp") String modelBpmnProperties,
-            @ExchangeProperty("modelName") String modelName, @ExchangeProperty("controlName") String controlName,
-            @ExchangeProperty("docText") String docText, @ExchangeProperty("isTest") boolean isTest,
-            @ExchangeProperty("userid") String userId, @ExchangeProperty("isInsertTestEvent") boolean isInsertTestEvent,
-            @ExchangeProperty("eventAction") String eventAction);
+                         @ExchangeProperty("modelProp") String modelProperties,
+                         @ExchangeProperty("modelBpmnProp") String modelBpmnProperties,
+                         @ExchangeProperty("modelName") String modelName, @ExchangeProperty("controlName") String controlName,
+                         @ExchangeProperty("docText") String docText, @ExchangeProperty("isTest") boolean isTest,
+                         @ExchangeProperty("userid") String userId, @ExchangeProperty("isInsertTestEvent") boolean isInsertTestEvent,
+                         @ExchangeProperty("eventAction") String eventAction);
 }