Fix simple Sonar Lint issues

[aai/search-data-service.git] / src / main / java / org / onap / aai / sa / rest / AnalyzerApi.java

diff --git a/src/main/java/org/onap/aai/sa/rest/AnalyzerApi.java b/src/main/java/org/onap/aai/sa/rest/AnalyzerApi.java
index 210953d..664124d 100644 (file)
--- a/src/main/java/org/onap/aai/sa/rest/AnalyzerApi.java
+++ b/src/main/java/org/onap/aai/sa/rest/AnalyzerApi.java
@@ -1,4 +1,4 @@
-/**
+/**
  * ============LICENSE_START=======================================================
  * org.onap.aai
  * ================================================================================
@@ -50,22 +50,18 @@ public class AnalyzerApi {
 
   // Set up the loggers.
   private static Logger logger = LoggerFactory.getInstance().getLogger(IndexApi.class.getName());
-  private static Logger auditLogger = LoggerFactory.getInstance()
-      .getAuditLogger(IndexApi.class.getName());
+    private static Logger auditLogger = LoggerFactory.getInstance().getAuditLogger(IndexApi.class.getName());
 
   public AnalyzerApi( @Qualifier("searchServiceApi") SearchServiceApi searchService) {
     this.searchService = searchService;
   }
 
-  @RequestMapping(method = RequestMethod.GET,
-          consumes = {"application/json"},
-          produces = {"application/json"})
-  public ResponseEntity<String> processGet(HttpServletRequest request,
-                                           @RequestHeader HttpHeaders headers,
+    @RequestMapping(method = RequestMethod.GET, consumes = {"application/json"}, produces = {"application/json"})
+    public ResponseEntity<String> processGet(HttpServletRequest request, @RequestHeader HttpHeaders headers,
                                            ApiUtils apiUtils) {
 
     HttpStatus responseCode = HttpStatus.INTERNAL_SERVER_ERROR;
-    String responseString = "Undefined error";
+        String responseString;
 
     // Initialize the MDC Context for logging purposes.
     ApiUtils.initMdcContext(request, headers);
@@ -74,40 +70,39 @@ public class AnalyzerApi {
     // any further.
     try {
 
-      if (!searchService.validateRequest(headers, request,
-          ApiUtils.Action.GET, ApiUtils.SEARCH_AUTH_POLICY_NAME)) {
+            if (!searchService.validateRequest(headers, request, ApiUtils.Action.GET,
+                    ApiUtils.SEARCH_AUTH_POLICY_NAME)) {
         logger.warn(SearchDbMsgs.GET_ANALYZERS_FAILURE, "Authentication failure.");
-        return ResponseEntity.status(HttpStatus.FORBIDDEN).contentType ( MediaType.APPLICATION_JSON ).body("Authentication failure.");
+                return ResponseEntity.status(HttpStatus.FORBIDDEN).contentType(MediaType.APPLICATION_JSON)
+                        .body("Authentication failure.");
       }
 
     } catch (Exception e) {
 
       logger.warn(SearchDbMsgs.GET_ANALYZERS_FAILURE,
           "Unexpected authentication failure - cause: " + e.getMessage());
-      return ResponseEntity.status(HttpStatus.FORBIDDEN).contentType ( MediaType.APPLICATION_JSON ).body("Authentication failure.");
+            return ResponseEntity.status(HttpStatus.FORBIDDEN).contentType(MediaType.APPLICATION_JSON)
+                    .body("Authentication failure.");
     }
 
 
     // Now, build the list of analyzers.
     try {
-      responseString = buildAnalyzerList(ElasticSearchHttpController.getInstance()
-          .getAnalysisConfig());
+            responseString = buildAnalyzerList(ElasticSearchHttpController.getInstance().getAnalysisConfig());
       responseCode = HttpStatus.OK;
-
     } catch (Exception e) {
-
       logger.warn(SearchDbMsgs.GET_ANALYZERS_FAILURE,
           "Unexpected failure retrieving analysis configuration - cause: " + e.getMessage());
       responseString = "Failed to retrieve analysis configuration.  Cause: " + e.getMessage();
     }
 
     // Build the HTTP response.
-    ResponseEntity response = ResponseEntity.status(responseCode).contentType ( MediaType.APPLICATION_JSON ).body(responseString);
+        ResponseEntity<String> response =
+                ResponseEntity.status(responseCode).contentType(MediaType.APPLICATION_JSON).body(responseString);
 
     // Generate our audit log.
     auditLogger.info(SearchDbMsgs.PROCESS_REST_REQUEST,
-        new LogFields()
-            .setField(LogLine.DefinedFields.RESPONSE_CODE, responseCode.value ())
+                new LogFields().setField(LogLine.DefinedFields.RESPONSE_CODE, responseCode.value())
             .setField(LogLine.DefinedFields.RESPONSE_DESCRIPTION, responseCode.value()),
         (request != null) ? request.getMethod() : "Unknown",
         (request != null) ? request.getRequestURL ().toString () : "Unknown",
@@ -121,16 +116,13 @@ public class AnalyzerApi {
     return response;
   }
 
-
   /**
-   * This method takes a list of analyzer objects and generates a simple json
-   * structure to enumerate them.
+     * This method takes a list of analyzer objects and generates a simple json structure to enumerate them.
    *
-   * <p>Note, this includes only the aspects of the analyzer object that we want
-   * to make public to an external client.
+     * <p>
+     * Note, this includes only the aspects of the analyzer object that we want to make public to an external client.
    *
-   * @param analysisConfig - The analysis configuration object to extract the
-   *                       analyzers from.
+     * @param analysisConfig - The analysis configuration object to extract the analyzers from.
    * @return - A json string enumerating the defined analyzers.
    */
   private String buildAnalyzerList(AnalysisConfiguration analysisConfig) {