Fix Sonar vulnerabilities and Bugs

[dmaap/messagerouter/messageservice.git] / src / main / java / com / att / nsa / dmaap / filemonitor / ServicePropertiesMap.java

diff --git a/src/main/java/com/att/nsa/dmaap/filemonitor/ServicePropertiesMap.java b/src/main/java/com/att/nsa/dmaap/filemonitor/ServicePropertiesMap.java
index 0f7744c..219a601 100644 (file)
--- a/src/main/java/com/att/nsa/dmaap/filemonitor/ServicePropertiesMap.java
+++ b/src/main/java/com/att/nsa/dmaap/filemonitor/ServicePropertiesMap.java
@@ -8,33 +8,27 @@
  *  you may not use this file except in compliance with the License.
  *  You may obtain a copy of the License at
  *        http://www.apache.org/licenses/LICENSE-2.0
- *  
+*  
  *  Unless required by applicable law or agreed to in writing, software
  *  distributed under the License is distributed on an "AS IS" BASIS,
  *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  *  See the License for the specific language governing permissions and
  *  limitations under the License.
  *  ============LICENSE_END=========================================================
- *
+ *  
  *  ECOMP is a trademark and service mark of AT&T Intellectual Property.
  *  
  *******************************************************************************/
 package com.att.nsa.dmaap.filemonitor;
 
-import java.io.File;
-import java.io.FileInputStream;
 import java.util.HashMap;
-import java.util.Map;
-import java.util.Properties;
 
 import com.att.eelf.configuration.EELFLogger;
 import com.att.eelf.configuration.EELFManager;
-import com.fasterxml.jackson.core.type.TypeReference;
-import com.fasterxml.jackson.databind.ObjectMapper;
 
 /**
  * ServicePropertiesMap class
- * @author author
+ * @author rajashree.khare
  *
  */
 @SuppressWarnings("squid:S1118") 
@@ -50,17 +44,14 @@ public class ServicePropertiesMap
         * @param file file
         * @throws Exception ex
         */
-       public static void refresh(File file) throws Exception
+       /*public static void refresh(File file) throws Exception
        {
-               String filePath= null;
                try
                {
                        logger.info("Loading properties - " + (file != null?file.getName():""));
                        
                        //Store .json & .properties files into map of maps
-                       if (file != null) {
-                               filePath = file.getPath();
-                       }
+                       String filePath = file.getPath();
                        
                        if(filePath.lastIndexOf(".json")>0){
                                
@@ -68,10 +59,9 @@ public class ServicePropertiesMap
                                TypeReference<HashMap<String, String>> typeRef = 
                                                new TypeReference<HashMap<String, String>>() {};
                                HashMap<String, String> propMap = om.readValue(file, typeRef);
-                               HashMap<String, String> lcasePropMap = new HashMap<>();
-                               for (Map.Entry<String,String> entry : propMap.entrySet())
+                               HashMap<String, String> lcasePropMap = new HashMap<String, String>();
+                               for (String key : propMap.keySet() )
                                {
-                                       String key = entry.getKey();
                                        String lcaseKey = ifNullThenEmpty(key);
                                        lcasePropMap.put(lcaseKey, propMap.get(key));
                                }
@@ -85,7 +75,7 @@ public class ServicePropertiesMap
                                prop.load(fis);
                                
                                @SuppressWarnings("unchecked")
-                               HashMap<String, String> propMap = new HashMap<>((Map)prop);
+                               HashMap<String, String> propMap = new HashMap<String, String>((Map)prop);
                                
                                mapOfMaps.put(file.getName(), propMap);
                        }
@@ -98,7 +88,7 @@ public class ServicePropertiesMap
                        logger.error("File " + (file != null?file.getName():"") + " cannot be loaded into the map ", e);
                        throw new Exception("Error reading map file " + (file != null?file.getName():""), e);
                }
-       }
+       }*/
        /**
         * Get property
         * @param fileName fileName
@@ -115,7 +105,7 @@ public class ServicePropertiesMap
         * @param fileName fileName
         * @return mapProp
         */
-       public static Map<String, String> getProperties(String fileName){
+       public static HashMap<String, String> getProperties(String fileName){
                return mapOfMaps.get(fileName);
        }