/**
- * Copyright 2021 ZTE Corporation.
+ * Copyright 2021-2022 ZTE Corporation.
* <p>
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
package org.onap.holmes.rulemgt.dcae;
import org.easymock.EasyMock;
+import org.junit.Rule;
import org.junit.Test;
+import org.junit.contrib.java.lang.system.SystemOutRule;
import org.junit.runner.RunWith;
import org.onap.holmes.common.ConfigFileScanner;
import org.onap.holmes.common.utils.FileUtils;
import org.powermock.modules.junit4.PowerMockRunner;
import org.powermock.reflect.Whitebox;
-import java.util.HashMap;
-import java.util.Map;
-
-import static org.hamcrest.core.Is.is;
-import static org.hamcrest.core.IsEqual.equalTo;
+import static org.hamcrest.CoreMatchers.containsString;
+import static org.hamcrest.core.IsNot.not;
import static org.junit.Assert.assertThat;
@RunWith(PowerMockRunner.class)
@SuppressStaticInitializationFor({"org.onap.holmes.common.utils.JerseyClient"})
public class ConfigFileScanningTaskTest {
+ @Rule
+ public final SystemOutRule systemOut = new SystemOutRule().enableLog();
+
@Test
- public void run_add_rules() throws Exception {
- String clName = "ControlLoop-VOLTE-2179b738-fd36-4843-a71a-a8c24c70c55b";
+ public void run_failed_to_get_existing_rules() throws Exception {
+ System.setProperty("ENABLE_ENCRYPT", "true");
+
String indexPath = getFilePath("index-add.json");
- String contents = FileUtils.readTextFile(indexPath);
ConfigFileScanningTask cfst = new ConfigFileScanningTask(null);
Whitebox.setInternalState(cfst, "configFile", indexPath);
// mock for getExistingRules
JerseyClient jcMock = PowerMock.createMock(JerseyClient.class);
PowerMock.expectNew(JerseyClient.class).andReturn(jcMock).anyTimes();
- RuleQueryListResponse rqlr = new RuleQueryListResponse();
- rqlr.getCorrelationRules().add(getRuleResult4API(clName, contents));
- EasyMock.expect(jcMock.get(EasyMock.anyString(), EasyMock.anyObject())).andReturn(rqlr);
-
- // mock for deployRule
- EasyMock.expect(jcMock.header(EasyMock.anyString(), EasyMock.anyObject())).andReturn(jcMock);
- EasyMock.expect(jcMock.put(EasyMock.anyString(), EasyMock.anyObject())).andReturn("");
+ EasyMock.expect(jcMock.get(EasyMock.anyString(), EasyMock.anyObject())).andThrow(new RuntimeException());
PowerMock.replayAll();
cfst.run();
PowerMock.verifyAll();
- Map<String, String> config = Whitebox.getInternalState(cfst, "configInEffect");
- assertThat(config.size(), is(1));
+ assertThat(systemOut.getLog(), containsString("Failed to get existing rules for comparison."));
}
@Test
- public void run_remove_rules_normal() throws Exception {
+ public void run_add_rules() throws Exception {
+ System.setProperty("ENABLE_ENCRYPT", "true");
+
String clName = "ControlLoop-VOLTE-2179b738-fd36-4843-a71a-a8c24c70c55b";
String indexPath = getFilePath("index-add.json");
String contents = FileUtils.readTextFile(indexPath);
- Map<String, String> configInEffect = new HashMap<>();
- configInEffect.put(clName, contents);
- ConfigFileScanningTask cfst = new ConfigFileScanningTask(new ConfigFileScanner());
- Whitebox.setInternalState(cfst, "configFile", getFilePath("index-empty.json"));
- Whitebox.setInternalState(cfst, "configInEffect", configInEffect);
+ ConfigFileScanningTask cfst = new ConfigFileScanningTask(null);
+ Whitebox.setInternalState(cfst, "configFile", indexPath);
// mock for getExistingRules
JerseyClient jcMock = PowerMock.createMock(JerseyClient.class);
PowerMock.expectNew(JerseyClient.class).andReturn(jcMock).anyTimes();
RuleQueryListResponse rqlr = new RuleQueryListResponse();
- rqlr.getCorrelationRules().add(getRuleResult4API(clName, contents));
EasyMock.expect(jcMock.get(EasyMock.anyString(), EasyMock.anyObject())).andReturn(rqlr);
- // mock for deleteRule
- EasyMock.expect(jcMock.delete(EasyMock.anyString())).andReturn("");
+ // mock for deployRule
+ EasyMock.expect(jcMock.header(EasyMock.anyString(), EasyMock.anyObject())).andReturn(jcMock).times(2);
+ EasyMock.expect(jcMock.put(EasyMock.anyString(), EasyMock.anyObject())).andReturn("");
PowerMock.replayAll();
cfst.run();
PowerMock.verifyAll();
- Map<String, String> config = Whitebox.getInternalState(cfst, "configInEffect");
- assertThat(config.size(), is(0));
+ assertThat(systemOut.getLog(), containsString("Rule 'ControlLoop-VOLTE-2179b738-fd36-4843-a71a-a8c24c70c55b' has been deployed."));
+
+ System.clearProperty("ENABLE_ENCRYPT");
}
@Test
- public void run_remove_rules_delete_null_pointer() throws Exception {
+ public void run_remove_rules_normal() throws Exception {
+ System.setProperty("ENABLE_ENCRYPT", "false");
+
String clName = "ControlLoop-VOLTE-2179b738-fd36-4843-a71a-a8c24c70c55b";
String indexPath = getFilePath("index-add.json");
String contents = FileUtils.readTextFile(indexPath);
- Map<String, String> configInEffect = new HashMap<>();
- configInEffect.put(clName, contents);
ConfigFileScanningTask cfst = new ConfigFileScanningTask(new ConfigFileScanner());
- Whitebox.setInternalState(cfst, "configFile", indexPath);
- Whitebox.setInternalState(cfst, "configInEffect", configInEffect);
+ Whitebox.setInternalState(cfst, "configFile", getFilePath("index-empty.json"));
// mock for getExistingRules
JerseyClient jcMock = PowerMock.createMock(JerseyClient.class);
PowerMock.expectNew(JerseyClient.class).andReturn(jcMock).anyTimes();
RuleQueryListResponse rqlr = new RuleQueryListResponse();
- rqlr.getCorrelationRules().add(getRuleResult4API("a-non-existing-rule", contents));
+ rqlr.getCorrelationRules().add(getRuleResult4API(clName, contents));
EasyMock.expect(jcMock.get(EasyMock.anyString(), EasyMock.anyObject())).andReturn(rqlr);
+ // mock for deleteRule
+ EasyMock.expect(jcMock.delete(EasyMock.anyString())).andReturn("");
+
PowerMock.replayAll();
cfst.run();
PowerMock.verifyAll();
- Map<String, String> config = Whitebox.getInternalState(cfst, "configInEffect");
- assertThat(config.size(), is(1));
+ assertThat(systemOut.getLog(), containsString("Rule 'ControlLoop-VOLTE-2179b738-fd36-4843-a71a-a8c24c70c55b' has been removed."));
+
+ System.clearProperty("ENABLE_ENCRYPT");
}
@Test
String clName = "ControlLoop-VOLTE-2179b738-fd36-4843-a71a-a8c24c70c55b";
String indexPath = getFilePath("index-add.json");
String contents = FileUtils.readTextFile(indexPath);
- Map<String, String> configInEffect = new HashMap<>();
- configInEffect.put(clName, contents);
ConfigFileScanningTask cfst = new ConfigFileScanningTask(new ConfigFileScanner());
Whitebox.setInternalState(cfst, "configFile", indexPath);
- Whitebox.setInternalState(cfst, "configInEffect", configInEffect);
// mock for getExistingRules
JerseyClient jcMock = PowerMock.createMock(JerseyClient.class);
cfst.run();
PowerMock.verifyAll();
- Map<String, String> config = Whitebox.getInternalState(cfst, "configInEffect");
- assertThat(config.size(), is(1));
+ assertThat(systemOut.getLog(), containsString("Failed to delete rule, the rule id is: ControlLoop-VOLTE-2179b738-fd36-4843-a71a-a8c24c70c55b"));
}
@Test
String clName = "ControlLoop-VOLTE-2179b738-fd36-4843-a71a-a8c24c70c55b";
String oldDrlPath = getFilePath("ControlLoop-VOLTE-2179b738-fd36-4843-a71a-a8c24c70c55b.drl");
String oldDrlContents = FileUtils.readTextFile(oldDrlPath);
- Map<String, String> configInEffect = new HashMap<>();
- configInEffect.put(clName, oldDrlContents);
ConfigFileScanningTask cfst = new ConfigFileScanningTask(new ConfigFileScanner());
Whitebox.setInternalState(cfst, "configFile", getFilePath("index-rule-changed.json"));
- Whitebox.setInternalState(cfst, "configInEffect", configInEffect);
// mock for getExistingRules
JerseyClient jcMock = PowerMock.createMock(JerseyClient.class);
EasyMock.expect(jcMock.delete(EasyMock.anyString())).andReturn("");
// mock for deployRule
- EasyMock.expect(jcMock.header(EasyMock.anyString(), EasyMock.anyObject())).andReturn(jcMock);
+ EasyMock.expect(jcMock.header(EasyMock.anyString(), EasyMock.anyObject())).andReturn(jcMock).times(2);
EasyMock.expect(jcMock.put(EasyMock.anyString(), EasyMock.anyObject())).andReturn("");
PowerMock.replayAll();
cfst.run();
PowerMock.verifyAll();
- Map<String, String> config = Whitebox.getInternalState(cfst, "configInEffect");
- assertThat(config.size(), is(1));
- assertThat(config.get(clName),
- equalTo(FileUtils.readTextFile(
- getFilePath("ControlLoop-VOLTE-2179b738-fd36-4843-a71a-a8c24c70c55b-changed.drl"))));
+ assertThat(systemOut.getLog(), containsString("Rule 'ControlLoop-VOLTE-2179b738-fd36-4843-a71a-a8c24c70c55b' has been updated."));
}
@Test
String clName = "ControlLoop-VOLTE-2179b738-fd36-4843-a71a-a8c24c70c55b";
String oldDrlPath = getFilePath("ControlLoop-VOLTE-2179b738-fd36-4843-a71a-a8c24c70c55b.drl");
String oldDrlContents = FileUtils.readTextFile(oldDrlPath);
- Map<String, String> configInEffect = new HashMap<>();
- configInEffect.put(clName, oldDrlContents);
ConfigFileScanningTask cfst = new ConfigFileScanningTask(new ConfigFileScanner());
Whitebox.setInternalState(cfst, "configFile", getFilePath("index-rule-spaces-test.json"));
- Whitebox.setInternalState(cfst, "configInEffect", configInEffect);
// mock for getExistingRules
JerseyClient jcMock = PowerMock.createMock(JerseyClient.class);
cfst.run();
PowerMock.verifyAll();
- Map<String, String> config = Whitebox.getInternalState(cfst, "configInEffect");
- assertThat(config.size(), is(1));
- assertThat(config.get(clName),
- equalTo(FileUtils.readTextFile(
- getFilePath("ControlLoop-VOLTE-2179b738-fd36-4843-a71a-a8c24c70c55b.drl"))));
+ assertThat(systemOut.getLog(), not(containsString("has been updated.")));
}
private String getFilePath(String fileName) {
ruleResult4API.setContent(contents);
ruleResult4API.setDescription("");
ruleResult4API.setEnabled(1);
+ ruleResult4API.setCreator("__SYSTEM__DEFAULT__");
return ruleResult4API;
}
}
\ No newline at end of file