Removing attached entity from method argument

[portal.git] / portal-BE / src / main / java / org / onap / portal / service / AdminRolesService.java

diff --git a/portal-BE/src/main/java/org/onap/portal/service/AdminRolesService.java b/portal-BE/src/main/java/org/onap/portal/service/AdminRolesService.java
index 8049cd6..059979d 100644 (file)
--- a/portal-BE/src/main/java/org/onap/portal/service/AdminRolesService.java
+++ b/portal-BE/src/main/java/org/onap/portal/service/AdminRolesService.java
@@ -57,7 +57,6 @@ import java.util.Set;
 import java.util.SortedSet;
 import java.util.TreeSet;
 import java.util.stream.Collectors;
-import javax.annotation.PostConstruct;
 import javax.persistence.EntityManager;
 import javax.persistence.Query;
 import javax.persistence.Tuple;
@@ -96,15 +95,15 @@ import org.onap.portal.exception.DeleteDomainObjectFailedException;
 import org.onap.portal.exception.SyncUserRolesException;
 import org.onap.portal.logging.format.EPAppMessagesEnum;
 import org.onap.portal.logging.logic.EPLogUtil;
-import org.onap.portal.service.ep.EpAppFunctionService;
-import org.onap.portal.service.ep.EpUserRolesRequestDetService;
-import org.onap.portal.service.ep.EpUserRolesRequestService;
-import org.onap.portal.service.fn.FnAppService;
-import org.onap.portal.service.fn.FnMenuFunctionalRolesService;
-import org.onap.portal.service.fn.FnMenuFunctionalService;
-import org.onap.portal.service.fn.FnRoleService;
-import org.onap.portal.service.fn.FnUserRoleService;
-import org.onap.portal.service.fn.FnUserService;
+import org.onap.portal.service.appFunction.EpAppFunctionService;
+import org.onap.portal.service.userRolesRequestDet.EpUserRolesRequestDetService;
+import org.onap.portal.service.userRolesRequest.EpUserRolesRequestService;
+import org.onap.portal.service.app.FnAppService;
+import org.onap.portal.service.menuFunctionalRoles.FnMenuFunctionalRolesService;
+import org.onap.portal.service.menuFunctional.FnMenuFunctionalService;
+import org.onap.portal.service.role.FnRoleService;
+import org.onap.portal.service.userRole.FnUserRoleService;
+import org.onap.portal.service.user.FnUserService;
 import org.onap.portal.utils.EPCommonSystemProperties;
 import org.onap.portal.utils.EPUserUtils;
 import org.onap.portal.utils.EcompPortalUtils;
@@ -195,23 +194,21 @@ public class AdminRolesService {
     return isSuperAdmin;
   }
 
-  public boolean isAccountAdmin(FnUser user) {
+  public boolean isAccountAdmin(final long userId, final String orgUserId, final Set<FnUserRole> userApps) {
     try {
-      logger.debug(EELFLoggerDelegate.debugLogger, ADMIN_ACCOUNT, user.getId());
-      List<Integer> userAdminApps = getAdminAppsForTheUser(user.getId());
+      logger.debug(EELFLoggerDelegate.debugLogger, ADMIN_ACCOUNT, userId);
+      List<Integer> userAdminApps = getAdminAppsForTheUser(userId);
       logger.debug(EELFLoggerDelegate.debugLogger,
           "Is account admin for userAdminApps() - for user {}, found userAdminAppsSize {}",
-          user.getOrgUserId(), userAdminApps.size());
+          orgUserId, userAdminApps.size());
 
-      if (user.getId() != null) {
-        for (FnUserRole userApp : user.getUserApps()) {
-          if (userApp.getRoleId().getId().equals(ACCOUNT_ADMIN_ROLE_ID) || (
-              userAdminApps.size() > 1)) {
-            logger.debug(EELFLoggerDelegate.debugLogger,
-                "Is account admin for userAdminApps() - for user {}, found Id {}",
-                user.getOrgUserId(), userApp.getRoleId().getId());
-            return true;
-          }
+      for (FnUserRole userApp : userApps) {
+        if (userApp.getRoleId().getId().equals(ACCOUNT_ADMIN_ROLE_ID) || (
+            userAdminApps.size() > 1)) {
+          logger.debug(EELFLoggerDelegate.debugLogger,
+              "Is account admin for userAdminApps() - for user {}, found Id {}",
+              orgUserId, userApp.getRoleId().getId());
+          return true;
         }
       }
     } catch (Exception e) {
@@ -223,9 +220,9 @@ public class AdminRolesService {
     return false;
   }
 
-  boolean isUser(FnUser user) {
+  public boolean isUser(final long userId) {
     try {
-      FnUser currentUser = fnUserService.getUser(user.getId()).orElseThrow(Exception::new);
+      FnUser currentUser = fnUserService.getUser(userId).orElseThrow(Exception::new);
       if (currentUser != null && currentUser.getId() != null) {
         for (FnUserRole userApp : currentUser.getUserApps()) {
           if (!userApp.getFnAppId().getId().equals(ECOMP_APP_ID)) {