update version of checkstyle for latest google style and jdk 8

[oparent.git] / oparent / pom.xml

diff --git a/oparent/pom.xml b/oparent/pom.xml
index bfb730a..6fc37e3 100644 (file)
--- a/oparent/pom.xml
+++ b/oparent/pom.xml
@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--
    Copyright (c) 2016-2017 Huawei Technologies Co., Ltd.
+   Modifications copyright (C) 2019 AT&T Intellectual Property
 
    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.
@@ -19,7 +20,7 @@
   <parent>
     <groupId>org.onap.oparent</groupId>
     <artifactId>version</artifactId>
-    <version>2.0.1-SNAPSHOT</version>
+    <version>3.0.0-SNAPSHOT</version>
     <relativePath>..</relativePath>
   </parent>
   <artifactId>oparent</artifactId>
@@ -272,13 +273,67 @@
         </dependency>
       </dependencies>
     </profile>
+    <profile>
+      <activation>
+        <jdk>[1.8,)</jdk>
+      </activation>
+      <!-- overrides oparent's existing checkstyle to check java 8 code -->
+      <id>checkstyle-jdk8</id>
+      <build>
+        <plugins>
+          <plugin>
+            <!--
+              - override the original oparent checkstyle configuration to
+              - use a later version of checkstyle which is jdk8 aware, and
+              - use an updated checkstyle config that conforms to onap style and the later checkstyle format.
+              -->
+            <artifactId>maven-checkstyle-plugin</artifactId>
+            <version>3.1.0</version>
+            <dependencies>
+              <dependency>
+                <!-- because google's latest style is not supported by plugin's default  version-->
+                <groupId>com.puppycrawl.tools</groupId>
+                <artifactId>checkstyle</artifactId>
+                <version>8.24</version>
+              </dependency>
+            </dependencies>
+            <executions>
+              <execution>
+                <id>onap-license</id>
+                <configuration>
+                  <!-- this config not supported by checkstyle any more -->
+                  <sourceDirectory combine.self="override"/>
+                  <sourceDirectories>
+                    <sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
+                  </sourceDirectories>
+                </configuration>
+              </execution>
+              <execution>
+                <id>onap-java-style</id>
+                <configuration>
+                  <!-- Use Google Java Style Guide:
+                     https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml
+                     with minor changes -->
+                  <configLocation>onap-checkstyle/onap-java-style${maven.compiler.source}.xml</configLocation>
+                  <!-- this config not supported by checkstyle any more -->
+                  <sourceDirectory combine.self="override"/>
+                  <sourceDirectories>
+                    <sourceDirectory>${project.build.sourceDirectory}</sourceDirectory>
+                  </sourceDirectories>
+                </configuration>
+              </execution>
+            </executions>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
   </profiles>
   <dependencyManagement>
     <dependencies>
       <dependency>
         <groupId>org.onap.oparent</groupId>
         <artifactId>dependencies</artifactId>
-        <version>2.0.1-SNAPSHOT</version>
+        <version>3.0.0-SNAPSHOT</version>
         <type>pom</type>
         <scope>import</scope>
       </dependency>
@@ -424,7 +479,7 @@
           <dependency>
             <groupId>org.onap.oparent</groupId>
             <artifactId>checkstyle</artifactId>
-            <version>2.0.1-SNAPSHOT</version>
+            <version>3.0.0-SNAPSHOT</version>
           </dependency>
         </dependencies>
         <executions>