fixed sonar issues in SwaggerGenerator.java

[ccsdk/apps.git] / ms / controllerblueprints / modules / service / src / main / java / org / onap / ccsdk / apps / controllerblueprints / service / common / SwaggerGenerator.java

diff --git a/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/common/SwaggerGenerator.java b/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/common/SwaggerGenerator.java
index 81f7d70..77de8e7 100644 (file)
--- a/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/common/SwaggerGenerator.java
+++ b/ms/controllerblueprints/modules/service/src/main/java/org/onap/ccsdk/apps/controllerblueprints/service/common/SwaggerGenerator.java
@@ -1,5 +1,6 @@
 /*\r
  *  Copyright © 2017-2018 AT&T Intellectual Property.\r
+ *  Modifications Copyright © 2018 IBM.\r
  *\r
  *  Licensed under the Apache License, Version 2.0 (the "License");\r
  *  you may not use this file except in compliance with the License.\r
@@ -40,6 +41,7 @@ import java.util.*;
 public class SwaggerGenerator {\r
 \r
     private ServiceTemplate serviceTemplate;\r
+    public static final String INPUTS="inputs";\r
 \r
     /**\r
      * This is a SwaggerGenerator constructor\r
@@ -54,8 +56,7 @@ public class SwaggerGenerator {
      * @return String\r
      */\r
     public String generateSwagger() {\r
-        String swaggerContent = null;\r
-\r
+        \r
         Swagger swagger = new Swagger().info(getInfo());\r
 \r
         swagger.setPaths(getPaths());\r
@@ -86,7 +87,7 @@ public class SwaggerGenerator {
         List<Parameter> parameters = new ArrayList<>();\r
         Parameter in = new BodyParameter().schema(new RefModel("#/definitions/inputs"));\r
         in.setRequired(true);\r
-        in.setName("inputs");\r
+        in.setName(INPUTS);\r
         parameters.add(in);\r
         post.setParameters(parameters);\r
 \r
@@ -107,18 +108,17 @@ public class SwaggerGenerator {
         Map<String, Model> models = new HashMap<>();\r
 \r
         ModelImpl inputmodel = new ModelImpl();\r
-        inputmodel.setTitle("inputs");\r
+        inputmodel.setTitle(INPUTS);\r
         serviceTemplate.getTopologyTemplate().getInputs().forEach((propertyName, property) -> {\r
             Property defProperty = getPropery(propertyName, property);\r
             inputmodel.property(propertyName, defProperty);\r
         });\r
-        models.put("inputs", inputmodel);\r
+        models.put(INPUTS, inputmodel);\r
 \r
         if (MapUtils.isNotEmpty(serviceTemplate.getDataTypes())) {\r
             serviceTemplate.getDataTypes().forEach((name, dataType) -> {\r
                 ModelImpl model = new ModelImpl();\r
                 model.setDescription(dataType.getDescription());\r
-                // model.setType("object");\r
                 if (dataType != null && MapUtils.isNotEmpty(dataType.getProperties())) {\r
 \r
                     dataType.getProperties().forEach((propertyName, property) -> {\r