/*-
* ============LICENSE_START=======================================================
- * Copyright (C) 2019 Nordix Foundation.
+ * Copyright (C) 2019-2021 Nordix Foundation.
+ * Modifications Copyright (C) 2019-2020 AT&T Intellectual Property. All rights reserved.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
package org.onap.policy.models.tosca.simple.concepts;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
import org.junit.Test;
import org.onap.policy.models.base.PfConceptKey;
import org.onap.policy.models.base.PfReferenceKey;
-import org.onap.policy.models.base.PfValidationResult;
-import org.onap.policy.models.tosca.simple.concepts.JpaToscaEventFilter;
/**
* DAO test for ToscaEventFilter.
*/
public class JpaToscaEventFilterTest {
+ private static final String KEY_IS_NULL = "key is marked .*on.*ull but is null";
+ private static final String A_REQUREMENT = "A Requrement";
+ private static final String A_CAPABILITY = "A Capability";
+ private static final String VERSION_001 = "0.0.1";
+
@Test
public void testEventFilterPojo() {
assertNotNull(new JpaToscaEventFilter());
assertNotNull(new JpaToscaEventFilter(new PfReferenceKey(), new PfConceptKey()));
assertNotNull(new JpaToscaEventFilter(new JpaToscaEventFilter()));
- try {
- new JpaToscaEventFilter((PfReferenceKey) null);
- fail("test should throw an exception");
- } catch (Exception exc) {
- assertEquals("key is marked @NonNull but is null", exc.getMessage());
- }
-
- try {
- new JpaToscaEventFilter(null, null);
- fail("test should throw an exception");
- } catch (Exception exc) {
- assertEquals("key is marked @NonNull but is null", exc.getMessage());
- }
-
- try {
- new JpaToscaEventFilter(null, new PfConceptKey());
- fail("test should throw an exception");
- } catch (Exception exc) {
- assertEquals("key is marked @NonNull but is null", exc.getMessage());
- }
-
- try {
- new JpaToscaEventFilter(new PfReferenceKey(), null);
- fail("test should throw an exception");
- } catch (Exception exc) {
- assertEquals("node is marked @NonNull but is null", exc.getMessage());
- }
-
- try {
- new JpaToscaEventFilter((JpaToscaEventFilter) null);
- fail("test should throw an exception");
- } catch (Exception exc) {
- assertEquals("copyConcept is marked @NonNull but is null", exc.getMessage());
- }
-
- PfConceptKey efParentKey = new PfConceptKey("tParentKey", "0.0.1");
+ assertThatThrownBy(() -> new JpaToscaEventFilter((PfReferenceKey) null)).hasMessageMatching(KEY_IS_NULL);
+
+ assertThatThrownBy(() -> new JpaToscaEventFilter(null, null)).hasMessageMatching(KEY_IS_NULL);
+
+ assertThatThrownBy(() -> new JpaToscaEventFilter(null, new PfConceptKey())).hasMessageMatching(KEY_IS_NULL);
+
+ assertThatThrownBy(() -> new JpaToscaEventFilter(new PfReferenceKey(), null))
+ .hasMessageMatching("node is marked .*on.*ull but is null");
+
+ assertThatThrownBy(() -> new JpaToscaEventFilter((JpaToscaEventFilter) null))
+ .isInstanceOf(NullPointerException.class);
+ }
+
+ @Test
+ public void testEventFilter() {
+ PfConceptKey efParentKey = new PfConceptKey("tParentKey", VERSION_001);
PfReferenceKey efKey = new PfReferenceKey(efParentKey, "trigger0");
- PfConceptKey nodeKey = new PfConceptKey("tParentKey", "0.0.1");
+ PfConceptKey nodeKey = new PfConceptKey("tParentKey", VERSION_001);
JpaToscaEventFilter tef = new JpaToscaEventFilter(efKey, nodeKey);
- tef.setRequirement("A Requrement");
- assertEquals("A Requrement", tef.getRequirement());
+ tef.setRequirement(A_REQUREMENT);
+ assertEquals(A_REQUREMENT, tef.getRequirement());
- tef.setCapability("A Capability");
- assertEquals("A Capability", tef.getCapability());
+ tef.setCapability(A_CAPABILITY);
+ assertEquals(A_CAPABILITY, tef.getCapability());
JpaToscaEventFilter tdtClone0 = new JpaToscaEventFilter(tef);
- assertEquals(tef, tdtClone0);
- assertEquals(0, tef.compareTo(tdtClone0));
+ checkEqualsEventFilter(tef, tdtClone0);
- JpaToscaEventFilter tdtClone1 = new JpaToscaEventFilter();
- tef.copyTo(tdtClone1);
- assertEquals(tef, tdtClone1);
- assertEquals(0, tef.compareTo(tdtClone1));
+ JpaToscaEventFilter tdtClone1 = new JpaToscaEventFilter(tef);
+ checkEqualsEventFilter(tef, tdtClone1);
assertEquals(-1, tef.compareTo(null));
assertEquals(0, tef.compareTo(tef));
- assertFalse(tef.compareTo(tef.getKey()) == 0);
+ assertNotEquals(0, tef.compareTo(tef.getKey()));
- PfReferenceKey otherDtKey = new PfReferenceKey("otherDt", "0.0.1", "OtherEventFilter");
+ PfReferenceKey otherDtKey = new PfReferenceKey("otherDt", VERSION_001, "OtherEventFilter");
JpaToscaEventFilter otherDt = new JpaToscaEventFilter(otherDtKey);
- assertFalse(tef.compareTo(otherDt) == 0);
+ assertNotEquals(0, tef.compareTo(otherDt));
otherDt.setKey(efKey);
- assertFalse(tef.compareTo(otherDt) == 0);
+ assertNotEquals(0, tef.compareTo(otherDt));
otherDt.setNode(nodeKey);
- assertFalse(tef.compareTo(otherDt) == 0);
- otherDt.setRequirement("A Requrement");
- assertFalse(tef.compareTo(otherDt) == 0);
- otherDt.setCapability("A Capability");
+ assertNotEquals(0, tef.compareTo(otherDt));
+ otherDt.setRequirement(A_REQUREMENT);
+ assertNotEquals(0, tef.compareTo(otherDt));
+ otherDt.setCapability(A_CAPABILITY);
assertEquals(0, tef.compareTo(otherDt));
- try {
- tef.copyTo(null);
- fail("test should throw an exception");
- } catch (Exception exc) {
- assertEquals("target is marked @NonNull but is null", exc.getMessage());
- }
-
assertEquals(2, tef.getKeys().size());
assertEquals(2, new JpaToscaEventFilter().getKeys().size());
+ }
+
+ private void checkEqualsEventFilter(JpaToscaEventFilter tef1, JpaToscaEventFilter tef2) {
+ assertEquals(tef1, tef2);
+ assertEquals(0, tef1.compareTo(tef2));
+ }
+
+ @Test
+ public void testValidationEventFilter() {
+ PfConceptKey efParentKey = new PfConceptKey("tParentKey", VERSION_001);
+ PfReferenceKey efKey = new PfReferenceKey(efParentKey, "trigger0");
+ PfConceptKey nodeKey = new PfConceptKey("tParentKey", VERSION_001);
+ JpaToscaEventFilter tef = new JpaToscaEventFilter(efKey, nodeKey);
+
+ JpaToscaEventFilter tdtClone0 = new JpaToscaEventFilter(tef);
new JpaToscaEventFilter().clean();
tef.clean();
assertEquals(tdtClone0, tef);
- assertFalse(new JpaToscaEventFilter().validate(new PfValidationResult()).isValid());
- assertTrue(tef.validate(new PfValidationResult()).isValid());
+ assertFalse(new JpaToscaEventFilter().validate("").isValid());
+ assertTrue(tef.validate("").isValid());
tef.setRequirement(null);
- assertTrue(tef.validate(new PfValidationResult()).isValid());
+ assertTrue(tef.validate("").isValid());
tef.setRequirement("");
- assertFalse(tef.validate(new PfValidationResult()).isValid());
- tef.setRequirement("A Requrement");
- assertTrue(tef.validate(new PfValidationResult()).isValid());
+ assertFalse(tef.validate("").isValid());
+ tef.setRequirement(A_REQUREMENT);
+ assertTrue(tef.validate("").isValid());
tef.setCapability(null);
- assertTrue(tef.validate(new PfValidationResult()).isValid());
+ assertTrue(tef.validate("").isValid());
tef.setCapability("");
- assertFalse(tef.validate(new PfValidationResult()).isValid());
- tef.setCapability("A Capability");
- assertTrue(tef.validate(new PfValidationResult()).isValid());
+ assertFalse(tef.validate("").isValid());
+ tef.setCapability(A_CAPABILITY);
+ assertTrue(tef.validate("").isValid());
tef.setNode(null);
- assertFalse(tef.validate(new PfValidationResult()).isValid());
+ assertFalse(tef.validate("").isValid());
tef.setNode(PfConceptKey.getNullKey());
- assertFalse(tef.validate(new PfValidationResult()).isValid());
+ assertFalse(tef.validate("").isValid());
tef.setNode(nodeKey);
- assertTrue(tef.validate(new PfValidationResult()).isValid());
-
- try {
- tef.validate(null);
- fail("test should throw an exception");
- } catch (Exception exc) {
- assertEquals("resultIn is marked @NonNull but is null", exc.getMessage());
- }
+ assertTrue(tef.validate("").isValid());
+
+ assertThatThrownBy(() -> tef.validate(null)).hasMessageMatching("fieldName is marked .*on.*ull but is null");
}
}