More sonar fixes in models

[policy/models.git] / models-interactions / model-simulators / src / main / java / org / onap / policy / simulators / SdncSimulatorJaxRs.java

diff --git a/models-interactions/model-simulators/src/main/java/org/onap/policy/simulators/SdncSimulatorJaxRs.java b/models-interactions/model-simulators/src/main/java/org/onap/policy/simulators/SdncSimulatorJaxRs.java
index 0492c4e..b6e8b04 100644 (file)
--- a/models-interactions/model-simulators/src/main/java/org/onap/policy/simulators/SdncSimulatorJaxRs.java
+++ b/models-interactions/model-simulators/src/main/java/org/onap/policy/simulators/SdncSimulatorJaxRs.java
@@ -4,7 +4,7 @@
  * ================================================================================
  * Copyright (C) 2018 Huawei. All rights reserved.
  * Modifications Copyright (C) 2019 Nordix Foundation.
- * Modifications Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
+ * Modifications Copyright (C) 2019-2020 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -46,14 +46,7 @@ public class SdncSimulatorJaxRs {
     @Consumes(MediaType.APPLICATION_JSON)
     @Produces("application/json")
     public String sdncPostQuery() {
-        final SdncResponse response = new SdncResponse();
-        response.setRequestId(UUID.randomUUID().toString());
-        SdncResponseOutput responseOutput = new SdncResponseOutput();
-        responseOutput.setResponseCode("200");
-        responseOutput.setAckFinalIndicator("Y");
-        responseOutput.setSvcRequestId(UUID.randomUUID().toString());
-        response.setResponseOutput(responseOutput);
-        return Serialization.gsonPretty.toJson(response);
+        return makeSuccessResponse();
     }
 
 
@@ -67,6 +60,11 @@ public class SdncSimulatorJaxRs {
     @Consumes(MediaType.APPLICATION_JSON)
     @Produces("application/json")
     public String sdncVnfTopologyOperation() {
+        return makeSuccessResponse();
+    }
+
+
+    private String makeSuccessResponse() {
         final SdncResponse response = new SdncResponse();
         response.setRequestId(UUID.randomUUID().toString());
         SdncResponseOutput responseOutput = new SdncResponseOutput();