package org.onap.policy.controlloop.actor.cds;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
+import java.util.Collections;
import java.util.HashMap;
+import java.util.List;
import java.util.Map;
import java.util.UUID;
import java.util.concurrent.CompletableFuture;
import org.mockito.Mock;
import org.mockito.MockitoAnnotations;
import org.onap.aai.domain.yang.GenericVnf;
+import org.onap.aai.domain.yang.Pnf;
import org.onap.aai.domain.yang.ServiceInstance;
import org.onap.ccsdk.cds.controllerblueprints.processing.api.ExecutionServiceInput;
import org.onap.ccsdk.cds.controllerblueprints.processing.api.ExecutionServiceOutput;
import org.onap.policy.controlloop.actor.cds.constants.CdsActorConstants;
import org.onap.policy.controlloop.actorserviceprovider.ActorService;
import org.onap.policy.controlloop.actorserviceprovider.OperationOutcome;
+import org.onap.policy.controlloop.actorserviceprovider.OperationProperties;
import org.onap.policy.controlloop.actorserviceprovider.controlloop.ControlLoopEventContext;
import org.onap.policy.controlloop.actorserviceprovider.parameters.ControlLoopOperationParams;
import org.onap.policy.controlloop.policy.PolicyResult;
@Mock
private CdsProcessorGrpcClient cdsClient;
+ @Mock
+ private ControlLoopEventContext context;
private CdsServerProperties cdsProps;
private VirtualControlLoopEvent onset;
private PseudoExecutor executor;
private Target target;
+ private ControlLoopOperationParams params;
+ private GrpcConfig config;
+ private CompletableFuture<OperationOutcome> cqFuture;
private GrpcOperation operation;
@BeforeClass
target = new Target();
target.setType(TargetType.VM);
target.setResourceID(RESOURCE_ID);
+
+ cqFuture = new CompletableFuture<>();
+ when(context.obtain(eq(AaiCqResponse.CONTEXT_KEY), any())).thenReturn(cqFuture);
+ when(context.getEvent()).thenReturn(onset);
+
+ params = ControlLoopOperationParams.builder().actor(CdsActorConstants.CDS_ACTOR)
+ .operation(GrpcOperation.NAME).context(context).actorService(new ActorService())
+ .targetEntity(TARGET_ENTITY).target(target).build();
}
/**
Map<String, Object> payload = Map.of("artifact_name", "my_artifact", "artifact_version", "1.0");
- final ControlLoopOperationParams params = ControlLoopOperationParams.builder()
+ params = ControlLoopOperationParams.builder()
.actor(CdsActorConstants.CDS_ACTOR).operation("subscribe").context(context)
.actorService(new ActorService()).targetEntity(TARGET_ENTITY).target(target).retry(0)
.timeoutSec(5).executor(blockingExecutor).payload(payload).build();
assertTrue(outcome.getResponse() instanceof ExecutionServiceOutput);
}
+ /**
+ * Tests "success" case with simulator using properties.
+ */
@Test
- public void testStartPreprocessorAsync() throws InterruptedException, ExecutionException, TimeoutException {
+ public void testSuccessViaProperties() throws Exception {
+ ControlLoopEventContext context = new ControlLoopEventContext(onset);
+ loadCqData(context);
- CompletableFuture<OperationOutcome> future2 = new CompletableFuture<>();
- ControlLoopEventContext context = mock(ControlLoopEventContext.class);
- when(context.obtain(eq(AaiCqResponse.CONTEXT_KEY), any())).thenReturn(future2);
- when(context.getEvent()).thenReturn(onset);
+ Map<String, Object> payload = Map.of("artifact_name", "my_artifact", "artifact_version", "1.0");
- AtomicBoolean guardStarted = new AtomicBoolean();
+ params = ControlLoopOperationParams.builder()
+ .actor(CdsActorConstants.CDS_ACTOR).operation("subscribe").context(context)
+ .actorService(new ActorService()).targetEntity(TARGET_ENTITY).target(target).retry(0)
+ .timeoutSec(5).executor(blockingExecutor).payload(payload).preprocessed(true).build();
- ControlLoopOperationParams params = ControlLoopOperationParams.builder().actor(CdsActorConstants.CDS_ACTOR)
- .operation(GrpcOperation.NAME).context(context).actorService(new ActorService())
- .targetEntity(TARGET_ENTITY).target(target).build();
- GrpcConfig config = new GrpcConfig(executor, cdsProps);
+ cdsProps.setHost("localhost");
+ cdsProps.setPort(sim.getPort());
+ cdsProps.setTimeout(3);
+
+ GrpcConfig config = new GrpcConfig(blockingExecutor, cdsProps);
+
+ operation = new GrpcOperation(params, config);
+
+ // set the properties
+ operation.setProperty(OperationProperties.OPT_CDS_GRPC_AAI_PROPERTIES, Collections.emptyMap());
+
+ OperationOutcome outcome = operation.start().get();
+ assertEquals(PolicyResult.SUCCESS, outcome.getResult());
+ assertTrue(outcome.getResponse() instanceof ExecutionServiceOutput);
+ }
+
+ @Test
+ public void testGetPropertyNames() {
+
+ /*
+ * check VNF case
+ */
+ operation = new GrpcOperation(params, config);
+
+ // @formatter:off
+ assertThat(operation.getPropertyNames()).isEqualTo(
+ List.of(
+ OperationProperties.AAI_RESOURCE_VNF,
+ OperationProperties.AAI_SERVICE,
+ OperationProperties.EVENT_ADDITIONAL_PARAMS,
+ OperationProperties.OPT_CDS_GRPC_AAI_PROPERTIES));
+ // @formatter:on
+
+ /*
+ * check PNF case
+ */
+ target.setType(TargetType.PNF);
+ operation = new GrpcOperation(params, config);
+
+ // @formatter:off
+ assertThat(operation.getPropertyNames()).isEqualTo(
+ List.of(
+ OperationProperties.AAI_PNF,
+ OperationProperties.EVENT_ADDITIONAL_PARAMS,
+ OperationProperties.OPT_CDS_GRPC_AAI_PROPERTIES));
+ // @formatter:on
+ }
+
+ @Test
+ public void testGetPnf() {
+ ControlLoopEventContext context = new ControlLoopEventContext(onset);
+ params = params.toBuilder().context(context).build();
+ operation = new GrpcOperation(params, config);
+
+ // in neither property nor context
+ assertThatIllegalArgumentException().isThrownBy(() -> operation.getPnfData())
+ .withMessage("missing PNF data");
+
+ // only in context
+ Pnf pnf = new Pnf();
+ params.getContext().setProperty(AaiGetPnfOperation.getKey(params.getTargetEntity()), pnf);
+ assertSame(pnf, operation.getPnfData());
+
+ // both - should choose the property
+ Pnf pnf2 = new Pnf();
+ operation.setProperty(OperationProperties.AAI_PNF, pnf2);
+ assertSame(pnf2, operation.getPnfData());
+ }
+
+ @Test
+ public void testGetServiceInstanceId() {
+ ControlLoopEventContext context = new ControlLoopEventContext(onset);
+ params = params.toBuilder().context(context).build();
+ operation = new GrpcOperation(params, config);
+
+ // in neither property nor custom query
+ context.setProperty(AaiCqResponse.CONTEXT_KEY, mock(AaiCqResponse.class));
+ assertThatIllegalArgumentException().isThrownBy(() -> operation.getServiceInstanceId())
+ .withMessage("Target service instance could not be found");
+
+ // only in custom query
+ loadCqData(params.getContext());
+ assertEquals(MY_SVC_ID, operation.getServiceInstanceId());
+
+ // both - should choose the property
+ ServiceInstance serviceInstance = new ServiceInstance();
+ serviceInstance.setServiceInstanceId("another-service-id");
+ operation.setProperty(OperationProperties.AAI_SERVICE, serviceInstance);
+ assertEquals("another-service-id", operation.getServiceInstanceId());
+ }
+
+ @Test
+ public void testGetVnfId() {
+ ControlLoopEventContext context = new ControlLoopEventContext(onset);
+ params = params.toBuilder().context(context).build();
+ operation = new GrpcOperation(params, config);
+
+ // in neither property nor custom query
+ context.setProperty(AaiCqResponse.CONTEXT_KEY, mock(AaiCqResponse.class));
+ assertThatIllegalArgumentException().isThrownBy(() -> operation.getVnfId())
+ .withMessage("Target generic vnf could not be found");
+
+ // only in custom query
+ loadCqData(params.getContext());
+ assertEquals(MY_VNF, operation.getVnfId());
+
+ // both - should choose the property
+ GenericVnf vnf = new GenericVnf();
+ vnf.setVnfId("another-vnf-id");
+ operation.setProperty(OperationProperties.AAI_RESOURCE_VNF, vnf);
+ assertEquals("another-vnf-id", operation.getVnfId());
+ }
+
+ @Test
+ public void testStartPreprocessorAsync() throws InterruptedException, ExecutionException, TimeoutException {
+ AtomicBoolean guardStarted = new AtomicBoolean();
operation = new GrpcOperation(params, config) {
@Override
protected CompletableFuture<OperationOutcome> startGuardAsync() {
guardStarted.set(true);
- return future2;
+ return cqFuture;
}
};
assertTrue(guardStarted.get());
verify(context).obtain(eq(AaiCqResponse.CONTEXT_KEY), any());
- future2.complete(params.makeOutcome());
+ cqFuture.complete(params.makeOutcome());
assertTrue(executor.runAll(100));
assertEquals(PolicyResult.SUCCESS, future3.get(2, TimeUnit.SECONDS).getResult());
assertTrue(future3.isDone());
*/
@Test
public void testStartPreprocessorAsyncPnf() throws InterruptedException, ExecutionException, TimeoutException {
-
- CompletableFuture<OperationOutcome> future2 = new CompletableFuture<>();
- ControlLoopEventContext context = mock(ControlLoopEventContext.class);
- when(context.obtain(eq(AaiCqResponse.CONTEXT_KEY), any())).thenReturn(future2);
- when(context.getEvent()).thenReturn(onset);
-
AtomicBoolean guardStarted = new AtomicBoolean();
target.setType(TargetType.PNF);
- ControlLoopOperationParams params = ControlLoopOperationParams.builder().actor(CdsActorConstants.CDS_ACTOR)
- .operation(GrpcOperation.NAME).context(context).actorService(new ActorService())
- .targetEntity(TARGET_ENTITY).target(target).build();
- GrpcConfig config = new GrpcConfig(executor, cdsProps);
-
operation = new GrpcOperation(params, config) {
@Override
protected CompletableFuture<OperationOutcome> startGuardAsync() {
guardStarted.set(true);
- return future2;
+ return cqFuture;
}
};
assertTrue(guardStarted.get());
verify(context).obtain(eq(AaiGetPnfOperation.getKey(TARGET_ENTITY)), any());
- future2.complete(params.makeOutcome());
+ cqFuture.complete(params.makeOutcome());
assertTrue(executor.runAll(100));
assertEquals(PolicyResult.SUCCESS, future3.get(2, TimeUnit.SECONDS).getResult());
assertTrue(future3.isDone());
}
+ /**
+ * Tests startPreprocessorAsync(), when preprocessing is disabled.
+ */
+ @Test
+ public void testStartPreprocessorAsyncDisabled() {
+ params = params.toBuilder().preprocessed(true).build();
+ assertNull(new GrpcOperation(params, config).startPreprocessorAsync());
+ }
+
@Test
public void testStartOperationAsync() throws Exception {
@Test
public void testStartOperationAsyncError() throws Exception {
-
- ControlLoopEventContext context = new ControlLoopEventContext(onset);
- ControlLoopOperationParams params = ControlLoopOperationParams.builder().actor(CdsActorConstants.CDS_ACTOR)
- .operation(GrpcOperation.NAME).context(context).actorService(new ActorService())
- .targetEntity(TARGET_ENTITY).target(target).build();
-
- GrpcConfig config = new GrpcConfig(executor, cdsProps);
operation = new GrpcOperation(params, config);
assertThatIllegalArgumentException().isThrownBy(() -> operation.startOperationAsync(1, params.makeOutcome()));
}
+ @Test
+ public void testGetAdditionalEventParams() {
+ operation = new GrpcOperation(params, config);
+
+ // in neither property nor context
+ assertNull(operation.getAdditionalEventParams());
+
+ final Map<String, String> eventParams = Collections.emptyMap();
+
+ // only in context
+ onset.setAdditionalEventParams(eventParams);
+ assertSame(eventParams, operation.getAdditionalEventParams());
+
+ // both - should choose the property, even if it's null
+ operation.setProperty(OperationProperties.EVENT_ADDITIONAL_PARAMS, null);
+ assertNull(operation.getAdditionalEventParams());
+
+ // both - should choose the property
+ final Map<String, String> propParams = Collections.emptyMap();
+ operation.setProperty(OperationProperties.EVENT_ADDITIONAL_PARAMS, propParams);
+ assertSame(propParams, operation.getAdditionalEventParams());
+ }
+
private void verifyOperation(ControlLoopEventContext context) {
Map<String, Object> payloadMap = Map.of(CdsActorConstants.KEY_CBA_NAME, CDS_BLUEPRINT_NAME,
Code Review / policy / models.git / blobdiff