Clean up minor checkstyle/sonar issues

[policy/models.git] / models-interactions / model-actors / actor.cds / src / test / java / org / onap / policy / controlloop / actor / cds / CdsActorServiceProviderTest.java

diff --git a/models-interactions/model-actors/actor.cds/src/test/java/org/onap/policy/controlloop/actor/cds/CdsActorServiceProviderTest.java b/models-interactions/model-actors/actor.cds/src/test/java/org/onap/policy/controlloop/actor/cds/CdsActorServiceProviderTest.java
index 28a1676..f260343 100644 (file)
--- a/models-interactions/model-actors/actor.cds/src/test/java/org/onap/policy/controlloop/actor/cds/CdsActorServiceProviderTest.java
+++ b/models-interactions/model-actors/actor.cds/src/test/java/org/onap/policy/controlloop/actor/cds/CdsActorServiceProviderTest.java
@@ -1,6 +1,7 @@
 /*-
  * ============LICENSE_START=======================================================
  * Copyright (C) 2019 Bell Canada. All rights reserved.
+ * Modifications Copyright (C) 2020 Nordix Foundation.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -31,16 +32,16 @@ import static org.mockito.Mockito.when;
 
 import com.google.common.collect.ImmutableMap;
 import com.google.protobuf.Struct;
+
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Optional;
 import java.util.UUID;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
+
 import org.junit.Before;
-import org.junit.Rule;
 import org.junit.Test;
-import org.junit.rules.ExpectedException;
 import org.junit.runner.RunWith;
 import org.mockito.Mock;
 import org.mockito.runners.MockitoJUnitRunner;
@@ -68,8 +69,6 @@ public class CdsActorServiceProviderTest {
     private static final String SUBREQUEST_ID = "123456";
     private static final String CDS_RECIPE = "test-cds-recipe";
 
-    @Rule
-    public ExpectedException exceptionRule = ExpectedException.none();
     @Mock
     private CdsProcessorGrpcClient cdsClient;
     private CdsActorServiceProvider cdsActor;
@@ -87,6 +86,8 @@ public class CdsActorServiceProviderTest {
         // Setup policy
         policy = new Policy();
         Map<String, String> payloadMap = new HashMap<String, String>() {
+            private static final long serialVersionUID = 1L;
+
             {
                 put(CdsActorConstants.KEY_CBA_NAME, CDS_BLUEPRINT_NAME);
                 put(CdsActorConstants.KEY_CBA_VERSION, CDS_BLUEPRINT_VERSION);
@@ -124,22 +125,20 @@ public class CdsActorServiceProviderTest {
 
     @Test
     public void testActor() {
-        assertEquals(cdsActor.actor(), CdsActorConstants.CDS_ACTOR);
+        assertEquals(CdsActorConstants.CDS_ACTOR, cdsActor.actor());
     }
 
     @Test
     public void testConstructRequestWhenMissingCdsParamsInPolicyPayload() {
         policy.setPayload(new HashMap<>());
-        Optional<ExecutionServiceInput> cdsRequestOpt = cdsActor
-            .constructRequest(onset, operation, policy, aaiParams);
+        Optional<ExecutionServiceInput> cdsRequestOpt = cdsActor.constructRequest(onset, operation, policy, aaiParams);
 
         assertFalse(cdsRequestOpt.isPresent());
     }
 
     @Test
     public void testConstructRequest() {
-        Optional<ExecutionServiceInput> cdsRequestOpt = cdsActor
-            .constructRequest(onset, operation, policy, aaiParams);
+        Optional<ExecutionServiceInput> cdsRequestOpt = cdsActor.constructRequest(onset, operation, policy, aaiParams);
 
         assertTrue(cdsRequestOpt.isPresent());
         final ExecutionServiceInput cdsRequest = cdsRequestOpt.get();
@@ -147,7 +146,7 @@ public class CdsActorServiceProviderTest {
         assertTrue(cdsRequest.hasCommonHeader());
         CommonHeader commonHeader = cdsRequest.getCommonHeader();
         assertEquals(commonHeader.getRequestId(), REQUEST_ID.toString());
-        assertEquals(commonHeader.getSubRequestId(), SUBREQUEST_ID);
+        assertEquals(SUBREQUEST_ID, commonHeader.getSubRequestId());
 
         assertTrue(cdsRequest.hasPayload());
         Struct cdsPayload = cdsRequest.getPayload();
@@ -155,24 +154,24 @@ public class CdsActorServiceProviderTest {
 
         assertTrue(cdsRequest.hasActionIdentifiers());
         ActionIdentifiers actionIdentifiers = cdsRequest.getActionIdentifiers();
-        assertEquals(actionIdentifiers.getActionName(), CDS_RECIPE);
-        assertEquals(actionIdentifiers.getBlueprintName(), CDS_BLUEPRINT_NAME);
-        assertEquals(actionIdentifiers.getBlueprintVersion(), CDS_BLUEPRINT_VERSION);
+        assertEquals(CDS_RECIPE, actionIdentifiers.getActionName());
+        assertEquals(CDS_BLUEPRINT_NAME, actionIdentifiers.getBlueprintName());
+        assertEquals(CDS_BLUEPRINT_VERSION, actionIdentifiers.getBlueprintVersion());
     }
 
     @Test
     public void testRecipePayloads() {
-        assertEquals(cdsActor.recipePayloads("").size(), 0);
+        assertEquals(0, cdsActor.recipePayloads("").size());
     }
 
     @Test
     public void testRecipes() {
-        assertEquals(cdsActor.recipes().size(), 0);
+        assertEquals(0, cdsActor.recipes().size());
     }
 
     @Test
     public void testRecipeTargets() {
-        assertEquals(cdsActor.recipeTargets("").size(), 0);
+        assertEquals(0, cdsActor.recipeTargets("").size());
     }
 
     @Test
@@ -185,13 +184,13 @@ public class CdsActorServiceProviderTest {
     public void testSendRequestToCdsLatchInterrupted() throws InterruptedException {
         // Reset cdsClient
         CountDownLatch countDownLatch = mock(CountDownLatch.class);
-        doThrow(new InterruptedException("Test latch interrupted failure")).when(countDownLatch)
-            .await(anyLong(), any(TimeUnit.class));
+        doThrow(new InterruptedException("Test latch interrupted failure")).when(countDownLatch).await(anyLong(),
+            any(TimeUnit.class));
         when(cdsClient.sendRequest(any(ExecutionServiceInput.class))).thenReturn(countDownLatch);
 
         CdsActorServiceProvider.CdsActorServiceManager cdsActorSvcMgr = cdsActor.new CdsActorServiceManager();
-        CdsResponse response = cdsActorSvcMgr
-            .sendRequestToCds(cdsClient, cdsProps, ExecutionServiceInput.newBuilder().build());
+        CdsResponse response =
+            cdsActorSvcMgr.sendRequestToCds(cdsClient, cdsProps, ExecutionServiceInput.newBuilder().build());
         assertTrue(Thread.interrupted());
         assertNotNull(response);
         assertEquals(CdsActorConstants.INTERRUPTED, response.getStatus());
@@ -200,8 +199,8 @@ public class CdsActorServiceProviderTest {
     @Test
     public void testSendRequestToCdsLatchTimedOut() {
         CdsActorServiceProvider.CdsActorServiceManager cdsActorSvcMgr = cdsActor.new CdsActorServiceManager();
-        CdsResponse response = cdsActorSvcMgr
-            .sendRequestToCds(cdsClient, cdsProps, ExecutionServiceInput.newBuilder().build());
+        CdsResponse response =
+            cdsActorSvcMgr.sendRequestToCds(cdsClient, cdsProps, ExecutionServiceInput.newBuilder().build());
         assertNotNull(response);
         assertEquals(CdsActorConstants.TIMED_OUT, response.getStatus());
     }