* ONAP
* ================================================================================
* Copyright (C) 2020 AT&T Intellectual Property. All rights reserved.
+ * Modifications Copyright (C) 2023 Nordix Foundation.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
package org.onap.policy.controlloop.actor.aai;
-import static org.assertj.core.api.Assertions.assertThatCode;
-import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.lenient;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeoutException;
-import javax.ws.rs.client.Entity;
import javax.ws.rs.client.InvocationCallback;
import org.junit.AfterClass;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Test;
-import org.mockito.ArgumentCaptor;
-import org.mockito.Captor;
-import org.mockito.Mock;
+import org.junit.runner.RunWith;
+import org.mockito.junit.MockitoJUnitRunner;
import org.onap.policy.aai.AaiConstants;
import org.onap.policy.aai.AaiCqResponse;
-import org.onap.policy.common.endpoints.http.client.HttpClientFactory;
import org.onap.policy.common.endpoints.http.client.HttpClientFactoryInstance;
import org.onap.policy.common.utils.coder.StandardCoder;
-import org.onap.policy.common.utils.coder.StandardCoderObject;
-import org.onap.policy.controlloop.actorserviceprovider.Operation;
import org.onap.policy.controlloop.actorserviceprovider.OperationOutcome;
-import org.onap.policy.controlloop.actorserviceprovider.Util;
-import org.onap.policy.controlloop.actorserviceprovider.impl.HttpOperator;
-import org.onap.policy.controlloop.actorserviceprovider.parameters.ControlLoopOperationParams;
+import org.onap.policy.controlloop.actorserviceprovider.OperationProperties;
+import org.onap.policy.controlloop.actorserviceprovider.OperationResult;
import org.onap.policy.controlloop.actorserviceprovider.parameters.HttpConfig;
import org.onap.policy.controlloop.actorserviceprovider.parameters.HttpParams;
-import org.onap.policy.controlloop.actorserviceprovider.spi.Actor;
-import org.onap.policy.controlloop.policy.PolicyResult;
-public class AaiCustomQueryOperationTest extends BasicAaiOperation<Map<String, String>> {
+@RunWith(MockitoJUnitRunner.class)
+public class AaiCustomQueryOperationTest extends BasicAaiOperation {
private static final StandardCoder coder = new StandardCoder();
private static final String MY_LINK = "my-link";
- private static final String MY_VSERVER = "my-vserver-name";
- private static final String SIM_VSERVER = "OzVServer";
-
- @Captor
- private ArgumentCaptor<Entity<Map<String, String>>> entityCaptor;
-
- @Mock
- private Actor tenantActor;
private AaiCustomQueryOperation oper;
public void setUp() throws Exception {
super.setUpBasic();
- params.getContext().getEnrichment().put(AaiCustomQueryOperation.VSERVER_VSERVER_NAME, MY_VSERVER);
-
- MyTenantOperator tenantOperator = new MyTenantOperator();
-
- when(service.getActor(AaiConstants.ACTOR_NAME)).thenReturn(tenantActor);
- when(tenantActor.getOperator(AaiGetOperation.TENANT)).thenReturn(tenantOperator);
-
oper = new AaiCustomQueryOperation(params, config);
+ oper.setProperty(OperationProperties.AAI_VSERVER_LINK, MY_LINK);
}
/**
HttpParams opParams = HttpParams.builder().clientName(MY_CLIENT).path("v16/query").build();
config = new HttpConfig(blockingExecutor, opParams, HttpClientFactoryInstance.getClientFactory());
- preloadTenantData();
-
- params = params.toBuilder().targetEntity(SIM_VSERVER).retry(0).timeoutSec(5).executor(blockingExecutor).build();
+ params = params.toBuilder().retry(0).timeoutSec(5).executor(blockingExecutor).build();
oper = new AaiCustomQueryOperation(params, config);
+ oper.setProperty(OperationProperties.AAI_VSERVER_LINK, MY_LINK);
+
outcome = oper.start().get();
- assertEquals(PolicyResult.SUCCESS, outcome.getResult());
+ assertEquals(OperationResult.SUCCESS, outcome.getResult());
+
+ assertNotNull(outcome.getResponse());
}
@Test
public void testConstructor() {
assertEquals(AaiConstants.ACTOR_NAME, oper.getActorName());
assertEquals(AaiCustomQueryOperation.NAME, oper.getName());
- assertEquals(MY_VSERVER, oper.getVserver());
-
- // verify that it works with an empty target entity
- params = params.toBuilder().targetEntity("").build();
- assertThatCode(() -> new AaiCustomQueryOperation(params, config)).doesNotThrowAnyException();
+ }
- // try without enrichment data
- params.getContext().getEnrichment().remove(AaiCustomQueryOperation.VSERVER_VSERVER_NAME);
- assertThatIllegalArgumentException().isThrownBy(() -> new AaiCustomQueryOperation(params, config))
- .withMessage("missing " + AaiCustomQueryOperation.VSERVER_VSERVER_NAME + " in enrichment data");
+ @Test
+ public void testGetPropertyNames() {
+ assertThat(oper.getPropertyNames()).isEqualTo(List.of(OperationProperties.AAI_VSERVER_LINK));
}
@Test
@Test
@SuppressWarnings("unchecked")
- public void testStartOperationAsync_testStartPreprocessorAsync_testMakeRequest_testPostProcess() throws Exception {
+ public void testStartOperationAsync_testMakeRequest() throws Exception {
// need two responses
when(rawResponse.readEntity(String.class)).thenReturn(makeTenantReply()).thenReturn(makeCqReply());
- when(webAsync.get(any(InvocationCallback.class))).thenAnswer(provideResponse(rawResponse));
+ lenient().when(webAsync.get(any(InvocationCallback.class))).thenAnswer(provideResponse(rawResponse));
when(webAsync.put(any(), any(InvocationCallback.class))).thenAnswer(provideResponse(rawResponse, 1));
CompletableFuture<OperationOutcome> future2 = oper.start();
- assertEquals(PolicyResult.SUCCESS, getResult(future2));
-
- // tenant response should have been cached within the context
- assertNotNull(context.getProperty(AaiGetOperation.getTenantKey(MY_VSERVER)));
-
- // custom query response should have been cached within the context
- AaiCqResponse cqData = context.getProperty(AaiCqResponse.CONTEXT_KEY);
- assertNotNull(cqData);
+ assertEquals(OperationResult.SUCCESS, getResult(future2));
assertEquals("1", future2.get().getSubRequestId());
}
- /**
- * Tests when preprocessor step is not needed.
- */
- @Test
- @SuppressWarnings("unchecked")
- public void testStartOperationAsync_testStartPreprocessorAsyncNotNeeded() throws Exception {
- // pre-load the tenant data
- final StandardCoderObject data = preloadTenantData();
-
- // only need one response
- when(rawResponse.readEntity(String.class)).thenReturn(makeCqReply());
- when(webAsync.put(any(), any(InvocationCallback.class))).thenAnswer(provideResponse(rawResponse, 1));
-
- CompletableFuture<OperationOutcome> future2 = oper.start();
-
- assertEquals(PolicyResult.SUCCESS, getResult(future2));
-
- // should not have replaced tenant response
- assertSame(data, context.getProperty(AaiGetOperation.getTenantKey(MY_VSERVER)));
-
- // custom query response should have been cached within the context
- AaiCqResponse cqData = context.getProperty(AaiCqResponse.CONTEXT_KEY);
- assertNotNull(cqData);
- }
-
@Test
public void testMakeHeaders() {
verifyHeaders(oper.makeHeaders());
@Test
@SuppressWarnings("unchecked")
- public void testMakeRequest() throws Exception {
- // preload
- preloadTenantData();
-
+ public void testMakeRequest_testGetVserverLink() throws Exception {
when(rawResponse.readEntity(String.class)).thenReturn(makeCqReply());
when(webAsync.put(any(), any(InvocationCallback.class))).thenAnswer(provideResponse(rawResponse, 1));
oper.start();
executor.runAll(100);
- verify(webAsync).put(entityCaptor.capture(), any(InvocationCallback.class));
+ verify(webAsync).put(requestCaptor.capture(), any(InvocationCallback.class));
+
+ String reqText = requestCaptor.getValue().getEntity();
+ Map<String, String> reqMap = coder.decode(reqText, Map.class);
// sort the request fields so they match the order in cq.json
- Map<String, String> request = new TreeMap<>(entityCaptor.getValue().getEntity());
+ Map<String, String> request = new TreeMap<>(reqMap);
verifyRequest("cq.json", request);
}
@Test
- @SuppressWarnings("unchecked")
- public void testMakeRequestNoResourceLink() throws Exception {
- // pre-load EMPTY tenant data
- preloadTenantData(new StandardCoderObject());
-
- when(rawResponse.readEntity(String.class)).thenReturn(makeCqReply());
- when(webAsync.put(any(), any(InvocationCallback.class))).thenAnswer(provideResponse(rawResponse, 1));
+ public void testGetVserverLink() throws Exception {
+ oper.setProperty(OperationProperties.AAI_VSERVER_LINK, MY_LINK);
+ assertEquals(MY_LINK, oper.getVserverLink());
+ }
- CompletableFuture<OperationOutcome> future2 = oper.start();
+ @Test
+ public void testSetOutcome() {
+ outcome = oper.setOutcome(params.makeOutcome(), OperationResult.SUCCESS, null, null);
+ assertNull(outcome.getResponse());
- assertEquals(PolicyResult.FAILURE_EXCEPTION, getResult(future2));
+ outcome = oper.setOutcome(params.makeOutcome(), OperationResult.SUCCESS, null, "{}");
+ assertTrue(outcome.getResponse() instanceof AaiCqResponse);
}
private String makeTenantReply() throws Exception {
return "{}";
}
- private StandardCoderObject preloadTenantData() throws Exception {
- StandardCoderObject data = coder.decode(makeTenantReply(), StandardCoderObject.class);
- preloadTenantData(data);
- return data;
- }
-
- private void preloadTenantData(StandardCoderObject data) {
- context.setProperty(AaiGetOperation.getTenantKey(MY_VSERVER), data);
- context.setProperty(AaiGetOperation.getTenantKey(SIM_VSERVER), data);
- }
- private PolicyResult getResult(CompletableFuture<OperationOutcome> future2)
+ private OperationResult getResult(CompletableFuture<OperationOutcome> future2)
throws InterruptedException, ExecutionException, TimeoutException {
executor.runAll(100);
return future2.get().getResult();
}
-
- protected class MyTenantOperator extends HttpOperator {
- public MyTenantOperator() {
- super(AaiConstants.ACTOR_NAME, AaiGetOperation.TENANT);
-
- HttpParams http = HttpParams.builder().clientName(MY_CLIENT).path(PATH).timeoutSec(1).build();
-
- configure(Util.translateToMap(AaiGetOperation.TENANT, http));
- start();
- }
-
- @Override
- public Operation buildOperation(ControlLoopOperationParams params) {
- return new AaiGetOperation(params, getCurrentConfig());
- }
-
- @Override
- protected HttpClientFactory getClientFactory() {
- return factory;
- }
- }
}
Code Review / policy / models.git / blobdiff