Fix sonars in apex-pdp

[policy/apex-pdp.git] / model / utilities / src / main / java / org / onap / policy / apex / model / utilities / CollectionUtils.java

diff --git a/model/utilities/src/main/java/org/onap/policy/apex/model/utilities/CollectionUtils.java b/model/utilities/src/main/java/org/onap/policy/apex/model/utilities/CollectionUtils.java
index 7ca50a6..190b270 100644 (file)
--- a/model/utilities/src/main/java/org/onap/policy/apex/model/utilities/CollectionUtils.java
+++ b/model/utilities/src/main/java/org/onap/policy/apex/model/utilities/CollectionUtils.java
@@ -1,19 +1,20 @@
 /*-
  * ============LICENSE_START=======================================================
  *  Copyright (C) 2016-2018 Ericsson. All rights reserved.
+ *  Modifications Copyright (C) 2021 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
- * 
+ *
  * SPDX-License-Identifier: Apache-2.0
  * ============LICENSE_END=========================================================
  */
@@ -28,7 +29,7 @@ import java.util.ListIterator;
  *
  * @author Liam Fallon (liam.fallon@ericsson.com)
  */
-public abstract class CollectionUtils {
+public class CollectionUtils {
     /**
      * Private constructor used to prevent sub class instantiation.
      */
@@ -43,7 +44,8 @@ public abstract class CollectionUtils {
      * @param rightList The rightmost list
      * @return an integer indicating how different the lists are
      */
-    public static <T> int compareLists(final List<? extends Comparable<T>> leftList, final List<? extends Comparable<T>> rightList) {
+    public static <T> int compareLists(final List<? extends Comparable<T>> leftList,
+                    final List<? extends Comparable<T>> rightList) {
         // Check for nulls
         if (leftList == null && rightList == null) {
             return 0;
@@ -59,7 +61,7 @@ public abstract class CollectionUtils {
         if (leftList.equals(rightList)) {
             return 0;
         }
-        
+
         return compareListEntries(leftList, rightList);
     }
 
@@ -71,8 +73,9 @@ public abstract class CollectionUtils {
      * @param rightList The rightmost list
      * @return an integer indicating how different the lists are
      */
-    private static <T> int compareListEntries(final List<? extends Comparable<T>> leftList, final List<? extends Comparable<T>> rightList) {
-        
+    private static <T> int compareListEntries(final List<? extends Comparable<T>> leftList,
+                    final List<? extends Comparable<T>> rightList) {
+
         // Iterate down the lists till we find a difference
         final ListIterator<?> leftIterator = leftList.listIterator();
         final ListIterator<?> rightIterator = rightList.listIterator();
@@ -104,5 +107,5 @@ public abstract class CollectionUtils {
                 return comparisonResult;
             }
         }
-       }
+    }
 }