Refactor xacml-pdp to remove various statics

[policy/xacml-pdp.git] / main / src / main / java / org / onap / policy / pdpx / main / rest / XacmlPdpApplicationManager.java

diff --git a/main/src/main/java/org/onap/policy/pdpx/main/rest/XacmlPdpApplicationManager.java b/main/src/main/java/org/onap/policy/pdpx/main/rest/XacmlPdpApplicationManager.java
index 785d759..6a5555b 100644 (file)
--- a/main/src/main/java/org/onap/policy/pdpx/main/rest/XacmlPdpApplicationManager.java
+++ b/main/src/main/java/org/onap/policy/pdpx/main/rest/XacmlPdpApplicationManager.java
@@ -30,6 +30,8 @@ import java.util.List;
 import java.util.Map;
 import java.util.ServiceLoader;
 import java.util.stream.Collectors;
+import lombok.Getter;
+import lombok.Setter;
 import org.onap.policy.models.decisions.concepts.DecisionRequest;
 import org.onap.policy.models.tosca.authorative.concepts.ToscaPolicy;
 import org.onap.policy.models.tosca.authorative.concepts.ToscaPolicyIdentifier;
@@ -42,29 +44,22 @@ import org.slf4j.LoggerFactory;
 public class XacmlPdpApplicationManager {
     private static final Logger LOGGER = LoggerFactory.getLogger(XacmlPdpApplicationManager.class);
 
-    private static boolean needsInit = true;
-    private static ServiceLoader<XacmlApplicationServiceProvider> applicationLoader;
-    private static Map<String, XacmlApplicationServiceProvider> providerActionMap = new HashMap<>();
-    private static List<ToscaPolicyTypeIdentifier> toscaPolicyTypeIdents = new ArrayList<>();
-    private static List<ToscaPolicyIdentifier> toscaPolicyIdents = new ArrayList<>();
-    private static List<ToscaPolicy> toscaPolicies = new ArrayList<>();
-    private static Map<ToscaPolicy, XacmlApplicationServiceProvider> mapLoadedPolicies = new HashMap<>();
+    @Getter
+    @Setter
+    private static XacmlPdpApplicationManager current;
 
+    private ServiceLoader<XacmlApplicationServiceProvider> applicationLoader;
+    private Map<String, XacmlApplicationServiceProvider> providerActionMap = new HashMap<>();
+    private List<ToscaPolicyTypeIdentifier> toscaPolicyTypeIdents = new ArrayList<>();
+    private Map<ToscaPolicy, XacmlApplicationServiceProvider> mapLoadedPolicies = new HashMap<>();
 
-    private XacmlPdpApplicationManager() {
-        super();
-    }
 
     /**
      * One time to initialize the applications upon startup.
      */
-    public static void initializeApplications(Path applicationPath) {
-        //
-        // If we have already done this
-        //
-        if (! needsInit) {
-            LOGGER.error("Already initialized the applications");
-            return;
+    public XacmlPdpApplicationManager(Path applicationPath) {
+        if (LOGGER.isInfoEnabled()) {
+            LOGGER.info("Initialization applications {}", applicationPath.toAbsolutePath());
         }
         //
         // Load service
@@ -74,8 +69,10 @@ public class XacmlPdpApplicationManager {
         // Iterate through the applications for actions and supported policy types
         //
         for (XacmlApplicationServiceProvider application : applicationLoader) {
-            LOGGER.info("Application {} supports {}", application.applicationName(),
+            if (LOGGER.isInfoEnabled()) {
+                LOGGER.info("Application {} supports {}", application.applicationName(),
                     application.supportedPolicyTypes());
+            }
             //
             // We are not going to make this available unless the application can
             // install correctly.
@@ -112,10 +109,11 @@ public class XacmlPdpApplicationManager {
         //
         // we have initialized
         //
-        needsInit = false;
+        LOGGER.info("Finished applications initialization {}", providerActionMap);
+
     }
 
-    public static XacmlApplicationServiceProvider findApplication(DecisionRequest request) {
+    public XacmlApplicationServiceProvider findApplication(DecisionRequest request) {
         return providerActionMap.get(request.getAction());
     }
 
@@ -124,7 +122,7 @@ public class XacmlPdpApplicationManager {
      *
      * @return the map containing ToscaPolicies
      */
-    public static Map<ToscaPolicy, XacmlApplicationServiceProvider> getToscaPolicies() {
+    public Map<ToscaPolicy, XacmlApplicationServiceProvider> getToscaPolicies() {
         return mapLoadedPolicies;
     }
 
@@ -133,14 +131,14 @@ public class XacmlPdpApplicationManager {
      *
      * @return list of ToscaPolicyIdentifier
      */
-    public static List<ToscaPolicyIdentifier> getToscaPolicyIdentifiers() {
+    public List<ToscaPolicyIdentifier> getToscaPolicyIdentifiers() {
         //
         // converting map to return List of ToscaPolicyIdentiers
         //
         return mapLoadedPolicies.keySet().stream().map(ToscaPolicy::getIdentifier).collect(Collectors.toList());
     }
 
-    public static List<ToscaPolicyTypeIdentifier> getToscaPolicyTypeIdents() {
+    public List<ToscaPolicyTypeIdentifier> getToscaPolicyTypeIdents() {
         return toscaPolicyTypeIdents;
     }
 
@@ -149,13 +147,15 @@ public class XacmlPdpApplicationManager {
      *
      * @param policy Incoming policy
      */
-    public static void removeUndeployedPolicy(ToscaPolicy policy) {
+    public void removeUndeployedPolicy(ToscaPolicy policy) {
 
         for (XacmlApplicationServiceProvider application : applicationLoader) {
             try {
                 if (application.unloadPolicy(policy)) {
-                    LOGGER.info("Unloaded ToscaPolicy {} from application {}", policy.getMetadata(),
+                    if (LOGGER.isInfoEnabled()) {
+                        LOGGER.info("Unloaded ToscaPolicy {} from application {}", policy.getMetadata(),
                             application.applicationName());
+                    }
                     if (mapLoadedPolicies.remove(policy) == null) {
                         LOGGER.error("Failed to remove unloaded policy {} from map size {}", policy.getMetadata(),
                                 mapLoadedPolicies.size());
@@ -172,7 +172,7 @@ public class XacmlPdpApplicationManager {
      *
      * @param policy Incoming policy
      */
-    public static void loadDeployedPolicy(ToscaPolicy policy) {
+    public void loadDeployedPolicy(ToscaPolicy policy) {
 
         for (XacmlApplicationServiceProvider application : applicationLoader) {
             try {
@@ -183,8 +183,10 @@ public class XacmlPdpApplicationManager {
                 //
                 if (application.canSupportPolicyType(policy.getTypeIdentifier())) {
                     if (application.loadPolicy(policy)) {
-                        LOGGER.info("Loaded ToscaPolicy {} into application {}", policy.getMetadata(),
+                        if (LOGGER.isInfoEnabled()) {
+                            LOGGER.info("Loaded ToscaPolicy {} into application {}", policy.getMetadata(),
                                 application.applicationName());
+                        }
                         mapLoadedPolicies.put(policy, application);
                     }
                     return;
@@ -202,7 +204,7 @@ public class XacmlPdpApplicationManager {
      *
      * @return Total count added from all applications
      */
-    public static long getPolicyTypeCount() {
+    public long getPolicyTypeCount() {
         long types = 0;
         for (XacmlApplicationServiceProvider application : applicationLoader) {
             types += application.supportedPolicyTypes().size();
@@ -210,14 +212,16 @@ public class XacmlPdpApplicationManager {
         return types;
     }
 
-    private static void initializeApplicationPath(Path basePath, XacmlApplicationServiceProvider application)
+    private void initializeApplicationPath(Path basePath, XacmlApplicationServiceProvider application)
             throws XacmlApplicationException {
         //
         // Making an assumption that all application names are unique, and
         // they can result in a valid directory being created.
         //
         Path path = Paths.get(basePath.toAbsolutePath().toString(), application.applicationName());
-        LOGGER.info("initializeApplicationPath {} at this path {}", application.applicationName(), path);
+        if (LOGGER.isInfoEnabled()) {
+            LOGGER.info("initializeApplicationPath {} at this path {}", application.applicationName(), path);
+        }
         //
         // Create that the directory if it does not exist. Ideally
         // this is only for testing, but could be used for production
@@ -231,7 +235,7 @@ public class XacmlPdpApplicationManager {
                 //
                 Files.createDirectory(path);
             } catch (IOException e) {
-                LOGGER.error("Failed to create application directory", e);
+                LOGGER.error("Failed to create application directory {}", path.toAbsolutePath().toString(), e);
             }
         }
         //
@@ -239,5 +243,4 @@ public class XacmlPdpApplicationManager {
         //
         application.initialize(path);
     }
-
 }