Changes for cascaded get in policy models

[policy/api.git] / main / src / main / java / org / onap / policy / api / main / rest / provider / PolicyTypeProvider.java

diff --git a/main/src/main/java/org/onap/policy/api/main/rest/provider/PolicyTypeProvider.java b/main/src/main/java/org/onap/policy/api/main/rest/provider/PolicyTypeProvider.java
index d325f2c..9c9c41c 100644 (file)
--- a/main/src/main/java/org/onap/policy/api/main/rest/provider/PolicyTypeProvider.java
+++ b/main/src/main/java/org/onap/policy/api/main/rest/provider/PolicyTypeProvider.java
@@ -23,16 +23,7 @@
 \r
 package org.onap.policy.api.main.rest.provider;\r
 \r
-import java.util.ArrayList;\r
-import java.util.List;\r
-import java.util.Map.Entry;\r
-\r
-import javax.ws.rs.core.Response;\r
-\r
 import org.onap.policy.models.base.PfModelException;\r
-import org.onap.policy.models.tosca.authorative.concepts.ToscaPolicy;\r
-import org.onap.policy.models.tosca.authorative.concepts.ToscaPolicyFilter;\r
-import org.onap.policy.models.tosca.authorative.concepts.ToscaPolicyType;\r
 import org.onap.policy.models.tosca.authorative.concepts.ToscaPolicyTypeFilter;\r
 import org.onap.policy.models.tosca.authorative.concepts.ToscaServiceTemplate;\r
 \r
@@ -63,14 +54,7 @@ public class PolicyTypeProvider extends CommonModelProvider {
     public ToscaServiceTemplate fetchPolicyTypes(String policyTypeId, String policyTypeVersion)\r
             throws PfModelException {\r
 \r
-        ToscaServiceTemplate serviceTemplate = getFilteredPolicyTypes(policyTypeId, policyTypeVersion);\r
-\r
-        if (policyTypeId != null && !hasPolicyType(serviceTemplate)) {\r
-            throw new PfModelException(Response.Status.NOT_FOUND,\r
-                    constructResourceNotFoundMessage(policyTypeId, policyTypeVersion));\r
-        }\r
-\r
-        return serviceTemplate;\r
+        return getFilteredPolicyTypes(policyTypeId, policyTypeVersion);\r
     }\r
 \r
     /**\r
@@ -84,13 +68,7 @@ public class PolicyTypeProvider extends CommonModelProvider {
      */\r
     public ToscaServiceTemplate fetchLatestPolicyTypes(String policyTypeId) throws PfModelException {\r
 \r
-        ToscaServiceTemplate serviceTemplate =\r
-                getFilteredPolicyTypes(policyTypeId, ToscaPolicyTypeFilter.LATEST_VERSION);\r
-        if (!hasPolicyType(serviceTemplate)) {\r
-            throw new PfModelException(Response.Status.NOT_FOUND, constructResourceNotFoundMessage(policyTypeId, null));\r
-        }\r
-\r
-        return serviceTemplate;\r
+        return getFilteredPolicyTypes(policyTypeId, ToscaPolicyTypeFilter.LATEST_VERSION);\r
     }\r
 \r
     /**\r
@@ -103,11 +81,6 @@ public class PolicyTypeProvider extends CommonModelProvider {
      */\r
     public ToscaServiceTemplate createPolicyType(ToscaServiceTemplate body) throws PfModelException {\r
 \r
-        if (!hasPolicyType(body)) {\r
-            throw new PfModelException(Response.Status.BAD_REQUEST,\r
-                    "no policy types specified in the service template");\r
-        }\r
-        validatePolicyTypeVersionExist(body);\r
         return modelsProvider.createPolicyTypes(body);\r
     }\r
 \r
@@ -124,60 +97,7 @@ public class PolicyTypeProvider extends CommonModelProvider {
     public ToscaServiceTemplate deletePolicyType(String policyTypeId, String policyTypeVersion)\r
             throws PfModelException {\r
 \r
-        validateDeleteEligibility(policyTypeId, policyTypeVersion);\r
-\r
-        ToscaServiceTemplate serviceTemplate = modelsProvider.deletePolicyType(policyTypeId, policyTypeVersion);\r
-\r
-        if (!hasPolicyType(serviceTemplate)) {\r
-            throw new PfModelException(Response.Status.NOT_FOUND,\r
-                    constructResourceNotFoundMessage(policyTypeId, policyTypeVersion));\r
-        }\r
-\r
-        return serviceTemplate;\r
-    }\r
-\r
-    /**\r
-     * Validates whether specified policy type can be deleted based on the rule that policy type parameterized by at\r
-     * least one policies cannot be deleted.\r
-     *\r
-     * @param policyTypeId the ID of policy type\r
-     * @param policyTypeVersion the version of policy type\r
-     *\r
-     * @throws PfModelException the PfModel parsing exception\r
-     */\r
-    private void validateDeleteEligibility(String policyTypeId, String policyTypeVersion) throws PfModelException {\r
-\r
-        ToscaPolicyFilter policyFilter =\r
-                ToscaPolicyFilter.builder().type(policyTypeId).typeVersion(policyTypeVersion).build();\r
-        List<ToscaPolicy> policies = modelsProvider.getFilteredPolicyList(policyFilter);\r
-        if (!policies.isEmpty()) {\r
-            throw new PfModelException(Response.Status.CONFLICT,\r
-                    constructDeletePolicyTypeViolationMessage(policyTypeId, policyTypeVersion, policies));\r
-        }\r
-    }\r
-\r
-    /**\r
-     * Validates that each policy type has a version specified in the payload.\r
-     *\r
-     * @param body the TOSCA service template payload to check against\r
-     *\r
-     * @throws PfModelException the PfModel parsing exception\r
-     */\r
-    private void validatePolicyTypeVersionExist(ToscaServiceTemplate body) throws PfModelException {\r
-\r
-        List<String> invalidPolicyTypeNames = new ArrayList<>();\r
-        for (Entry<String, ToscaPolicyType> policyType : body.getPolicyTypes().entrySet()) {\r
-            if (!"tosca.policies.Root".equals(policyType.getValue().getDerivedFrom())\r
-                    && policyType.getValue().getVersion() == null) {\r
-                invalidPolicyTypeNames.add(policyType.getKey());\r
-            }\r
-        }\r
-\r
-        if (!invalidPolicyTypeNames.isEmpty()) {\r
-            String errorMsg = "mandatory 'version' field is missing in policy types: "\r
-                    + String.join(", ", invalidPolicyTypeNames);\r
-            throw new PfModelException(Response.Status.NOT_ACCEPTABLE, errorMsg);\r
-        }\r
+        return modelsProvider.deletePolicyType(policyTypeId, policyTypeVersion);\r
     }\r
 \r
     /**\r
@@ -197,17 +117,4 @@ public class PolicyTypeProvider extends CommonModelProvider {
                 ToscaPolicyTypeFilter.builder().name(policyTypeName).version(policyTypeVersion).build();\r
         return modelsProvider.getFilteredPolicyTypes(policyTypeFilter);\r
     }\r
-\r
-    /**\r
-     * Constructs returned message for not found resource.\r
-     *\r
-     * @param policyTypeId the ID of policy type\r
-     * @param policyTypeVersion the version of policy type\r
-     *\r
-     * @return constructed message\r
-     */\r
-    private String constructResourceNotFoundMessage(String policyTypeId, String policyTypeVersion) {\r
-\r
-        return "policy type with ID " + policyTypeId + ":" + policyTypeVersion + " does not exist";\r
-    }\r
 }\r