Policy API JUnit Tests

[policy/api.git] / main / src / main / java / org / onap / policy / api / main / rest / provider / LegacyOperationalPolicyProvider.java

diff --git a/main/src/main/java/org/onap/policy/api/main/rest/provider/LegacyOperationalPolicyProvider.java b/main/src/main/java/org/onap/policy/api/main/rest/provider/LegacyOperationalPolicyProvider.java
index 2f0b127..ac8fa26 100644 (file)
--- a/main/src/main/java/org/onap/policy/api/main/rest/provider/LegacyOperationalPolicyProvider.java
+++ b/main/src/main/java/org/onap/policy/api/main/rest/provider/LegacyOperationalPolicyProvider.java
@@ -22,13 +22,15 @@
 
 package org.onap.policy.api.main.rest.provider;
 
+import java.util.ArrayList;
+import java.util.List;
+
 import javax.ws.rs.core.Response;
-import org.onap.policy.api.main.parameters.ApiParameterGroup;
-import org.onap.policy.common.parameters.ParameterService;
+
 import org.onap.policy.models.base.PfModelException;
-import org.onap.policy.models.provider.PolicyModelsProvider;
-import org.onap.policy.models.provider.PolicyModelsProviderFactory;
-import org.onap.policy.models.provider.PolicyModelsProviderParameters;
+import org.onap.policy.models.pdp.concepts.PdpGroup;
+import org.onap.policy.models.pdp.concepts.PdpGroupFilter;
+import org.onap.policy.models.tosca.authorative.concepts.ToscaPolicyIdentifier;
 import org.onap.policy.models.tosca.legacy.concepts.LegacyOperationalPolicy;
 
 /**
@@ -36,19 +38,17 @@ import org.onap.policy.models.tosca.legacy.concepts.LegacyOperationalPolicy;
  *
  * @author Chenfei Gao (cgao@research.att.com)
  */
-public class LegacyOperationalPolicyProvider {
+public class LegacyOperationalPolicyProvider extends CommonModelProvider {
+
+    private static final String INVALID_POLICY_VERSION = "legacy policy version is not an integer";
+    private static final String LEGACY_MINOR_PATCH_SUFFIX = ".0.0";
 
-    private PolicyModelsProvider modelsProvider;
 
     /**
      * Default constructor.
      */
     public LegacyOperationalPolicyProvider() throws PfModelException {
-
-        ApiParameterGroup parameterGroup = ParameterService.get("ApiGroup");
-        PolicyModelsProviderParameters providerParameters = parameterGroup.getDatabaseProviderParameters();
-        modelsProvider = new PolicyModelsProviderFactory().createPolicyModelsProvider(providerParameters);
-        modelsProvider.init();
+        super();
     }
 
     /**
@@ -59,12 +59,13 @@ public class LegacyOperationalPolicyProvider {
      *
      * @return the LegacyOperationalPolicy object
      */
-    public LegacyOperationalPolicy fetchOperationalPolicies(String policyId, String policyVersion)
+    public LegacyOperationalPolicy fetchOperationalPolicy(String policyId, String policyVersion)
             throws PfModelException {
 
-        LegacyOperationalPolicy operationalPolicy = modelsProvider.getOperationalPolicy(policyId);
-        close();
-        return operationalPolicy;
+        if (policyVersion != null) {
+            validNumber(policyVersion, INVALID_POLICY_VERSION);
+        }
+        return modelsProvider.getOperationalPolicy(policyId, policyVersion);
     }
 
     /**
@@ -76,9 +77,7 @@ public class LegacyOperationalPolicyProvider {
      */
     public LegacyOperationalPolicy createOperationalPolicy(LegacyOperationalPolicy body) throws PfModelException {
 
-        LegacyOperationalPolicy operationalPolicy = modelsProvider.createOperationalPolicy(body);
-        close();
-        return operationalPolicy;
+        return modelsProvider.createOperationalPolicy(body);
     }
 
     /**
@@ -89,25 +88,34 @@ public class LegacyOperationalPolicyProvider {
      *
      * @return the LegacyOperationalPolicy object
      */
-    public LegacyOperationalPolicy deleteOperationalPolicies(String policyId, String policyVersion)
+    public LegacyOperationalPolicy deleteOperationalPolicy(String policyId, String policyVersion)
             throws PfModelException {
 
-        LegacyOperationalPolicy operationalPolicy = modelsProvider.deleteOperationalPolicy(policyId);
-        close();
-        return operationalPolicy;
+        validNumber(policyVersion, INVALID_POLICY_VERSION);
+        validateDeleteEligibility(policyId, policyVersion);
+
+        return modelsProvider.deleteOperationalPolicy(policyId, policyVersion);
     }
 
     /**
-     * Closes the connection to database.
+     * Validates whether specified policy can be deleted based on the rule that deployed policy cannot be deleted.
+     *
+     * @param policyId the ID of policy
+     * @param policyVersion the version of policy
      *
      * @throws PfModelException the PfModel parsing exception
      */
-    private void close() throws PfModelException {
-        try {
-            modelsProvider.close();
-        } catch (Exception e) {
-            throw new PfModelException(
-                    Response.Status.INTERNAL_SERVER_ERROR, "error closing connection to database", e);
+    private void validateDeleteEligibility(String policyId, String policyVersion) throws PfModelException {
+
+        List<ToscaPolicyIdentifier> policies = new ArrayList<>();
+        policies.add(new ToscaPolicyIdentifier(policyId, policyVersion + LEGACY_MINOR_PATCH_SUFFIX));
+        PdpGroupFilter pdpGroupFilter = PdpGroupFilter.builder().policyList(policies).build();
+
+        List<PdpGroup> pdpGroups = modelsProvider.getFilteredPdpGroups(pdpGroupFilter);
+
+        if (!pdpGroups.isEmpty()) {
+            throw new PfModelException(Response.Status.CONFLICT,
+                    constructDeletePolicyViolationMessage(policyId, policyVersion, pdpGroups));
         }
     }
 }
\ No newline at end of file