update link to upper-constraints.txt

[vfc/nfvo/lcm.git] / lcm / ns / views / sol / terminate_ns_view.py

diff --git a/lcm/ns/views/sol/terminate_ns_view.py b/lcm/ns/views/sol/terminate_ns_view.py
index c621382..31b63ad 100644 (file)
--- a/lcm/ns/views/sol/terminate_ns_view.py
+++ b/lcm/ns/views/sol/terminate_ns_view.py
@@ -20,46 +20,54 @@ from rest_framework.views import APIView
 
 from lcm.ns.biz.ns_terminate import TerminateNsService
 from lcm.pub.utils.jobutil import JobUtil
-from lcm.pub.utils.jobutil import JOB_TYPE
+from lcm.jobs.enum import JOB_TYPE, JOB_ACTION
 from lcm.pub.utils.values import ignore_case_get
 from lcm.ns.serializers.sol.terminate_ns_serializers import TerminateNsReqSerializer
 from lcm.pub.exceptions import BadRequestException
 from lcm.ns.const import NS_OCC_BASE_URI
+from lcm.ns.serializers.sol.pub_serializers import ProblemDetailsSerializer
+from .common import view_safe_call_with_log
 
 logger = logging.getLogger(__name__)
 
 
 class TerminateNsView(APIView):
+    """
+    This task resource represents the "Terminate NS" operation.
+    The client can use this resource to terminate a NS instance.
+    """
 
     @swagger_auto_schema(
         request_body=TerminateNsReqSerializer(),
         responses={
-            status.HTTP_202_ACCEPTED: None,
-            status.HTTP_500_INTERNAL_SERVER_ERROR: "Inner error"
+            status.HTTP_202_ACCEPTED: "HTTP_202_ACCEPTED",
+            status.HTTP_500_INTERNAL_SERVER_ERROR: ProblemDetailsSerializer()
         }
     )
+    @view_safe_call_with_log(logger=logger)
     def post(self, request, ns_instance_id):
-        try:
-            logger.debug("Enter TerminateNSView::post %s", request.data)
-            req_serializer = TerminateNsReqSerializer(data=request.data)
-            if not req_serializer.is_valid():
-                logger.debug("request.data is not valid,error: %s" % req_serializer.errors)
-                raise BadRequestException(req_serializer.errors)
-            terminationTime = ignore_case_get(request.data, 'terminationTime')
-            logger.debug("terminationTime is %s" % terminationTime)
-            # todo terminationTime
-            job_id = JobUtil.create_job("NS", JOB_TYPE.TERMINATE_NS, ns_instance_id)
-            terminateNsService = TerminateNsService(ns_instance_id, job_id, request.data)
-            terminateNsService.start()
-            logger.debug("Location: %s" % terminateNsService.occ_id)
-            response = Response(data={}, status=status.HTTP_202_ACCEPTED)
-            response["Location"] = NS_OCC_BASE_URI % terminateNsService.occ_id
-            return response
-        except BadRequestException as e:
-            logger.error("Exception in CreateNS: %s", e.message)
-            data = {'status': status.HTTP_400_BAD_REQUEST, 'detail': e.message}
-            return Response(data=data, status=status.HTTP_400_BAD_REQUEST)
-        except Exception as e:
-            logger.error("Exception in CreateNS: %s", e.message)
-            data = {'status': status.HTTP_400_BAD_REQUEST, 'detail': e.message}
-            return Response(data=data, status=status.HTTP_500_INTERNAL_SERVER_ERROR)
+        """
+        The POST method terminates a NS instance.
+        This method can only be used with a NS instance in the INSTANTIATEDstate.
+        Terminating a NS instance does not delete the NS instance identifier, but rather transitions the NS into the NOT_INSTANTIATED state.
+        :param request:
+        :param ns_instance_id:
+        :return:
+        """
+        job_id = JobUtil.create_job(JOB_TYPE.NS, JOB_ACTION.TERMINATE, ns_instance_id)
+
+        logger.debug("Enter TerminateNSView::post %s", request.data)
+        req_serializer = TerminateNsReqSerializer(data=request.data)
+        if not req_serializer.is_valid():
+            logger.debug("request.data is not valid,error: %s" % req_serializer.errors)
+            raise BadRequestException(req_serializer.errors)
+        termination_time = ignore_case_get(request.data, 'terminationTime')
+        logger.debug("terminationTime is %s" % termination_time)
+        # todo terminationTime
+        terminate_ns_service = TerminateNsService(ns_instance_id, job_id, request.data)
+        terminate_ns_service.start()
+        logger.debug("Location: %s" % terminate_ns_service.occ_id)
+        response = Response(data={'jobId': job_id}, status=status.HTTP_202_ACCEPTED)
+        response["Location"] = NS_OCC_BASE_URI % terminate_ns_service.occ_id
+        logger.debug("Leave TerminateNSView")
+        return response