*/
package org.onap.holmes.common.aai;
+import java.io.IOException;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import javax.inject.Inject;
import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpResponse;
+import org.apache.http.client.methods.HttpGet;
+import org.apache.http.client.methods.HttpRequestBase;
+import org.apache.http.impl.client.CloseableHttpClient;
import org.jvnet.hk2.annotations.Service;
import org.onap.holmes.common.aai.config.AaiConfig;
import org.onap.holmes.common.aai.entity.VmEntity;
private String getVmResourceLinks(String vserverId, String vserverName) throws CorrelationException {
String response = getResourceLinksResponse(vserverId, vserverName);
List linkList = aaiResponseUtil.convertJsonToVmResourceLink(response);
- if (linkList.size() != 0) {
+ if (!linkList.isEmpty()) {
return aaiResponseUtil.convertJsonToVmResourceLink(response).get(0).getResourceLink();
}
return "";
addrSplits[1] = addrSplits[0] + "-" + addrSplits[2];
addrSplits[2] = ret;
addrSplits[0] = "api";
- StringBuffer stringBuffer = new StringBuffer();
+ StringBuilder stringBuffer = new StringBuilder();
for (String split : addrSplits) {
stringBuffer.append("/" + split);
}
}
private String getResponse(String url) throws CorrelationException {
- String response = "";
+ String response;
+ CloseableHttpClient httpClient = null;
+ HttpGet httpGet = new HttpGet(url);
try {
- response = HttpsUtils.get(url, getHeaders());
+ httpClient = HttpsUtils.getHttpClient(HttpsUtils.DEFUALT_TIMEOUT);
+ HttpResponse httpResponse = HttpsUtils.get(httpGet, getHeaders(), httpClient);
+ response = HttpsUtils.extractResponseEntity(httpResponse);
} catch (Exception e) {
throw new CorrelationException("Failed to get data from aai", e);
+ } finally {
+ httpGet.releaseConnection();
+ if (httpClient != null) {
+ try {
+ httpClient.close();
+ } catch (IOException e) {
+ log.warn("Failed to close http client!");
+ }
+ }
}
return response;
}