Fixed health check issue

[portal.git] / ecomp-portal-BE-common / src / test / java / org / onap / portalapp / portal / controller / PortalAdminControllerTest.java

diff --git a/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/controller/PortalAdminControllerTest.java b/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/controller/PortalAdminControllerTest.java
index 94e55af..bd8d155 100644 (file)
--- a/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/controller/PortalAdminControllerTest.java
+++ b/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/controller/PortalAdminControllerTest.java
@@ -42,21 +42,17 @@ import static org.junit.Assert.assertNull;
 
 import java.util.ArrayList;
 import java.util.List;
-
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
-
 import org.junit.Before;
 import org.junit.Test;
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.Mockito;
 import org.mockito.MockitoAnnotations;
-import org.onap.portalapp.portal.controller.PortalAdminController;
 import org.onap.portalapp.portal.core.MockEPUser;
 import org.onap.portalapp.portal.domain.EPRole;
 import org.onap.portalapp.portal.domain.EPUser;
-import org.onap.portalapp.portal.exceptions.NoHealthyServiceException;
 import org.onap.portalapp.portal.framework.MockitoTestSuite;
 import org.onap.portalapp.portal.service.AdminRolesService;
 import org.onap.portalapp.portal.service.AdminRolesServiceImpl;
@@ -72,7 +68,7 @@ import org.onap.portalsdk.core.service.AuditServiceImpl;
 public class PortalAdminControllerTest extends MockitoTestSuite{
 
        @InjectMocks
-       PortalAdminController portalAdminController = new PortalAdminController();
+       PortalAdminController portalAdminController;
 
        @Mock
        AdminRolesService adminRolesService = new AdminRolesServiceImpl();
@@ -167,16 +163,31 @@ public class PortalAdminControllerTest extends MockitoTestSuite{
         assertEquals(actualFieldValidator,expectedFieldValidator);
 
        }
-               
-//     @Test
-//     public void createPortalAdminIfUserIsNullTest()
-//     {
-//             //EPUser user = null;
-//             Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(null);
-//             String sbcid = "null";
-//             assertNull(portalAdminController.createPortalAdmin(mockedRequest, sbcid, mockedResponse));
-//
-//     }
+
+       @Test
+       public void createPortalAdminXSSTest()
+       {
+               EPUser user = mockUser.mockEPUser();
+               Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
+               FieldsValidator expectedFieldValidator = null;
+               FieldsValidator actualFieldValidator;
+               String userId = "<IMG SRC=jAVasCrIPt:alert(‘XSS’)>";
+               Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(true);
+               Mockito.when(portalAdminService.createPortalAdmin(userId)).thenReturn(expectedFieldValidator);
+               actualFieldValidator = portalAdminController.createPortalAdmin(mockedRequest, userId, mockedResponse);
+               assertEquals(expectedFieldValidator, actualFieldValidator);
+
+       }
+
+       @Test
+       public void createPortalAdminIfUserIsNullTest()
+       {
+               EPUser user = null;
+               Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(null);
+               String sbcid = "null";
+               assertNull(portalAdminController.createPortalAdmin(mockedRequest, sbcid, mockedResponse));
+
+       }
        
        @Test
        public void createPortalAdminIfUserIsSuperAdminTest()
@@ -188,5 +199,97 @@ public class PortalAdminControllerTest extends MockitoTestSuite{
                assertNull(portalAdminController.createPortalAdmin(mockedRequest, sbcid, mockedResponse));
 
        }
+       
+       @Test
+       public void deletePortalAdminTest()
+       {
+               EPUser user = mockUser.mockEPUser();
+               Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
+               List<PortalAdmin> expectedPortalAdminsList = new ArrayList<PortalAdmin>();
+               Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(true);
+           Mockito.when(portalAdminService.deletePortalAdmin(12L)).thenReturn(null);
+         FieldsValidator actualPortalAdminsList =  portalAdminController.deletePortalAdmin(mockedRequest, "test", mockedResponse);
+         assertNull(actualPortalAdminsList);
+
+       }
+
+       @Test
+       public void deletePortalAdminXSSTest()
+       {
+               EPUser user = mockUser.mockEPUser();
+               Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
+               Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(true);
+               FieldsValidator actualFieldValidator = portalAdminController.deletePortalAdmin(mockedRequest,"<img src=xss onerror=alert(1)>" , mockedResponse);
+               assertNull(actualFieldValidator);
+
+       }
+       
+       @Test
+       public void deletePortalAdminTest1()
+       {
+               EPUser user = mockUser.mockEPUser();
+               Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
+               String sbcid = "Test";
+               List<PortalAdmin> expectedPortalAdminsList = new ArrayList<PortalAdmin>();
+               Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(false);
+           Mockito.when(portalAdminService.deletePortalAdmin(112L)).thenReturn(null);
+         FieldsValidator actualPortalAdminsList =  portalAdminController.deletePortalAdmin(mockedRequest, "112-1", mockedResponse);
+         assertNull(actualPortalAdminsList);
+
+       }
+       
+       @Test
+       public void deletePortalAdminTest2()
+       {
+               EPUser user = mockUser.mockEPUser();
+               Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
+       
+               FieldsValidator expectedFieldValidator = new FieldsValidator();
+               expectedFieldValidator.setHttpStatusCode((long) 200);
+               expectedFieldValidator.setFields(null);
+               expectedFieldValidator.setErrorCode(null);
+               FieldsValidator actualFieldValidator = new FieldsValidator();
+               //String sbcid = "Test";
+               Long userId=123L;
+               Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(true);
+               Mockito.when(portalAdminService.deletePortalAdmin(userId)).thenReturn(expectedFieldValidator);
+               actualFieldValidator = portalAdminController.deletePortalAdmin(mockedRequest,"123-Test" , mockedResponse);
+        assertEquals(actualFieldValidator,expectedFieldValidator);
+
+       }
+
+       @Test
+       public void getRolesByAppsTest()
+       {
+               EPUser user = mockUser.mockEPUser();
+               Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
+               List<EPRole> expectedgetAppsList = new ArrayList<EPRole>();
+               EPRole epRole= new EPRole();
+               epRole.setName("Test");
+               epRole.setActive(true);
+               epRole.setPriority(1);
+               epRole.setAppId(12L);
+               epRole.setId(1111L);
+               expectedgetAppsList.add(epRole);
+               Mockito.when(adminRolesService.getRolesByApp(user,12L)).thenReturn(expectedgetAppsList);
+               //Mockito.when(portalAdminService.deletePortalAdmin(userId)).thenReturn(expectedFieldValidator);
+               List<EPRole> actualgetAppsList = portalAdminController.getRolesByApp(mockedRequest,12L , mockedResponse);
+        assertEquals(actualgetAppsList,expectedgetAppsList);
+
+       }
+
+       @Test
+       public void getRolesByAppsWhenUserIsNullTest()
+       {
+               EPUser user = mockUser.mockEPUser();
+               Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(null);
+               List<EPRole> expectedgetAppsList = new ArrayList<EPRole>();
+               EPRole epRole= new EPRole();
+               expectedgetAppsList.add(epRole);
+               Mockito.when(adminRolesService.getRolesByApp(user,12L)).thenReturn(expectedgetAppsList);
+               List<EPRole> actualgetAppsList = portalAdminController.getRolesByApp(mockedRequest,12L , mockedResponse);
+        assertNull(actualgetAppsList);
+
+       }
                        
 }