Fix Sonar Bugs NullPointers

[portal.git] / ecomp-portal-BE-common / src / test / java / org / onap / portalapp / portal / controller / AppsControllerTest.java

diff --git a/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/controller/AppsControllerTest.java b/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/controller/AppsControllerTest.java
index 95f1d22..59b5a8e 100644 (file)
--- a/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/controller/AppsControllerTest.java
+++ b/ecomp-portal-BE-common/src/test/java/org/onap/portalapp/portal/controller/AppsControllerTest.java
@@ -4,6 +4,8 @@
  * ===================================================================
  * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
  * ===================================================================
+ * Modifications Copyright (c) 2019 Samsung
+ * ===================================================================
  *
  * Unless otherwise specified, all software contained herein is licensed
  * under the Apache License, Version 2.0 (the "License");
@@ -33,7 +35,7 @@
  *
  * ============LICENSE_END============================================
  *
- * ECOMP is a trademark and service mark of AT&T Intellectual Property.
+ * 
  */
 package org.onap.portalapp.portal.controller;
 
@@ -80,6 +82,7 @@ import org.onap.portalapp.portal.transport.EPWidgetsSortPreference;
 import org.onap.portalapp.portal.transport.FieldsValidator;
 import org.onap.portalapp.portal.transport.LocalRole;
 import org.onap.portalapp.portal.transport.OnboardingApp;
+import org.onap.portalapp.portal.utils.EcompPortalUtils;
 import org.onap.portalapp.util.EPUserUtils;
 import org.onap.portalsdk.core.util.SystemProperties;
 import org.onap.portalsdk.core.web.support.AppUtils;
@@ -732,6 +735,7 @@ public class AppsControllerTest extends MockitoTestSuite{
                expectedFieldValidator.setErrorCode(null);
                Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(true);
                Mockito.when(appService.modifyOnboardingApp(OnboardingApp, user)).thenReturn(expectedFieldValidator);
+               Mockito.when(mockedResponse.getStatus()).thenReturn(200);
                FieldsValidator actualFieldValidator = appsController.putOnboardingApp(mockedRequest, OnboardingApp,
                                mockedResponse);
                assertEquals(expectedFieldValidator, actualFieldValidator);
@@ -757,6 +761,13 @@ public class AppsControllerTest extends MockitoTestSuite{
                Mockito.when(appService.modifyOnboardingApp(OnboardingApp, user)).thenThrow(nullPointerException);
                assertNull(appsController.putOnboardingApp(mockedRequest, OnboardingApp, mockedResponse));
        }
+
+    @Test
+    public void putOnboardingAppNullUserTest() {
+        Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenThrow(nullPointerException);
+        Mockito.when(mockedResponse.getStatus()).thenReturn(200);
+        assertNull(appsController.putOnboardingApp(mockedRequest, new OnboardingApp(), mockedResponse));
+    }
        
        @Test
        public void postOnboardingAppTest() {
@@ -952,4 +963,56 @@ public class AppsControllerTest extends MockitoTestSuite{
                assertEquals(listOfActualApps.size(), 1);
        }
        
+       @Test
+       public void getSingleAppInfoWithExceptionTest (){
+               EPApp epApp=new EPApp();
+               epApp.setName("test");
+               epApp.setId(1L);
+               //EPApp listOfApps = new ArrayList<EcompApp>();
+               
+               //EcompApp app = new EcompApp();
+               //listOfApps.add(app);
+               EPUser user = mockUser.mockEPUser();
+               String appName="test";
+               Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
+               Mockito.when(mockedRequest.getParameter("mparams")).thenReturn("M");
+               Mockito.when(appService.getAppDetailByAppName(appName)).thenReturn(epApp);
+               EPApp listOfActualApps =        appsController.getSingleAppInfo(mockedRequest, mockedResponse);
+               //assertEquals(listOfActualApps,epApp);
+               assertNull(listOfActualApps);
+       }
+       
+       @Test
+       public void getSingleAppInfoTest (){
+               EPApp epApp=new EPApp();
+               epApp.setName("test");
+               epApp.setId(1L);
+               EPUser user = mockUser.mockEPUser();
+               Mockito.when(mockedRequest.getParameter("appParam")).thenReturn("test");
+               Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
+               Mockito.when(mockedRequest.getParameter("mparams")).thenReturn("M");
+               Mockito.when(appService.getAppDetailByAppName("test")).thenReturn(epApp);
+               Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(true);
+
+               EPApp listOfActualApps =        appsController.getSingleAppInfo(mockedRequest, mockedResponse);
+               //assertEquals(listOfActualApps,epApp);
+               assertEquals(listOfActualApps,epApp);
+       }
+       
+       
+       @Test
+       public void getSingleAppInfoByIdTest(){
+               EPApp epApp=new EPApp();
+               epApp.setName("test");
+               epApp.setId(1L);
+               EPUser user = mockUser.mockEPUser();
+               Mockito.when(mockedRequest.getParameter("appParam")).thenReturn("123");
+               Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
+               Mockito.when(mockedRequest.getParameter("mparams")).thenReturn("M");
+               Mockito.when(appService.getApp(123L)).thenReturn(epApp);
+               Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(true);
+               EPApp listOfActualApps =        appsController.getSingleAppInfoById(mockedRequest, mockedResponse);
+               assertEquals(listOfActualApps,epApp);
+       }
+       
 }