import javax.servlet.http.HttpServletRequest;\r
import javax.servlet.http.HttpServletResponse;\r
\r
+import org.apache.log4j.Logger;\r
import org.onap.dmaap.datarouter.provisioning.beans.DeliveryRecord;\r
import org.onap.dmaap.datarouter.provisioning.beans.EventLogRecord;\r
import org.onap.dmaap.datarouter.provisioning.beans.ExpiryRecord;\r
public class LogServlet extends BaseServlet {\r
//Adding EELF Logger Rally:US664892\r
private static EELFLogger eelflogger = EELFManager.getInstance().getLogger("org.onap.dmaap.datarouter.provisioning.LogServlet");\r
-\r
private static final long TWENTYFOUR_HOURS = (24 * 60 * 60 * 1000L);\r
private static final String fmt1 = "yyyy-MM-dd'T'HH:mm:ss'Z'";\r
private static final String fmt2 = "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'";\r
\r
- private boolean isfeedlog;\r
+ private static boolean isfeedlog;\r
\r
public abstract class RowHandler {\r
private final ServletOutputStream out;\r
private final String[] fields;\r
- public boolean firstrow;\r
+ private boolean firstrow;\r
\r
public RowHandler(ServletOutputStream out, String fieldparam, boolean b) {\r
this.out = out;\r
t += jo.toString();\r
out.print(t);\r
firstrow = false;\r
- } catch (Exception e) {\r
- // ignore\r
+ } catch (Exception exception) {\r
+ intlogger.info("Failed to handle row. Exception = " + exception.getMessage(),exception);\r
}\r
}\r
public abstract LOGJSONable buildJSONable(ResultSet rs) throws SQLException;\r
SimpleDateFormat sdf = new SimpleDateFormat(fmt);\r
Date d = sdf.parse(s);\r
return d.getTime();\r
- } catch (ParseException e) {\r
+ } catch (ParseException parseException) {\r
+ intlogger.error("Exception in getting Time :- "+parseException.getMessage(),parseException);\r
}\r
try {\r
// Also allow a long (in ms); useful for testing\r
long n = Long.parseLong(s);\r
return n;\r
- } catch (NumberFormatException e) {\r
+ } catch (NumberFormatException numberFormatException) {\r
+ intlogger.error("Exception in getting Time :- "+numberFormatException.getMessage(),numberFormatException);\r
}\r
intlogger.info("Error parsing time="+s);\r
return -1;\r
Connection conn = null;\r
try {\r
conn = db.getConnection();\r
- Statement stmt = conn.createStatement();\r
- ResultSet rs = stmt.executeQuery(sql);\r
- while (rs.next()) {\r
- rh.handleRow(rs);\r
- }\r
- rs.close();\r
- stmt.close();\r
- } catch (SQLException e) {\r
- e.printStackTrace();\r
+ try( Statement stmt = conn.createStatement()){\r
+ try(ResultSet rs = stmt.executeQuery(sql)){\r
+ while (rs.next()) {\r
+ rh.handleRow(rs);\r
+ }\r
+ }\r
+ }\r
+ } catch (SQLException sqlException) {\r
+ intlogger.info("Failed to get Records. Exception = " +sqlException.getMessage(),sqlException);\r
} finally {\r
if (conn != null)\r
db.release(conn);\r