[OOM-K8S-CERT-EXTERNAL-PROVIDER] Mock implementaion enhanced (part III)

[oom/platform/cert-service.git] / certServiceK8sExternalProvider / src / cmpv2controller / certificate_request_controller_test.go

diff --git a/certServiceK8sExternalProvider/src/cmpv2controller/certificate_request_controller_test.go b/certServiceK8sExternalProvider/src/cmpv2controller/certificate_request_controller_test.go
index 36cfbc4..7e55f36 100644 (file)
--- a/certServiceK8sExternalProvider/src/cmpv2controller/certificate_request_controller_test.go
+++ b/certServiceK8sExternalProvider/src/cmpv2controller/certificate_request_controller_test.go
@@ -1,35 +1,54 @@
+/*
+ * ============LICENSE_START=======================================================
+ * oom-certservice-k8s-external-provider
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+
 package cmpv2controller
 
 import (
        cmapi "github.com/jetstack/cert-manager/pkg/apis/certmanager/v1"
        "testing"
+       "github.com/stretchr/testify/assert"
+
 )
 
-func TestIsCMPv2CertificateRequest_notCMPv2Request(t *testing.T) {
+const group = "certmanager.onap.org"
+
+func Test_shouldBeInvalidCMPv2CertificateRequest_whenEmpty(t *testing.T) {
        request := new(cmapi.CertificateRequest)
-       if isCMPv2CertificateRequest(request) {
-               t.Logf("CPMv2 request [NOK]")
-               t.FailNow()
-       }
 
-       request.Spec.IssuerRef.Group = "certmanager.onap.org"
+       assert.False(t, isCMPv2CertificateRequest(request))
+}
+
+func Test_shouldBeInvalidCMPv2CertificateRequest_whenKindIsCertificateRequest(t *testing.T) {
+       request := new(cmapi.CertificateRequest)
+       request.Spec.IssuerRef.Group = group
        request.Spec.IssuerRef.Kind = "CertificateRequest"
-       if isCMPv2CertificateRequest(request) {
-               t.Logf("CPMv2 request [NOK]")
-               t.FailNow()
-       }
+
+       assert.False(t, isCMPv2CertificateRequest(request))
 }
 
-func TestIsCMPv2CertificateRequest_CMPvRequest(t *testing.T) {
+
+func Test_shouldBeValidCMPv2CertificateRequest_whenKindIsCMPvIssuer(t *testing.T) {
        request := new(cmapi.CertificateRequest)
-       request.Spec.IssuerRef.Group = "certmanager.onap.org"
+       request.Spec.IssuerRef.Group = group
        request.Spec.IssuerRef.Kind = "CMPv2Issuer"
 
-       if isCMPv2CertificateRequest(request) {
-               t.Logf("CPMv2 request [OK]")
-       } else {
-               t.Logf("Not a CPMv2 request [NOK]")
-               t.FailNow()
-       }
+       assert.True(t, isCMPv2CertificateRequest(request))
 }