[OOM-K8S-CERT-EXTERNAL-PROVIDER] Add API exceptions handling

[oom/platform/cert-service.git] / certServiceK8sExternalProvider / src / certserviceclient / cert_service_client_test.go

diff --git a/certServiceK8sExternalProvider/src/certserviceclient/cert_service_client_test.go b/certServiceK8sExternalProvider/src/certserviceclient/cert_service_client_test.go
index 06fc479..f2b5032 100644 (file)
--- a/certServiceK8sExternalProvider/src/certserviceclient/cert_service_client_test.go
+++ b/certServiceK8sExternalProvider/src/certserviceclient/cert_service_client_test.go
@@ -23,6 +23,7 @@ package certserviceclient
 import (
        "bytes"
        "fmt"
+       "io"
        "io/ioutil"
        "net/http"
        "testing"
@@ -42,14 +43,7 @@ func Test_GetCertificates_shouldParseCertificateResponseCorrectly(t *testing.T)
        responseJsonReader := ioutil.NopCloser(bytes.NewReader([]byte(responseJson)))
        client := CertServiceClientImpl{
                certificationUrl: certificationUrl,
-               httpClient:       &httpClientMock{
-                       DoFunc: func(req *http.Request) (response *http.Response, e error) {
-                               mockedResponse := &http.Response{
-                                       Body: responseJsonReader,
-                               }
-                               return mockedResponse, nil
-                       },
-               },
+               httpClient:       getMockedClient(responseJsonReader, http.StatusOK),
        }
        response, _ := client.GetCertificates(testdata.CsrBytes, testdata.PkBytes)
        assert.ElementsMatch(t, []string{"cert-0", "cert-1"}, response.CertificateChain)
@@ -91,6 +85,19 @@ func Test_GetCertificates_shouldReturnError_whenHttpClientReturnsError(t *testin
        assert.Error(t, err)
 }
 
+func Test_GetCertificates_shouldReturnError_whenResponseOtherThan200(t *testing.T) {
+       responseJson := `{"errorMessage": "CertService API error"}`
+       responseJsonReader := ioutil.NopCloser(bytes.NewReader([]byte(responseJson)))
+       client := CertServiceClientImpl{
+               certificationUrl: certificationUrl,
+               httpClient:       getMockedClient(responseJsonReader, http.StatusNotFound),
+       }
+       response, err := client.GetCertificates(testdata.CsrBytes, testdata.PkBytes)
+
+       assert.Nil(t, response)
+       assert.Error(t, err)
+}
+
 func Test_CheckHealth_shouldReturnNil_whenHttpClientReturnsStatusCode200(t *testing.T) {
        client := CertServiceClientImpl{
                certificationUrl: certificationUrl,
@@ -143,6 +150,18 @@ func Test_CheckHealth_shouldReturnError_whenHttpClientReturnsError(t *testing.T)
        assert.Error(t, err)
 }
 
+func getMockedClient(responseJsonReader io.ReadCloser, responseCode int) *httpClientMock {
+       return &httpClientMock{
+               DoFunc: func(req *http.Request) (response *http.Response, e error) {
+                       mockedResponse := &http.Response{
+                               Body:       responseJsonReader,
+                               StatusCode: responseCode,
+                       }
+                       return mockedResponse, nil
+               },
+       }
+}
+
 type httpClientMock struct {
        DoFunc func(*http.Request) (*http.Response, error)
 }