Reformat catalog-model
[sdc.git] / catalog-model / src / main / java / org / openecomp / sdc / be / model / operations / impl / HeatParametersOperation.java
index 823c33a..88383e5 100644 (file)
@@ -7,9 +7,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * limitations under the License.
  * ============LICENSE_END=========================================================
  */
-
 package org.openecomp.sdc.be.model.operations.impl;
 
 import fj.data.Either;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
 import org.apache.commons.lang3.tuple.ImmutablePair;
 import org.apache.tinkerpop.gremlin.structure.Edge;
 import org.openecomp.sdc.be.dao.graph.datatype.GraphEdge;
@@ -42,18 +45,11 @@ import org.openecomp.sdc.be.resources.data.UniqueIdData;
 import org.openecomp.sdc.common.log.wrappers.Logger;
 import org.springframework.stereotype.Component;
 
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-
 @Component("heat-parameter-operation")
 public class HeatParametersOperation implements IHeatParametersOperation {
 
     public static final String EMPTY_VALUE = null;
-
     private static final Logger log = Logger.getLogger(HeatParametersOperation.class.getName());
-
     @javax.annotation.Resource
     private JanusGraphGenericDao janusGraphGenericDao;
 
@@ -66,11 +62,9 @@ public class HeatParametersOperation implements IHeatParametersOperation {
     }
 
     public StorageOperationStatus getHeatParametersOfNode(NodeTypeEnum nodeType, String uniqueId, List<HeatParameterDefinition> properties) {
-
         Either<List<ImmutablePair<HeatParameterData, GraphEdge>>, JanusGraphOperationStatus> childrenNodes = janusGraphGenericDao
             .getChildrenNodes(UniqueIdBuilder.getKeyByNodeType(nodeType), uniqueId, GraphEdgeLabels.HEAT_PARAMETER, NodeTypeEnum.HeatParameter,
                 HeatParameterData.class);
-
         if (childrenNodes.isRight()) {
             JanusGraphOperationStatus status = childrenNodes.right().value();
             if (status == JanusGraphOperationStatus.NOT_FOUND) {
@@ -78,36 +72,30 @@ public class HeatParametersOperation implements IHeatParametersOperation {
             }
             return DaoStatusConverter.convertJanusGraphStatusToStorageStatus(status);
         }
-
         List<ImmutablePair<HeatParameterData, GraphEdge>> values = childrenNodes.left().value();
         if (values != null) {
-
             for (ImmutablePair<HeatParameterData, GraphEdge> immutablePair : values) {
                 GraphEdge edge = immutablePair.getValue();
                 String propertyName = (String) edge.getProperties().get(GraphPropertiesDictionary.NAME.getProperty());
-                if (log.isDebugEnabled())
+                if (log.isDebugEnabled()) {
                     log.debug("Property {} is associated to node {}", propertyName, uniqueId);
+                }
                 HeatParameterData propertyData = immutablePair.getKey();
                 HeatParameterDefinition propertyDefinition = convertParameterDataToParameterDefinition(propertyData, propertyName, uniqueId);
-
                 properties.add(propertyDefinition);
-
                 if (log.isTraceEnabled()) {
                     log.trace("getHeatParametersOfNode - property {} associated to node {}", propertyDefinition, uniqueId);
                 }
             }
-
         }
-
         return StorageOperationStatus.OK;
     }
 
-    public StorageOperationStatus getParametersValueNodes(NodeTypeEnum parentNodeType, String parentUniqueId, List<HeatParameterValueData> heatValues) {
-
+    public StorageOperationStatus getParametersValueNodes(NodeTypeEnum parentNodeType, String parentUniqueId,
+                                                          List<HeatParameterValueData> heatValues) {
         Either<List<ImmutablePair<HeatParameterValueData, GraphEdge>>, JanusGraphOperationStatus> childrenNodes = janusGraphGenericDao
             .getChildrenNodes(UniqueIdBuilder.getKeyByNodeType(parentNodeType), parentUniqueId, GraphEdgeLabels.PARAMETER_VALUE,
                 NodeTypeEnum.HeatParameterValue, HeatParameterValueData.class);
-
         if (childrenNodes.isRight()) {
             JanusGraphOperationStatus status = childrenNodes.right().value();
             if (status == JanusGraphOperationStatus.NOT_FOUND) {
@@ -115,36 +103,28 @@ public class HeatParametersOperation implements IHeatParametersOperation {
             }
             return DaoStatusConverter.convertJanusGraphStatusToStorageStatus(status);
         }
-
         List<ImmutablePair<HeatParameterValueData, GraphEdge>> values = childrenNodes.left().value();
         if (values != null) {
-
             for (ImmutablePair<HeatParameterValueData, GraphEdge> immutablePair : values) {
                 GraphEdge edge = immutablePair.getValue();
                 String propertyName = (String) edge.getProperties().get(GraphPropertiesDictionary.NAME.getProperty());
-                log.trace("Heat value {} is associated to node {}", propertyName,parentUniqueId);
+                log.trace("Heat value {} is associated to node {}", propertyName, parentUniqueId);
                 HeatParameterValueData propertyData = immutablePair.getKey();
-
                 heatValues.add(propertyData);
             }
-
         }
-
         return StorageOperationStatus.OK;
     }
 
     @Override
-    public Either<List<HeatParameterDefinition>, StorageOperationStatus> deleteAllHeatParametersAssociatedToNode(NodeTypeEnum nodeType, String uniqueId) {
-
+    public Either<List<HeatParameterDefinition>, StorageOperationStatus> deleteAllHeatParametersAssociatedToNode(NodeTypeEnum nodeType,
+                                                                                                                 String uniqueId) {
         List<HeatParameterDefinition> heatParams = new ArrayList<>();
         StorageOperationStatus propertiesOfNodeRes = getHeatParametersOfNode(nodeType, uniqueId, heatParams);
-
         if (!propertiesOfNodeRes.equals(StorageOperationStatus.OK) && !propertiesOfNodeRes.equals(StorageOperationStatus.NOT_FOUND)) {
             return Either.right(propertiesOfNodeRes);
         }
-
         for (HeatParameterDefinition propertyDefinition : heatParams) {
-
             String propertyUid = propertyDefinition.getUniqueId();
             Either<HeatParameterData, JanusGraphOperationStatus> deletePropertyRes = deleteHeatParameterFromGraph(propertyUid);
             if (deletePropertyRes.isRight()) {
@@ -155,25 +135,19 @@ public class HeatParametersOperation implements IHeatParametersOperation {
                 }
                 return Either.right(DaoStatusConverter.convertJanusGraphStatusToStorageStatus(status));
             }
-
         }
-
         log.debug("The heat parameters deleted from node {} are {}", uniqueId, heatParams);
         return Either.left(heatParams);
     }
 
     @Override
     public StorageOperationStatus deleteAllHeatValuesAssociatedToNode(NodeTypeEnum parentNodeType, String parentUniqueId) {
-
         List<HeatParameterValueData> heatValues = new ArrayList<>();
         StorageOperationStatus propertiesOfNodeRes = getParametersValueNodes(parentNodeType, parentUniqueId, heatValues);
-
         if (!propertiesOfNodeRes.equals(StorageOperationStatus.OK) && !propertiesOfNodeRes.equals(StorageOperationStatus.NOT_FOUND)) {
             return propertiesOfNodeRes;
         }
-
         for (HeatParameterValueData propertyDefinition : heatValues) {
-
             String propertyUid = (String) propertyDefinition.getUniqueId();
             Either<HeatParameterValueData, JanusGraphOperationStatus> deletePropertyRes = deleteHeatParameterValueFromGraph(propertyUid);
             if (deletePropertyRes.isRight()) {
@@ -184,52 +158,43 @@ public class HeatParametersOperation implements IHeatParametersOperation {
                 }
                 return DaoStatusConverter.convertJanusGraphStatusToStorageStatus(status);
             }
-
         }
-
-        log.debug("The heat values deleted from node {} are {}" , parentUniqueId, heatValues);
+        log.debug("The heat values deleted from node {} are {}", parentUniqueId, heatValues);
         return StorageOperationStatus.OK;
     }
 
     private Either<HeatParameterData, JanusGraphOperationStatus> deleteHeatParameterFromGraph(String propertyId) {
-        log.debug("Before deleting heat parameter from graph {}" , propertyId);
-        return janusGraphGenericDao
-            .deleteNode(UniqueIdBuilder.getKeyByNodeType(NodeTypeEnum.HeatParameter), propertyId, HeatParameterData.class);
+        log.debug("Before deleting heat parameter from graph {}", propertyId);
+        return janusGraphGenericDao.deleteNode(UniqueIdBuilder.getKeyByNodeType(NodeTypeEnum.HeatParameter), propertyId, HeatParameterData.class);
     }
 
     private Either<HeatParameterValueData, JanusGraphOperationStatus> deleteHeatParameterValueFromGraph(String propertyId) {
-        log.debug("Before deleting heat parameter from graph {}" , propertyId);
-        return janusGraphGenericDao.deleteNode(UniqueIdBuilder.getKeyByNodeType(NodeTypeEnum.HeatParameterValue), propertyId, HeatParameterValueData.class);
+        log.debug("Before deleting heat parameter from graph {}", propertyId);
+        return janusGraphGenericDao
+            .deleteNode(UniqueIdBuilder.getKeyByNodeType(NodeTypeEnum.HeatParameterValue), propertyId, HeatParameterValueData.class);
     }
 
     @Override
     public StorageOperationStatus addPropertiesToGraph(List<HeatParameterDefinition> properties, String parentId, NodeTypeEnum nodeType) {
-
         if (properties != null) {
             for (HeatParameterDefinition propertyDefinition : properties) {
-
                 String propertyName = propertyDefinition.getName();
-
-                Either<HeatParameterData, JanusGraphOperationStatus> addPropertyToGraph = addPropertyToGraph(propertyName, propertyDefinition, parentId, nodeType);
-
+                Either<HeatParameterData, JanusGraphOperationStatus> addPropertyToGraph = addPropertyToGraph(propertyName, propertyDefinition,
+                    parentId, nodeType);
                 if (addPropertyToGraph.isRight()) {
                     return DaoStatusConverter.convertJanusGraphStatusToStorageStatus(addPropertyToGraph.right().value());
                 }
             }
         }
-
         return StorageOperationStatus.OK;
-
     }
 
     @Override
     public StorageOperationStatus updateHeatParameters(List<HeatParameterDefinition> properties) {
-
         if (properties == null) {
             return StorageOperationStatus.OK;
         }
         for (HeatParameterDefinition property : properties) {
-
             HeatParameterData heatParameterData = new HeatParameterData(property);
             Either<HeatParameterData, JanusGraphOperationStatus> updateNode = janusGraphGenericDao
                 .updateNode(heatParameterData, HeatParameterData.class);
@@ -238,57 +203,46 @@ public class HeatParametersOperation implements IHeatParametersOperation {
                 return DaoStatusConverter.convertJanusGraphStatusToStorageStatus(updateNode.right().value());
             }
         }
-
         return StorageOperationStatus.OK;
     }
 
-    public Either<HeatParameterData, JanusGraphOperationStatus> addPropertyToGraph(String propertyName, HeatParameterDefinition propertyDefinition, String parentId, NodeTypeEnum nodeType) {
-
+    public Either<HeatParameterData, JanusGraphOperationStatus> addPropertyToGraph(String propertyName, HeatParameterDefinition propertyDefinition,
+                                                                                   String parentId, NodeTypeEnum nodeType) {
         UniqueIdData parentNode = new UniqueIdData(nodeType, parentId);
-
         propertyDefinition.setUniqueId(UniqueIdBuilder.buildHeatParameterUniqueId(parentId, propertyName));
         HeatParameterData propertyData = new HeatParameterData(propertyDefinition);
-
-        log.debug("Before adding property to graph {}" , propertyData);
+        log.debug("Before adding property to graph {}", propertyData);
         Either<HeatParameterData, JanusGraphOperationStatus> createNodeResult = janusGraphGenericDao
             .createNode(propertyData, HeatParameterData.class);
-        log.debug("After adding property to graph {}" , propertyData);
+        log.debug("After adding property to graph {}", propertyData);
         if (createNodeResult.isRight()) {
             JanusGraphOperationStatus operationStatus = createNodeResult.right().value();
             log.error("Failed to add property {} to graph. status is {}", propertyName, operationStatus);
             return Either.right(operationStatus);
         }
-
         Map<String, Object> props = new HashMap<>();
         props.put(GraphPropertiesDictionary.NAME.getProperty(), propertyName);
         Either<GraphRelation, JanusGraphOperationStatus> createRelResult = janusGraphGenericDao
             .createRelation(parentNode, propertyData, GraphEdgeLabels.HEAT_PARAMETER, props);
         if (createRelResult.isRight()) {
             JanusGraphOperationStatus operationStatus = createRelResult.right().value();
-            log.error("Failed to associate {} {} to heat parameter {} in graph. status is {}", nodeType.getName(), parentId, propertyName, operationStatus);
+            log.error("Failed to associate {} {} to heat parameter {} in graph. status is {}", nodeType.getName(), parentId, propertyName,
+                operationStatus);
             return Either.right(operationStatus);
         }
-
         return Either.left(createNodeResult.left().value());
-
     }
 
     public StorageOperationStatus validateAndUpdateProperty(HeatParameterDefinition propertyDefinition) {
-
-        log.trace("Going to validate property type and value. {}" , propertyDefinition);
-
+        log.trace("Going to validate property type and value. {}", propertyDefinition);
         String propertyType = propertyDefinition.getType();
         HeatParameterType type = getType(propertyType);
-
         if (type == null) {
             log.info("The type {} of heat parameter is invalid", type);
-
             return StorageOperationStatus.INVALID_TYPE;
         }
         propertyDefinition.setType(type.getType());
-
         log.trace("After validating property type {}", propertyType);
-
         // validate default value
         String defaultValue = propertyDefinition.getDefaultValue();
         boolean isValidProperty = isValidValue(type, defaultValue);
@@ -296,18 +250,14 @@ public class HeatParametersOperation implements IHeatParametersOperation {
             log.info("The value {} of property from type {} is invalid", defaultValue, type);
             return StorageOperationStatus.INVALID_VALUE;
         }
-
         PropertyValueConverter converter = type.getConverter();
-
         if (isEmptyValue(defaultValue)) {
-            log.debug("Default value was not sent for property {}. Set default value to {}", propertyDefinition.getName() , EMPTY_VALUE);
-
+            log.debug("Default value was not sent for property {}. Set default value to {}", propertyDefinition.getName(), EMPTY_VALUE);
             propertyDefinition.setDefaultValue(EMPTY_VALUE);
         } else if (!isEmptyValue(defaultValue)) {
             String convertedValue = converter.convert(defaultValue, null, null);
             propertyDefinition.setDefaultValue(convertedValue);
         }
-
         // validate current value
         String value = propertyDefinition.getCurrentValue();
         isValidProperty = isValidValue(type, value);
@@ -315,49 +265,39 @@ public class HeatParametersOperation implements IHeatParametersOperation {
             log.info("The value {} of property from type {} is invalid", value, type);
             return StorageOperationStatus.INVALID_VALUE;
         }
-
         if (isEmptyValue(value)) {
             log.debug("Value was not sent for property {}. Set value to {}", propertyDefinition.getName(), EMPTY_VALUE);
-
             propertyDefinition.setCurrentValue(EMPTY_VALUE);
         } else if (!value.equals("")) {
             String convertedValue = converter.convert(value, null, null);
             propertyDefinition.setCurrentValue(convertedValue);
         }
-
         return StorageOperationStatus.OK;
     }
 
-    public HeatParameterDefinition convertParameterDataToParameterDefinition(HeatParameterData propertyDataResult, String propertyName, String resourceId) {
+    public HeatParameterDefinition convertParameterDataToParameterDefinition(HeatParameterData propertyDataResult, String propertyName,
+                                                                             String resourceId) {
         log.debug("convert to HeatParamereDefinition {}", propertyDataResult);
-
         HeatParameterDefinition propertyDefResult = new HeatParameterDefinition(propertyDataResult.getHeatDataDefinition());
-
         propertyDefResult.setName(propertyName);
-
         return propertyDefResult;
     }
 
     private HeatParameterType getType(String propertyType) {
-
         return HeatParameterType.isValidType(propertyType);
-
     }
 
     protected boolean isValidValue(HeatParameterType type, String value) {
         if (isEmptyValue(value)) {
             return true;
         }
-
         PropertyTypeValidator validator = type.getValidator();
-
         boolean isValid = validator.isValid(value, null, null);
         if (isValid) {
             return true;
         } else {
             return false;
         }
-
     }
 
     public boolean isEmptyValue(String value) {
@@ -375,13 +315,16 @@ public class HeatParametersOperation implements IHeatParametersOperation {
     }
 
     @Override
-    public Either<HeatParameterValueData, StorageOperationStatus> updateHeatParameterValue(HeatParameterDefinition heatParam, String artifactId, String resourceInstanceId, String artifactLabel) {
+    public Either<HeatParameterValueData, StorageOperationStatus> updateHeatParameterValue(HeatParameterDefinition heatParam, String artifactId,
+                                                                                           String resourceInstanceId, String artifactLabel) {
         String heatEnvId = UniqueIdBuilder.buildHeatParameterValueUniqueId(resourceInstanceId, artifactLabel, heatParam.getName());
         Either<HeatParameterValueData, JanusGraphOperationStatus> getNode = janusGraphGenericDao
             .getNode(GraphPropertiesDictionary.UNIQUE_ID.getProperty(), heatEnvId, HeatParameterValueData.class);
         if (getNode.isRight() || getNode.left().value() == null) {
-            if (heatParam.getCurrentValue() == null || (heatParam.getDefaultValue() != null && heatParam.getCurrentValue().equals(heatParam.getDefaultValue()))) {
-                log.debug("Updated heat parameter value equals default value. No need to create heat parameter value for heat parameter {}", heatParam.getUniqueId());
+            if (heatParam.getCurrentValue() == null || (heatParam.getDefaultValue() != null && heatParam.getCurrentValue()
+                .equals(heatParam.getDefaultValue()))) {
+                log.debug("Updated heat parameter value equals default value. No need to create heat parameter value for heat parameter {}",
+                    heatParam.getUniqueId());
                 return Either.left(null);
             }
             return createHeatParameterValue(heatParam, artifactId, resourceInstanceId, artifactLabel);
@@ -394,7 +337,8 @@ public class HeatParametersOperation implements IHeatParametersOperation {
     public Either<HeatParameterValueData, StorageOperationStatus> updateHeatParameterValue(HeatParameterDefinition heatParam) {
         HeatParameterValueData heatParameterValue = new HeatParameterValueData();
         heatParameterValue.setUniqueId(heatParam.getUniqueId());
-        if (heatParam.getCurrentValue() == null || (heatParam.getDefaultValue() != null && heatParam.getCurrentValue().equals(heatParam.getDefaultValue()))) {
+        if (heatParam.getCurrentValue() == null || (heatParam.getDefaultValue() != null && heatParam.getCurrentValue()
+            .equals(heatParam.getDefaultValue()))) {
             Either<GraphRelation, JanusGraphOperationStatus> deleteParameterValueIncomingRelation = janusGraphGenericDao
                 .deleteIncomingRelationByCriteria(heatParameterValue, GraphEdgeLabels.PARAMETER_VALUE, null);
             if (deleteParameterValueIncomingRelation.isRight()) {
@@ -402,7 +346,8 @@ public class HeatParametersOperation implements IHeatParametersOperation {
                 return Either.right(DaoStatusConverter.convertJanusGraphStatusToStorageStatus(deleteParameterValueIncomingRelation.right().value()));
             }
             Either<Edge, JanusGraphOperationStatus> getOutgoingRelation = janusGraphGenericDao
-                .getOutgoingEdgeByCriteria(GraphPropertiesDictionary.UNIQUE_ID.getProperty(), (String) heatParameterValue.getUniqueId(), GraphEdgeLabels.PARAMETER_IMPL, null);
+                .getOutgoingEdgeByCriteria(GraphPropertiesDictionary.UNIQUE_ID.getProperty(), (String) heatParameterValue.getUniqueId(),
+                    GraphEdgeLabels.PARAMETER_IMPL, null);
             if (getOutgoingRelation.isRight()) {
                 log.debug("Failed to get heat parameter value outgoing relation from graph. id = {}", heatParameterValue.getUniqueId());
                 return Either.right(DaoStatusConverter.convertJanusGraphStatusToStorageStatus(getOutgoingRelation.right().value()));
@@ -413,7 +358,6 @@ public class HeatParametersOperation implements IHeatParametersOperation {
                 return Either.right(StorageOperationStatus.GENERAL_ERROR);
             }
             edge.remove();
-
             Either<HeatParameterValueData, JanusGraphOperationStatus> deleteNode = janusGraphGenericDao
                 .deleteNode(heatParameterValue, HeatParameterValueData.class);
             if (deleteNode.isRight()) {
@@ -432,9 +376,10 @@ public class HeatParametersOperation implements IHeatParametersOperation {
         return Either.left(updateNode.left().value());
     }
 
-    public Either<HeatParameterValueData, StorageOperationStatus> createHeatParameterValue(HeatParameterDefinition heatParam, String artifactId, String resourceInstanceId, String artifactLabel) {
-
-        Either<HeatParameterValueData, JanusGraphOperationStatus> addHeatValueToGraph = addHeatValueToGraph(heatParam, artifactLabel, artifactId, resourceInstanceId);
+    public Either<HeatParameterValueData, StorageOperationStatus> createHeatParameterValue(HeatParameterDefinition heatParam, String artifactId,
+                                                                                           String resourceInstanceId, String artifactLabel) {
+        Either<HeatParameterValueData, JanusGraphOperationStatus> addHeatValueToGraph = addHeatValueToGraph(heatParam, artifactLabel, artifactId,
+            resourceInstanceId);
         if (addHeatValueToGraph.isRight()) {
             log.debug("Failed to create heat parameters value on graph for artifact {}", artifactId);
             return Either.right(DaoStatusConverter.convertJanusGraphStatusToStorageStatus(addHeatValueToGraph.right().value()));
@@ -442,13 +387,12 @@ public class HeatParametersOperation implements IHeatParametersOperation {
         return Either.left(addHeatValueToGraph.left().value());
     }
 
-    public Either<HeatParameterValueData, JanusGraphOperationStatus> addHeatValueToGraph(HeatParameterDefinition heatParameter, String artifactLabel, String artifactId, String resourceInstanceId) {
-
+    public Either<HeatParameterValueData, JanusGraphOperationStatus> addHeatValueToGraph(HeatParameterDefinition heatParameter, String artifactLabel,
+                                                                                         String artifactId, String resourceInstanceId) {
         UniqueIdData heatEnvNode = new UniqueIdData(NodeTypeEnum.ArtifactRef, artifactId);
         HeatParameterValueData heatValueData = new HeatParameterValueData();
         heatValueData.setUniqueId(UniqueIdBuilder.buildHeatParameterValueUniqueId(resourceInstanceId, artifactLabel, heatParameter.getName()));
         heatValueData.setValue(heatParameter.getCurrentValue());
-
         log.debug("Before adding property to graph {}", heatValueData);
         Either<HeatParameterValueData, JanusGraphOperationStatus> createNodeResult = janusGraphGenericDao
             .createNode(heatValueData, HeatParameterValueData.class);
@@ -458,14 +402,14 @@ public class HeatParametersOperation implements IHeatParametersOperation {
             log.error("Failed to add heat value {} to graph. status is {}", heatValueData.getUniqueId(), operationStatus);
             return Either.right(operationStatus);
         }
-
         Map<String, Object> props = new HashMap<>();
         props.put(GraphPropertiesDictionary.NAME.getProperty(), heatParameter.getName());
         Either<GraphRelation, JanusGraphOperationStatus> createRelResult = janusGraphGenericDao
             .createRelation(heatEnvNode, heatValueData, GraphEdgeLabels.PARAMETER_VALUE, props);
         if (createRelResult.isRight()) {
             JanusGraphOperationStatus operationStatus = createRelResult.right().value();
-            log.error("Failed to associate heat value {} to heat env artifact {} in graph. status is {}", heatValueData.getUniqueId(), artifactId, operationStatus);
+            log.error("Failed to associate heat value {} to heat env artifact {} in graph. status is {}", heatValueData.getUniqueId(), artifactId,
+                operationStatus);
             return Either.right(operationStatus);
         }
         UniqueIdData heatParameterNode = new UniqueIdData(NodeTypeEnum.HeatParameter, heatParameter.getUniqueId());
@@ -473,12 +417,10 @@ public class HeatParametersOperation implements IHeatParametersOperation {
             .createRelation(heatValueData, heatParameterNode, GraphEdgeLabels.PARAMETER_IMPL, null);
         if (createRel2Result.isRight()) {
             JanusGraphOperationStatus operationStatus = createRel2Result.right().value();
-            log.error("Failed to associate heat value {} to heat parameter {} in graph. status is {}", heatValueData.getUniqueId(), heatParameter.getName(), operationStatus);
+            log.error("Failed to associate heat value {} to heat parameter {} in graph. status is {}", heatValueData.getUniqueId(),
+                heatParameter.getName(), operationStatus);
             return Either.right(operationStatus);
         }
-
         return Either.left(createNodeResult.left().value());
-
     }
-
 }