Disable DMaaP if Kafka active

[sdc.git] / catalog-be / src / test / java / org / openecomp / sdc / be / components / path / ForwardingPathBusinessLogicTest.java

diff --git a/catalog-be/src/test/java/org/openecomp/sdc/be/components/path/ForwardingPathBusinessLogicTest.java b/catalog-be/src/test/java/org/openecomp/sdc/be/components/path/ForwardingPathBusinessLogicTest.java
index 5d3f829..2b4e90f 100644 (file)
--- a/catalog-be/src/test/java/org/openecomp/sdc/be/components/path/ForwardingPathBusinessLogicTest.java
+++ b/catalog-be/src/test/java/org/openecomp/sdc/be/components/path/ForwardingPathBusinessLogicTest.java
@@ -1,4 +1,3 @@
-
 /*
  * Copyright © 2016-2018 European Support Limited
  *
@@ -17,60 +16,72 @@
 
 package org.openecomp.sdc.be.components.path;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
 import com.google.common.collect.Lists;
 import com.google.common.collect.Sets;
 import fj.data.Either;
-import org.junit.Test;
-import org.junit.runner.RunWith;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Set;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+import org.openecomp.sdc.be.components.impl.exceptions.ComponentException;
+import org.openecomp.sdc.be.config.ConfigurationManager;
 import org.openecomp.sdc.be.datatypes.elements.ForwardingPathDataDefinition;
 import org.openecomp.sdc.be.datatypes.elements.ListDataDefinition;
 import org.openecomp.sdc.be.datatypes.enums.ComponentFieldsEnum;
 import org.openecomp.sdc.be.model.Service;
 import org.openecomp.sdc.be.ui.model.UiComponentDataTransfer;
 import org.openecomp.sdc.be.ui.model.UiServiceDataTransfer;
+import org.openecomp.sdc.common.impl.ExternalConfiguration;
+import org.openecomp.sdc.common.impl.FSConfigurationSource;
 import org.openecomp.sdc.exception.ResponseFormat;
-import org.springframework.test.context.ContextConfiguration;
-import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
-
-import java.util.HashMap;
-import java.util.Map;
-import java.util.Set;
+import org.springframework.test.context.junit.jupiter.SpringJUnitConfig;
 
-import static org.junit.Assert.*;
-
-@RunWith(SpringJUnit4ClassRunner.class)
-@ContextConfiguration(locations = "/paths/path-context.xml")
-public class ForwardingPathBusinessLogicTest extends BaseForwardingPathTest {
+@SpringJUnitConfig(locations = "classpath:paths/path-context.xml")
+class ForwardingPathBusinessLogicTest extends BaseForwardingPathTest {
 
+    @BeforeAll
+    static void setup() {
+        configurationManager =
+                new ConfigurationManager(new FSConfigurationSource(ExternalConfiguration.getChangeListener(), "src/test/resources/config/catalog-be"));
+    }
 
     @Test
-    public void shouldFailToUpdateForwardingPathSincePathDoesNotExist() {
-        Service service = initForwardPath();
-        Either<Service, ResponseFormat> serviceResponseFormatEither = bl.updateForwardingPath(FORWARDING_PATH_ID, service, user, true);
-        assertTrue(serviceResponseFormatEither.isRight());
+    void shouldFailToUpdateForwardingPathSincePathDoesNotExist() {
+        Assertions.assertThrows(ComponentException.class, () -> {
+            Service service = initForwardPath();
+            bl.updateForwardingPath(FORWARDING_PATH_ID, service, user, true);
+        });
     }
 
     @Test
-    public void shouldFailToDeleteForwardingPathSincePathDoesNotExist() {
-        Service service = initForwardPath();
-        Either<Set<String>, ResponseFormat> serviceResponseFormatEither = bl.deleteForwardingPaths("delete_forward_test", Sets.newHashSet(FORWARDING_PATH_ID), user, true);
-        assertTrue(serviceResponseFormatEither.isRight());
+    void shouldFailToDeleteForwardingPathSincePathDoesNotExist() {
+        Assertions.assertThrows(ComponentException.class, () -> {
+            initForwardPath();
+            bl.deleteForwardingPaths("delete_forward_test", Sets.newHashSet(FORWARDING_PATH_ID), user, true);
+        });
     }
 
     @Test
-    public void shouldSucceedCreateAndDeleteForwardingPath() {
+    void shouldSucceedCreateAndDeleteForwardingPath() {
         Service createdService = createService();
         Service service = initForwardPath();
         assertNotNull(service);
-        Either<Service, ResponseFormat> serviceResponseFormatEither = bl.createForwardingPath(createdService.getUniqueId(), service, user, true);
-        assertTrue(serviceResponseFormatEither.isLeft());
-        Map<String, ForwardingPathDataDefinition> forwardingPathsMap = serviceResponseFormatEither.left().value().getForwardingPaths();
+        Service serviceResponseFormatEither = bl.createForwardingPath(createdService.getUniqueId(), service, user, true);
+        assertTrue(serviceResponseFormatEither != null);
+        Map<String, ForwardingPathDataDefinition> forwardingPathsMap = serviceResponseFormatEither.getForwardingPaths();
         Set<String> pathIds = forwardingPathsMap.keySet();
         assertEquals(1, pathIds.size());
         String toscaResourceName = forwardingPathsMap.values().iterator().next().getToscaResourceName();
 
         // should return the created path
-        Either<UiComponentDataTransfer, ResponseFormat> uiResaponse = bl.getComponentDataFilteredByParams(createdService.getUniqueId(), user, Lists.newArrayList(ComponentFieldsEnum.FORWARDING_PATHS.getValue()));
+        Either<UiComponentDataTransfer, ResponseFormat> uiResaponse = bl.getComponentDataFilteredByParams(createdService.getUniqueId(), user,
+                Lists.newArrayList(ComponentFieldsEnum.FORWARDING_PATHS.getValue()));
         assertTrue(uiResaponse.isLeft());
         UiServiceDataTransfer uiServiceDataTransfer = (UiServiceDataTransfer) uiResaponse.left().value();
         Map<String, ForwardingPathDataDefinition> forwardingPaths = uiServiceDataTransfer.getForwardingPaths();
@@ -89,10 +100,11 @@ public class ForwardingPathBusinessLogicTest extends BaseForwardingPathTest {
         service.getForwardingPaths().clear();
         service.getForwardingPaths().put(forwardingPathDataDefinitionUpdate.getUniqueId(), forwardingPathDataDefinitionUpdate);
         serviceResponseFormatEither = bl.updateForwardingPath(createdService.getUniqueId(), service, user, true);
-        assertTrue(serviceResponseFormatEither.isLeft());
+        assertTrue(serviceResponseFormatEither != null);
 
         // make sure changes were applied
-        uiResaponse = bl.getComponentDataFilteredByParams(createdService.getUniqueId(), user, Lists.newArrayList(ComponentFieldsEnum.FORWARDING_PATHS.getValue()));
+        uiResaponse = bl.getComponentDataFilteredByParams(createdService.getUniqueId(), user,
+                Lists.newArrayList(ComponentFieldsEnum.FORWARDING_PATHS.getValue()));
         assertTrue(uiResaponse.isLeft());
         uiServiceDataTransfer = (UiServiceDataTransfer) uiResaponse.left().value();
         Map<String, ForwardingPathDataDefinition> forwardingPathsUpdated = uiServiceDataTransfer.getForwardingPaths();
@@ -100,13 +112,14 @@ public class ForwardingPathBusinessLogicTest extends BaseForwardingPathTest {
         assertEquals(newProtocol, updatedData.getProtocol());
         assertTrue(updatedData.getPathElements().isEmpty());
 
-        Service createdData = serviceResponseFormatEither.left().value();
+        Service createdData = serviceResponseFormatEither;
         Set<String> paths = createdData.getForwardingPaths().keySet();
-        Either<Set<String>, ResponseFormat> setResponseFormatEither = bl.deleteForwardingPaths(createdService.getUniqueId(), paths, user, true);
-        assertTrue(setResponseFormatEither.isLeft());
+        Set<String> setResponseFormatEither = bl.deleteForwardingPaths(createdService.getUniqueId(), paths, user, true);
+        assertTrue(setResponseFormatEither != null);
 
         // nothing to return now
-        uiResaponse = bl.getComponentDataFilteredByParams(createdService.getUniqueId(), user, Lists.newArrayList(ComponentFieldsEnum.COMPONENT_INSTANCES.getValue(),ComponentFieldsEnum.FORWARDING_PATHS.getValue()));
+        uiResaponse = bl.getComponentDataFilteredByParams(createdService.getUniqueId(), user,
+                Lists.newArrayList(ComponentFieldsEnum.COMPONENT_INSTANCES.getValue(), ComponentFieldsEnum.FORWARDING_PATHS.getValue()));
         assertTrue(uiResaponse.isLeft());
         uiServiceDataTransfer = (UiServiceDataTransfer) uiResaponse.left().value();
         forwardingPaths = uiServiceDataTransfer.getForwardingPaths();
@@ -114,8 +127,4 @@ public class ForwardingPathBusinessLogicTest extends BaseForwardingPathTest {
 
     }
 
-
-
-
 }
-