Sonar Fixes, Formatting

[aaf/authz.git] / cadi / aaf / src / main / java / org / onap / aaf / cadi / register / Registrar.java

diff --git a/cadi/aaf/src/main/java/org/onap/aaf/cadi/register/Registrar.java b/cadi/aaf/src/main/java/org/onap/aaf/cadi/register/Registrar.java
index 32ff810..4555171 100644 (file)
--- a/cadi/aaf/src/main/java/org/onap/aaf/cadi/register/Registrar.java
+++ b/cadi/aaf/src/main/java/org/onap/aaf/cadi/register/Registrar.java
@@ -7,9 +7,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -43,9 +43,9 @@ public class Registrar<ENV extends BasicEnv> {
 
         erroringTimer = null;
         timer = new Timer(REGISTRAR,true);
-        timer.schedule(new RegistrationTimerTask(env), START, INTERVAL); 
-        
-        if(shutdownHook) {
+        timer.schedule(new RegistrationTimerTask(env), START, INTERVAL);
+
+        if (shutdownHook) {
             Runtime.getRuntime().addShutdownHook(new Thread() {
                 public void run() {
                     close(env);
@@ -53,7 +53,7 @@ public class Registrar<ENV extends BasicEnv> {
             });
         }
     }
-    
+
     private class RegistrationTimerTask extends TimerTask {
         private final ENV env;
         public RegistrationTimerTask(ENV env) {
@@ -61,18 +61,19 @@ public class Registrar<ENV extends BasicEnv> {
         }
         @Override
         public void run() {
-            for(Iterator<Registrant<ENV>> iter = registrants.iterator(); iter.hasNext();) {
+            for (Iterator<Registrant<ENV>> iter = registrants.iterator(); iter.hasNext();) {
                 Registrant<ENV> reg = iter.next();
                 Result<Void> rv = reg.update(env);
                 synchronized(LOCK) {
-                    if(rv.isOK()) {
-                        if(erroringTimer!=null) {
+                    if (rv.isOK()) {
+                        if (erroringTimer!=null) {
                             erroringTimer.cancel();
                             erroringTimer = null;
                         }
                     } else {
+                        env.error().log(rv.toString());
                         // Account for different Registrations not being to same place
-                        if(erroringTimer==null) {
+                        if (erroringTimer==null) {
                             erroringTimer =  new Timer(REGISTRAR + " error re-check ",true);
                             erroringTimer.schedule(new RegistrationTimerTask(env),20000,20000);
                         }
@@ -81,11 +82,11 @@ public class Registrar<ENV extends BasicEnv> {
             }
         }
     }
-    
+
     public void register(Registrant<ENV> r) {
         registrants.addLast(r);
     }
-    
+
     public void deregister(Registrant<ENV> r) {
         registrants.remove(r);
     }
@@ -94,7 +95,7 @@ public class Registrar<ENV extends BasicEnv> {
         timer.cancel();
 
         Registrant<ENV> r;
-        while(registrants.peek()!=null) {
+        while (registrants.peek()!=null) {
             r = registrants.pop();
             r.cancel(env);
         }