fix major sonar bug

[so.git] / bpmn / MSOCommonBPMN / src / test / java / org / onap / so / bpmn / servicedecomposition / tasks / BBInputSetupMapperLayerTest.java

diff --git a/bpmn/MSOCommonBPMN/src/test/java/org/onap/so/bpmn/servicedecomposition/tasks/BBInputSetupMapperLayerTest.java b/bpmn/MSOCommonBPMN/src/test/java/org/onap/so/bpmn/servicedecomposition/tasks/BBInputSetupMapperLayerTest.java
index 33e1390..1babac6 100644 (file)
--- a/bpmn/MSOCommonBPMN/src/test/java/org/onap/so/bpmn/servicedecomposition/tasks/BBInputSetupMapperLayerTest.java
+++ b/bpmn/MSOCommonBPMN/src/test/java/org/onap/so/bpmn/servicedecomposition/tasks/BBInputSetupMapperLayerTest.java
@@ -23,6 +23,8 @@ package org.onap.so.bpmn.servicedecomposition.tasks;
 import static com.shazam.shazamcrest.MatcherAssert.assertThat;
 import static com.shazam.shazamcrest.matcher.Matchers.sameBeanAs;
 import static org.hamcrest.CoreMatchers.equalTo;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
 
 import java.io.File;
 import java.io.IOException;
@@ -33,7 +35,6 @@ import java.util.List;
 import java.util.Map;
 
 import org.junit.Test;
-import org.mockito.InjectMocks;
 import org.onap.so.bpmn.servicedecomposition.bbobjects.CloudRegion;
 import org.onap.so.bpmn.servicedecomposition.bbobjects.Collection;
 import org.onap.so.bpmn.servicedecomposition.bbobjects.Configuration;
@@ -549,7 +550,7 @@ public class BBInputSetupMapperLayerTest {
        @Test
        public void testMapOrchestrationContext() throws IOException {
                OrchestrationContext expected = new OrchestrationContext();
-               expected.setIsRollbackEnabled(false);
+               expected.setIsRollbackEnabled(true);
 
                RequestDetails requestDetails = mapper.readValue(new File(RESOURCE_PATH + "RequestDetailsInput_mapReqContext.json"), RequestDetails.class);
 
@@ -561,7 +562,7 @@ public class BBInputSetupMapperLayerTest {
        @Test
        public void testMapLocationContext() {
                CloudRegion expected = new CloudRegion();
-               expected.setCloudOwner("att-aic");
+               expected.setCloudOwner("test-owner-name");
                expected.setLcpCloudRegionId("cloudRegionId");
                expected.setComplex("complexName");
                expected.setTenantId("tenantId");
@@ -570,11 +571,11 @@ public class BBInputSetupMapperLayerTest {
                cloudConfig.setLcpCloudRegionId("cloudRegionId");
                cloudConfig.setAicNodeClli("aicNodeClli");
                org.onap.aai.domain.yang.CloudRegion cloudRegion = new org.onap.aai.domain.yang.CloudRegion();
-               cloudRegion.setCloudOwner("att-aic");
+               cloudRegion.setCloudOwner("test-owner-name");
                cloudRegion.setCloudRegionId("cloudRegionId");
                cloudRegion.setComplexName("complexName");
 
-               CloudRegion actual = bbInputSetupMapperLayer.mapCloudRegion(cloudConfig, cloudRegion, "att-aic");
+               CloudRegion actual = bbInputSetupMapperLayer.mapCloudRegion(cloudConfig, cloudRegion);
 
                assertThat(actual, sameBeanAs(expected));
        }
@@ -582,7 +583,7 @@ public class BBInputSetupMapperLayerTest {
        @Test
        public void testMapCloudRegion() {
                CloudRegion expected = new CloudRegion();
-               expected.setCloudOwner("att-aic");
+               expected.setCloudOwner("test-owner-name");
                expected.setLcpCloudRegionId("cloudRegionId");
                expected.setTenantId("tenantId");
                expected.setCloudRegionVersion("cloudRegionVersion");
@@ -593,11 +594,11 @@ public class BBInputSetupMapperLayerTest {
                cloudConfig.setAicNodeClli("aicNodeClli");
 
                org.onap.aai.domain.yang.CloudRegion cloudRegion = new org.onap.aai.domain.yang.CloudRegion();
-               cloudRegion.setCloudOwner("att-aic");
+               cloudRegion.setCloudOwner("test-owner-name");
                cloudRegion.setCloudRegionId("cloudRegionId");
                cloudRegion.setCloudRegionVersion("cloudRegionVersion");
 
-               CloudRegion actual = bbInputSetupMapperLayer.mapCloudRegion(cloudConfig, cloudRegion, "att-aic");
+               CloudRegion actual = bbInputSetupMapperLayer.mapCloudRegion(cloudConfig, cloudRegion);
 
                assertThat(actual, sameBeanAs(expected));
        }
@@ -606,7 +607,7 @@ public class BBInputSetupMapperLayerTest {
        public void testMapCloudRegionWithNullCheck() {
                CloudRegion expected = new CloudRegion();
 
-               CloudRegion actual = bbInputSetupMapperLayer.mapCloudRegion(null, null, null);
+               CloudRegion actual = bbInputSetupMapperLayer.mapCloudRegion(null, null);
 
                assertThat(actual, sameBeanAs(expected));
        }
@@ -636,4 +637,20 @@ public class BBInputSetupMapperLayerTest {
 
                assertThat(actual, sameBeanAs(expected));
        }
+       
+       @Test
+       public void testMapNameValueUserParams() throws IOException {           
+               RequestDetails requestDetails = mapper.readValue(new File(RESOURCE_PATH + "RequestDetailsInput_mapReqContext.json"), RequestDetails.class);
+               HashMap<String,String> actual = bbInputSetupMapperLayer.mapNameValueUserParams(requestDetails.getRequestParameters());
+
+               assertTrue(actual.containsKey("name1"));
+               assertTrue(actual.containsValue("value1"));
+               assertTrue(actual.get("name1").equals("value1"));
+               assertTrue(actual.containsKey("name2"));
+               assertTrue(actual.containsValue("value2"));
+               assertTrue(actual.get("name2").equals("value2"));               
+               assertFalse(actual.containsKey("ignore"));
+               assertFalse(actual.containsValue("ignore"));            
+       }
+       
 }