Merge "Sonar fixes related to exceptions"

[aaf/authz.git] / auth / auth-cmd / src / test / java / org / onap / aaf / auth / cmd / test / perm / JU_Describe.java

diff --git a/auth/auth-cmd/src/test/java/org/onap/aaf/auth/cmd/test/perm/JU_Describe.java b/auth/auth-cmd/src/test/java/org/onap/aaf/auth/cmd/test/perm/JU_Describe.java
index 9a91d0e..224b5c7 100644 (file)
--- a/auth/auth-cmd/src/test/java/org/onap/aaf/auth/cmd/test/perm/JU_Describe.java
+++ b/auth/auth-cmd/src/test/java/org/onap/aaf/auth/cmd/test/perm/JU_Describe.java
@@ -21,77 +21,89 @@
  ******************************************************************************/
 package org.onap.aaf.auth.cmd.test.perm;
 
-import org.junit.Assert;
-import org.junit.Before;
-
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.fail;
-import static org.mockito.Mockito.mock;
+import static org.mockito.Matchers.any;
 import static org.mockito.Mockito.when;
 
+import org.junit.Before;
+
+import java.io.ByteArrayOutputStream;
+import java.io.PrintStream;
 import java.io.Writer;
 import java.net.HttpURLConnection;
 import java.net.URI;
 import java.net.URISyntaxException;
 
-import org.junit.BeforeClass;
 import org.junit.Test;
 import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
 import org.mockito.runners.MockitoJUnitRunner;
 import org.onap.aaf.auth.cmd.AAFcli;
-import org.onap.aaf.auth.cmd.perm.Describe;
-import org.onap.aaf.auth.cmd.perm.Perm;
-import org.onap.aaf.auth.cmd.role.Role;
-import org.onap.aaf.auth.cmd.test.JU_AAFCli;
 import org.onap.aaf.auth.env.AuthzEnv;
 import org.onap.aaf.cadi.CadiException;
 import org.onap.aaf.cadi.Locator;
 import org.onap.aaf.cadi.LocatorException;
 import org.onap.aaf.cadi.PropAccess;
 import org.onap.aaf.cadi.SecuritySetter;
-import org.onap.aaf.cadi.Locator.Item;
-import org.onap.aaf.cadi.http.HMangr;
-import org.onap.aaf.cadi.http.HRcli;
+import org.onap.aaf.cadi.client.Future;
+import org.onap.aaf.cadi.client.Rcli;
 import org.onap.aaf.misc.env.APIException;
 
+import org.onap.aaf.auth.cmd.perm.Describe;
+import org.onap.aaf.auth.cmd.perm.Perm;
+import org.onap.aaf.auth.cmd.role.Role;
+import org.onap.aaf.auth.cmd.test.HMangrStub;
+
 @RunWith(MockitoJUnitRunner.class)
 public class JU_Describe {
-//     
-       private static Describe desc;
-       PropAccess prop;
-       AuthzEnv aEnv;
-       Writer wtr;
-       Locator<URI> loc;
-       HMangr hman;    
-       AAFcli aafcli;
+
+       @Mock private SecuritySetter<HttpURLConnection> ssMock;
+       @Mock private Locator<URI> locMock;
+       @Mock private Writer wrtMock;
+       @Mock private Rcli<HttpURLConnection> clientMock;
+       @Mock private Future<Object> futureMock;
+
+       private PropAccess access;
+       private HMangrStub hman;        
+       private AuthzEnv aEnv;
+       private AAFcli aafcli;
+       
+       private Describe desc;
        
        @Before
        public void setUp () throws NoSuchFieldException, SecurityException, Exception, IllegalAccessException {
-               prop = new PropAccess();
+               MockitoAnnotations.initMocks(this);
+
+               when(clientMock.create(any(), any(), any())).thenReturn(futureMock);
+               when(clientMock.delete(any(), any(), any())).thenReturn(futureMock);
+               when(clientMock.update(any(), any(), any())).thenReturn(futureMock);
+
+               hman = new HMangrStub(access, locMock, clientMock);
+               access = new PropAccess(new PrintStream(new ByteArrayOutputStream()), new String[0]);
                aEnv = new AuthzEnv();
-               wtr = mock(Writer.class);
-               loc = mock(Locator.class);
-               SecuritySetter<HttpURLConnection> secSet = mock(SecuritySetter.class);
-               hman = new HMangr(aEnv, loc);   
-               aafcli = new AAFcli(prop, aEnv, wtr, hman, null, secSet);
+               aafcli = new AAFcli(access, aEnv, wrtMock, hman, null, ssMock);
+
                Role role = new Role(aafcli);
                Perm perm = new Perm(role);
+
                desc = new Describe(perm);
        }
        
        @Test
-       public void testExec() throws APIException, LocatorException, CadiException, URISyntaxException {
-               Item value = mock(Item.class);
-               Locator.Item item = new Locator.Item() {
-               };
-               when(loc.best()).thenReturn(value);
-               URI uri = new URI("http://www.oracle.com/technetwork/java/index.html");
-               when(loc.get(value)).thenReturn(uri);
-               SecuritySetter<HttpURLConnection> secSet = mock(SecuritySetter.class);
-//             HRcli hcli = new HRcli(hman, uri, item, secSet);
-//             String[] strArr = {"grant","ungrant","setTo","grant","ungrant","setTo"};
-//             desc._exec(0, strArr);
-
+       public void testExecError() throws APIException, LocatorException, CadiException, URISyntaxException {
+               desc._exec(0, new String[] {"grant","ungrant","setTo","grant","ungrant","setTo"});
+       }
+       
+       @Test
+       public void testExecSuccess1() throws APIException, LocatorException, CadiException, URISyntaxException {
+               when(futureMock.code()).thenReturn(202);
+               desc._exec(0, new String[] {"grant","ungrant","setTo","grant","ungrant","setTo"});
+       }
+       
+       @Test
+       public void testExecSuccess2() throws APIException, LocatorException, CadiException, URISyntaxException {
+               when(futureMock.get(any(Integer.class))).thenReturn(true);
+               desc._exec(0, new String[] {"grant","ungrant","setTo","grant","ungrant","setTo"});
        }
        
        @Test