Remove Sonar Blockers

[aaf/authz.git] / auth / auth-cmd / src / main / java / org / onap / aaf / auth / cmd / AAFcli.java

diff --git a/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/AAFcli.java b/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/AAFcli.java
index ab41eb8..2d5e172 100644 (file)
--- a/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/AAFcli.java
+++ b/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/AAFcli.java
@@ -30,7 +30,6 @@ import java.io.PrintWriter;
 import java.io.Reader;
 import java.io.Writer;
 import java.net.HttpURLConnection;
-import java.net.URI;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -44,10 +43,9 @@ import org.onap.aaf.auth.env.AuthzEnv;
 import org.onap.aaf.cadi.Access;
 import org.onap.aaf.cadi.Access.Level;
 import org.onap.aaf.cadi.CadiException;
-import org.onap.aaf.cadi.Locator;
 import org.onap.aaf.cadi.PropAccess;
 import org.onap.aaf.cadi.SecuritySetter;
-import org.onap.aaf.cadi.aaf.v2_0.AAFLocator;
+import org.onap.aaf.cadi.aaf.v2_0.AAFConHttp;
 import org.onap.aaf.cadi.client.Retryable;
 import org.onap.aaf.cadi.config.Config;
 import org.onap.aaf.cadi.config.SecurityInfoC;
@@ -71,7 +69,7 @@ public class AAFcli {
        private List<Cmd> cmds;
 
        // Lex State
-       private ArrayList<Integer> expect = new ArrayList<Integer>();
+       private ArrayList<Integer> expect = new ArrayList<>();
        private boolean verbose = true;
        private int delay;
        private SecurityInfoC<HttpURLConnection> si;
@@ -115,7 +113,7 @@ public class AAFcli {
                /*
                 * Create Cmd Tree
                 */
-               cmds = new ArrayList<Cmd>();
+               cmds = new ArrayList<>();
 
                Role role = new Role(this);
                cmds.add(new Help(this, cmds));
@@ -132,10 +130,10 @@ public class AAFcli {
        }
 
        public void close() {
-               if (hman != null) {
-                       hman.close();
-                       hman = null;
-               }
+//             if (hman != null) {
+//                     hman.close();
+//                     hman = null;
+//             }
                if (close) {
                        pw.close();
                }
@@ -200,7 +198,7 @@ public class AAFcli {
                                                if (pass != null) {
                                                        pass = access.decrypt(pass, false);
                                                        access.getProperties().put(user, pass);
-                                                       ss = new HBasicAuthSS(si, user, pass);
+                                                       ss=new HBasicAuthSS(si, user, pass);
                                                        pw.println("as " + user);
                                                } else { // get Pass from System Properties, under name of
                                                        // Tag
@@ -360,7 +358,7 @@ public class AAFcli {
 
        private String[] argEval(String line) {
                StringBuilder sb = new StringBuilder();
-               ArrayList<String> arr = new ArrayList<String>();
+               ArrayList<String> arr = new ArrayList<>();
                boolean start = true;
                char quote = 0;
                char last = 0;
@@ -435,8 +433,10 @@ public class AAFcli {
                
                try {
                        AAFSSO aafsso = new AAFSSO(args);
+                       String noexit = aafsso.access().getProperty("no_exit");
                        try {
                                PropAccess access = aafsso.access();
+
                                if(aafsso.ok()) {
                                        Define.set(access);
                                        AuthzEnv env = new AuthzEnv(access);
@@ -478,36 +478,39 @@ public class AAFcli {
                                                        sb.append(args[i]);
                                                }
                                        }
-               
-                                       SecurityInfoC<HttpURLConnection> si = SecurityInfoC.instance(access, HttpURLConnection.class);
-                                       Locator<URI> loc;
+                                       
+                                       AAFConHttp aafcon = new AAFConHttp(access);
+//                                     
+//                                     SecurityInfoC<?> si = aafcon.securityInfo();
+//                                     Locator<URI> loc;
                                        
                                        aafsso.setLogDefault();
                                        aafsso.setStdErrDefault();
        
                                        // Note, with AAF Locator, this may not longer be necessary 3/2018 Jonathan
                                        if(!aafsso.loginOnly()) {
-                                               try {
-                                                       loc = new AAFLocator(si,new URI(access.getProperty(Config.AAF_URL)));
-                                               } catch (Throwable t) {
-                                                       aafsso.setStdErrDefault();
-                                                       throw t;
-                                               } finally {
-                                                       // Other Access is done writing to StdOut and StdErr, reset Std out
-                                                       aafsso.setLogDefault();
-                                               }
+//                                             try {
+//                                                     loc = new AAFLocator(si,new URI(access.getProperty(Config.AAF_URL)));
+//                                             } catch (Throwable t) {
+//                                                     aafsso.setStdErrDefault();
+//                                                     throw t;
+//                                             } finally {
+//                                                     // Other Access is done writing to StdOut and StdErr, reset Std out
+//                                                     aafsso.setLogDefault();
+//                                             }
        
                                                TIMEOUT = Integer.parseInt(access.getProperty(Config.AAF_CONN_TIMEOUT, Config.AAF_CONN_TIMEOUT_DEF));
-                                               HMangr hman = new HMangr(access, loc).readTimeout(TIMEOUT).apiVersion(Config.AAF_DEFAULT_VERSION);
+//                                             HMangr hman = new HMangr(access, loc).readTimeout(TIMEOUT).apiVersion(Config.AAF_DEFAULT_VERSION);
                                                
                                                if(access.getProperty(Config.AAF_DEFAULT_REALM)==null) {
                                                        access.setProperty(Config.AAF_DEFAULT_REALM, "people.osaaf.org");
                                                        aafsso.addProp(Config.AAF_DEFAULT_REALM, "people.osaaf.org");
                                                }
                        
-                                               
-                                               AAFcli aafcli = new AAFcli(access,env, new OutputStreamWriter(System.out), hman, si, 
-                                                       new HBasicAuthSS(si,aafsso.user(), access.decrypt(aafsso.enc_pass(),false)));
+                                               AAFcli aafcli = new AAFcli(access,env, new OutputStreamWriter(System.out),  
+                                                               aafcon.hman(), aafcon.securityInfo(), aafcon.securityInfo().defSS);
+//                                                     new HBasicAuthSS(si,aafsso.user(), access.decrypt(aafsso.enc_pass(),false)));
+//                                             }
                                                if(!ignoreDelay) {
                                                        File delay = new File("aafcli.delay");
                                                        if(delay.exists()) {
@@ -588,21 +591,21 @@ public class AAFcli {
                        } finally {
                                aafsso.close();
                                StringBuilder err = aafsso.err();
-                               String noexit = aafsso.access().getProperty("no_exit");
                                if (err != null) {
                                        err.append("to continue...");
                                        System.err.println(err);
                                }
-                               if(noexit==null) {
-                                       return;
-                               }
-
                        }
+                       if(noexit==null) {
+                               return;
+                       }
+
+
                } catch (MessageException e) {
                        System.out.println("MessageException caught");
 
                        System.err.println(e.getMessage());
-               } catch (Throwable e) {
+               } catch (Exception e) {
                        e.printStackTrace(System.err);
                }
                System.exit(rv);
@@ -617,7 +620,7 @@ public class AAFcli {
        }
 
        public String typeString(Class<?> cls, boolean json) {
-               return "application/" + cls.getSimpleName() + "+" + (json ? "json" : "xml") + ";version=" + hman.apiVersion();
+               return "application/" + cls.getSimpleName() + "+" + (json ? "json" : "xml");//+ ";version=" + hman.apiVersion();
        }
 
        public String forceString() {