Merge "AAFcli.java -Declare "value" on a separate line"
[aaf/authz.git] / auth / auth-cass / src / main / java / org / onap / aaf / auth / dao / cass / ApprovalDAO.java
index 4c66c96..139e85a 100644 (file)
@@ -3,13 +3,15 @@
  * org.onap.aaf
  * ===========================================================================
  * Copyright (c) 2018 AT&T Intellectual Property. All rights reserved.
+ *
+ * Modification Copyright (c) 2019 IBM
  * ===========================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -46,13 +48,17 @@ public class ApprovalDAO extends CassDAOImpl<AuthzTrans,ApprovalDAO.Data> {
     public static final String PENDING = "pending";
     public static final String DENIED = "denied";
     public static final String APPROVED = "approved";
-    
+
     private static final String TABLE = "approval";
     private static final String TABLELOG = "approved";
     private HistoryDAO historyDAO;
-    private PSInfo psByUser, psByApprover, psByTicket, psByStatus;
+    private PSInfo psByUser;
+    private PSInfo psByApprover;
+    private PSInfo psByTicket;
+    private PSInfo psByStatus;
+
+    private static final int KEYLIMIT = 1;
 
-    
     public ApprovalDAO(AuthzTrans trans, Cluster cluster, String keyspace) {
         super(trans, ApprovalDAO.class.getSimpleName(),cluster,keyspace,Data.class,TABLE, readConsistency(trans,TABLE), writeConsistency(trans,TABLE));
         historyDAO = new HistoryDAO(trans, this);
@@ -66,7 +72,6 @@ public class ApprovalDAO extends CassDAOImpl<AuthzTrans,ApprovalDAO.Data> {
         init(trans);
     }
 
-    private static final int KEYLIMIT = 1;
     public static class Data {
         public UUID   id;
         public UUID   ticket;
@@ -76,17 +81,16 @@ public class ApprovalDAO extends CassDAOImpl<AuthzTrans,ApprovalDAO.Data> {
         public String status;
         public String memo;
         public String operation;
-//        public Date last_notified;
         public Date updated;
     }
-    
+
     private static class ApprovalLoader extends Loader<Data> {
         public static final ApprovalLoader deflt = new ApprovalLoader(KEYLIMIT);
-        
+
         public ApprovalLoader(int keylimit) {
             super(keylimit);
         }
-        
+
         @Override
         public Data load(Data data, Row row) {
             data.id = row.getUUID(0);
@@ -97,8 +101,7 @@ public class ApprovalDAO extends CassDAOImpl<AuthzTrans,ApprovalDAO.Data> {
             data.status = row.getString(5);
             data.memo = row.getString(6);
             data.operation = row.getString(7);
-//            data.last_notified = row.getTimestamp(8);
-            // This is used to get "WRITETIME(STATUS)" from Approval, which gives us an "updated" 
+            // This is used to get "WRITETIME(STATUS)" from Approval, which gives us an "updated"
             if (row.getColumnDefinitions().size()>8) {
                 // Rows reported in MicroSeconds
                 data.updated = new Date(row.getLong(8)/1000);
@@ -112,8 +115,8 @@ public class ApprovalDAO extends CassDAOImpl<AuthzTrans,ApprovalDAO.Data> {
         }
 
         @Override
-        protected void body(Data data, int _idx, Object[] obj) {
-                int idx = _idx;
+        protected void body(Data data, int idxParam, Object[] obj) {
+                int idx = idxParam;
             obj[idx]=data.ticket;
             obj[++idx]=data.user;
             obj[++idx]=data.approver;
@@ -121,21 +124,20 @@ public class ApprovalDAO extends CassDAOImpl<AuthzTrans,ApprovalDAO.Data> {
             obj[++idx]=data.status;
             obj[++idx]=data.memo;
             obj[++idx]=data.operation;
-//            obj[++idx]=data.last_notified;
         }
-    }    
-    
+    }
+
     private void init(AuthzTrans trans) {
         String[] helpers = setCRUD(trans, TABLE, Data.class, ApprovalLoader.deflt,8);
-        psByUser = new PSInfo(trans, SELECT_SP + helpers[FIELD_COMMAS] + ", WRITETIME(status) FROM " + TABLE + 
+        psByUser = new PSInfo(trans, SELECT_SP + helpers[FIELD_COMMAS] + ", WRITETIME(status) FROM " + TABLE +
                 " WHERE user = ?", new ApprovalLoader(1) {
             @Override
             protected void key(Data data, int idx, Object[] obj) {
                 obj[idx]=data.user;
             }
         }, readConsistency);
-        
-        psByApprover = new PSInfo(trans, SELECT_SP + helpers[FIELD_COMMAS] + ", WRITETIME(status) FROM " + TABLE + 
+
+        psByApprover = new PSInfo(trans, SELECT_SP + helpers[FIELD_COMMAS] + ", WRITETIME(status) FROM " + TABLE +
                 " WHERE approver = ?", new ApprovalLoader(1) {
             @Override
             protected void key(Data data, int idx, Object[] obj) {
@@ -143,7 +145,7 @@ public class ApprovalDAO extends CassDAOImpl<AuthzTrans,ApprovalDAO.Data> {
             }
         }, readConsistency);
 
-        psByTicket = new PSInfo(trans, SELECT_SP + helpers[FIELD_COMMAS] + ", WRITETIME(status) FROM " + TABLE + 
+        psByTicket = new PSInfo(trans, SELECT_SP + helpers[FIELD_COMMAS] + ", WRITETIME(status) FROM " + TABLE +
                 " WHERE ticket = ?", new ApprovalLoader(1) {
             @Override
             protected void key(Data data, int idx, Object[] obj) {
@@ -151,7 +153,7 @@ public class ApprovalDAO extends CassDAOImpl<AuthzTrans,ApprovalDAO.Data> {
             }
         }, readConsistency);
 
-        psByStatus = new PSInfo(trans, SELECT_SP + helpers[FIELD_COMMAS] + ", WRITETIME(status) FROM " + TABLE + 
+        psByStatus = new PSInfo(trans, SELECT_SP + helpers[FIELD_COMMAS] + ", WRITETIME(status) FROM " + TABLE +
                 " WHERE status = ?", new ApprovalLoader(1) {
             @Override
             protected void key(Data data, int idx, Object[] obj) {
@@ -175,7 +177,7 @@ public class ApprovalDAO extends CassDAOImpl<AuthzTrans,ApprovalDAO.Data> {
         if (rs.notOK()) {
             return Result.err(rs);
         }
-        return Result.ok(data);    
+        return Result.ok(data);
     }
 
 
@@ -193,7 +195,7 @@ public class ApprovalDAO extends CassDAOImpl<AuthzTrans,ApprovalDAO.Data> {
 
     public Result<List<ApprovalDAO.Data>> readByStatus(AuthzTrans trans, String status) {
         return psByStatus.read(trans, R_TEXT, new Object[]{status});
-    }    
+    }
 
     /* (non-Javadoc)
      * @see org.onap.aaf.auth.dao.CassDAOImpl#delete(com.att.inno.env.TransStore, java.lang.Object, boolean)
@@ -207,18 +209,24 @@ public class ApprovalDAO extends CassDAOImpl<AuthzTrans,ApprovalDAO.Data> {
             }
             ApprovalLoader.deflt.load(data, rd.value.one());
         }
-        if ("approved".equals(data.status) || "denied".equals(data.status)) { 
+        if (APPROVED.equals(data.status) || DENIED.equals(data.status)) {
             StringBuilder sb = new StringBuilder("BEGIN BATCH\n");
             sb.append("INSERT INTO ");
             sb.append(TABLELOG);
             sb.append(" (id,user,approver,type,status,memo,operation) VALUES (");
             sb.append(data.id);
-            sb.append(",'"); sb.append(data.user);
-            sb.append("','"); sb.append(data.approver);
-            sb.append("','"); sb.append(data.type);
-            sb.append("','"); sb.append(data.status);
-            sb.append("','"); sb.append(data.memo.replace("'", "''"));
-            sb.append("','"); sb.append(data.operation);
+            sb.append(",'");
+            sb.append(data.user);
+            sb.append("','");
+            sb.append(data.approver);
+            sb.append("','");
+            sb.append(data.type);
+            sb.append("','");
+            sb.append(data.status);
+            sb.append("','");
+            sb.append(data.memo.replace("'", "''"));
+            sb.append("','");
+            sb.append(data.operation);
             sb.append("');\n");
             sb.append("DELETE FROM ");
             sb.append(TABLE);