appc-network-client-provider sonar fixes part 1

[appc.git] / appc-outbound / appc-network-inventory-client / provider / src / main / java / org / onap / appc / instar / interfaceImpl / InstarRestClientImpl.java

diff --git a/appc-outbound/appc-network-inventory-client/provider/src/main/java/org/onap/appc/instar/interfaceImpl/InstarRestClientImpl.java b/appc-outbound/appc-network-inventory-client/provider/src/main/java/org/onap/appc/instar/interfaceImpl/InstarRestClientImpl.java
index bb0786b..bb46567 100644 (file)
--- a/appc-outbound/appc-network-inventory-client/provider/src/main/java/org/onap/appc/instar/interfaceImpl/InstarRestClientImpl.java
+++ b/appc-outbound/appc-network-inventory-client/provider/src/main/java/org/onap/appc/instar/interfaceImpl/InstarRestClientImpl.java
@@ -24,45 +24,42 @@
 
 package org.onap.appc.instar.interfaceImpl;
 
+import com.att.eelf.configuration.EELFLogger;
+import com.att.eelf.configuration.EELFManager;
 import java.util.HashMap;
-
 import org.onap.appc.instar.dme2client.Dme2Client;
 import org.onap.appc.instar.interfaces.RestClientInterface;
 import org.onap.appc.instar.utils.InstarClientConstant;
 
-import com.att.eelf.configuration.EELFLogger;
-import com.att.eelf.configuration.EELFManager;
-
 public class InstarRestClientImpl implements RestClientInterface {
-       
-       private static final EELFLogger log = EELFManager.getInstance().getLogger(InstarRestClientImpl.class);
-       HashMap<String, String> requestData  = null;
-       Dme2Client dme2Client;
 
-       public InstarRestClientImpl(HashMap<String, String> instarRequestData) {
-               
-               this.requestData = instarRequestData;
-       }
+    private static final EELFLogger log = EELFManager.getInstance().getLogger(InstarRestClientImpl.class);
+    HashMap<String, String> requestData = null;
+    Dme2Client dme2Client;
 
-       @Override
-       public String sendRequest(String operation) throws Exception {
-               
-               String instarResponse = null;
-               try {
-                       if(operation !=null && operation.equalsIgnoreCase(InstarClientConstant.OPERATION_GET_IPADDRESS_BY_VNF_NAME)){
-                         dme2Client = new Dme2Client(operation, InstarClientConstant.VNF_NAME, requestData);
-                       }
-                        instarResponse = dme2Client.send();
-                       log.info("Resposne in InstarRestClientImpl = " + instarResponse);
-                       if(instarResponse == null || instarResponse.length() < 0)
-                               throw new Exception ("No Data received from Instar for this call " + operation);
-               } catch (Exception e) {
-                       e.printStackTrace();
-                       throw e;
-               }               
-               return instarResponse;
-       }
+    public InstarRestClientImpl(HashMap<String, String> instarRequestData) {
 
+        this.requestData = instarRequestData;
+    }
 
+    @Override
+    public String sendRequest(String operation) throws Exception {
 
+        String instarResponse = null;
+        try {
+            if (operation != null && operation
+                .equalsIgnoreCase(InstarClientConstant.OPERATION_GET_IPADDRESS_BY_VNF_NAME)) {
+                dme2Client = new Dme2Client(operation, InstarClientConstant.VNF_NAME, requestData);
+            }
+            instarResponse = dme2Client.send();
+            log.info("Resposne in InstarRestClientImpl = " + instarResponse);
+            if (instarResponse == null || instarResponse.length() < 0) {
+                throw new Exception("No Data received from Instar for this call " + operation);
+            }
+        } catch (Exception e) {
+            e.printStackTrace();
+            throw e;
+        }
+        return instarResponse;
+    }
 }