appc-dg-common sonar fixes part 2

[appc.git] / appc-dg / appc-dg-shared / appc-dg-common / src / main / java / org / onap / appc / dg / common / impl / ResolverDataReaderFactory.java

diff --git a/appc-dg/appc-dg-shared/appc-dg-common/src/main/java/org/onap/appc/dg/common/impl/ResolverDataReaderFactory.java b/appc-dg/appc-dg-shared/appc-dg-common/src/main/java/org/onap/appc/dg/common/impl/ResolverDataReaderFactory.java
index 15e4ab6..c716147 100644 (file)
--- a/appc-dg/appc-dg-shared/appc-dg-common/src/main/java/org/onap/appc/dg/common/impl/ResolverDataReaderFactory.java
+++ b/appc-dg/appc-dg-shared/appc-dg-common/src/main/java/org/onap/appc/dg/common/impl/ResolverDataReaderFactory.java
@@ -31,20 +31,24 @@ public class ResolverDataReaderFactory {
 
     private static final Configuration configuration = ConfigurationFactory.getConfiguration();
 
-    private static class ReferenceHolder {
-
-        private static final AbstractResolverDataReader VNFC_RESOLVER_DATA_READER = new VNFCResolverDataReader();
-
-        private static final AbstractResolverDataReader VNF_RESOLVER_DATA_READER = new VNFResolverDataReader();
-    }
+    private ResolverDataReaderFactory() {}
 
     public static AbstractResolverDataReader createResolverDataReader(String resolverType) {
-        if (resolverType.equalsIgnoreCase("VNF")) {
+        if ("VNF".equalsIgnoreCase(resolverType)) {
             return ReferenceHolder.VNF_RESOLVER_DATA_READER;
-        } else if (resolverType.equalsIgnoreCase("VNFC")) {
+        } else if ("VNFC".equalsIgnoreCase(resolverType)) {
             return ReferenceHolder.VNFC_RESOLVER_DATA_READER;
         } else {
             return null;
         }
     }
+
+    private static class ReferenceHolder {
+
+        private static final AbstractResolverDataReader VNFC_RESOLVER_DATA_READER = new VNFCResolverDataReader();
+
+        private static final AbstractResolverDataReader VNF_RESOLVER_DATA_READER = new VNFResolverDataReader();
+
+        private ReferenceHolder() {}
+    }
 }