Improve coverage flow/controller/node #4
[appc.git] / appc-config / appc-flow-controller / provider / src / main / java / org / onap / appc / flow / controller / node / FlowControlNode.java
index 010729f..baca94b 100644 (file)
@@ -1,38 +1,45 @@
 /*-
  * ============LICENSE_START=======================================================
- * ONAP : APP-C
- * ================================================================================
- * Copyright (C) 2017 AT&T Intellectual Property.  All rights reserved.
+ * ONAP : APPC
  * ================================================================================
+ * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
+ * =============================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
+ * ECOMP is a trademark and service mark of AT&T Intellectual Property.
  * ============LICENSE_END=========================================================
  */
 
 package org.onap.appc.flow.controller.node;
 
+import com.att.eelf.configuration.EELFLogger;
+import com.att.eelf.configuration.EELFManager;
+import com.fasterxml.jackson.annotation.JsonInclude.Include;
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.SerializationFeature;
 import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStream;
-import java.nio.charset.Charset;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Properties;
-
-import org.apache.commons.io.IOUtils;
 import org.apache.commons.lang3.StringUtils;
+import org.json.JSONObject;
 import org.onap.appc.flow.controller.ResponseHandlerImpl.DefaultResponseHandler;
 import org.onap.appc.flow.controller.data.PrecheckOption;
 import org.onap.appc.flow.controller.data.ResponseAction;
@@ -53,41 +60,38 @@ import org.onap.appc.flow.controller.interfaceData.VnfInfo;
 import org.onap.appc.flow.controller.interfaceData.Vnfcs;
 import org.onap.appc.flow.controller.interfaceData.Vnfcslist;
 import org.onap.appc.flow.controller.interfaces.FlowExecutorInterface;
+import org.onap.appc.flow.controller.utils.EncryptionTool;
 import org.onap.appc.flow.controller.utils.FlowControllerConstants;
 import org.onap.ccsdk.sli.core.sli.SvcLogicContext;
 import org.onap.ccsdk.sli.core.sli.SvcLogicException;
 import org.onap.ccsdk.sli.core.sli.SvcLogicJavaPlugin;
 
-import com.att.eelf.configuration.EELFLogger;
-import com.att.eelf.configuration.EELFManager;
-import com.fasterxml.jackson.annotation.JsonInclude.Include;
-import com.fasterxml.jackson.core.JsonParseException;
-import com.fasterxml.jackson.databind.DeserializationFeature;
-import com.fasterxml.jackson.databind.JsonMappingException;
-import com.fasterxml.jackson.databind.JsonNode;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.databind.SerializationFeature;
-
-public class FlowControlNode implements SvcLogicJavaPlugin{
-
+public class FlowControlNode implements SvcLogicJavaPlugin {
 
-    private static final  EELFLogger log = EELFManager.getInstance().getLogger(FlowControlNode.class);
+    private static final EELFLogger log = EELFManager.getInstance().getLogger(FlowControlNode.class);
     private static final String SDNC_CONFIG_DIR_VAR = "SDNC_CONFIG_DIR";
 
     public void processFlow(Map<String, String> inParams, SvcLogicContext ctx) throws SvcLogicException {
         log.debug("Received processParamKeys call with params : " + inParams);
-        String responsePrefix = inParams.get(FlowControllerConstants.INPUT_PARAM_RESPONSE_PRIFIX);        
-        try
-        {
-            responsePrefix = StringUtils.isNotBlank(responsePrefix) ? (responsePrefix+".") : "";
+        String responsePrefix = inParams.get(FlowControllerConstants.INPUT_PARAM_RESPONSE_PREFIX);
+        try {
+            responsePrefix = StringUtils.isNotBlank(responsePrefix) ? (responsePrefix + ".") : "";
+            SvcLogicContext localContext = new SvcLogicContext();
+
+            localContext.setAttribute(FlowControllerConstants.REQUEST_ID,
+                ctx.getAttribute(FlowControllerConstants.REQUEST_ID));
+            localContext.setAttribute(FlowControllerConstants.VNF_TYPE,
+                ctx.getAttribute(FlowControllerConstants.VNF_TYPE));
+            localContext.setAttribute(FlowControllerConstants.REQUEST_ACTION,
+                ctx.getAttribute(FlowControllerConstants.REQUEST_ACTION));
+            localContext.setAttribute(FlowControllerConstants.ACTION_LEVEL,
+                ctx.getAttribute(FlowControllerConstants.ACTION_LEVEL));
+            localContext.setAttribute(FlowControllerConstants.RESPONSE_PREFIX,
+                responsePrefix);
+            ctx.setAttribute(FlowControllerConstants.RESPONSE_PREFIX,
+                responsePrefix);
+
             FlowControlDBService dbservice = FlowControlDBService.initialise();
-            SvcLogicContext  localContext = new SvcLogicContext();
-            localContext.setAttribute(FlowControllerConstants.REQUEST_ID, ctx.getAttribute(FlowControllerConstants.REQUEST_ID));
-            localContext.setAttribute(FlowControllerConstants.VNF_TYPE, ctx.getAttribute(FlowControllerConstants.VNF_TYPE));
-            localContext.setAttribute(FlowControllerConstants.REQUEST_ACTION, ctx.getAttribute(FlowControllerConstants.REQUEST_ACTION));
-            localContext.setAttribute(FlowControllerConstants.ACTION_LEVEL, ctx.getAttribute(FlowControllerConstants.ACTION_LEVEL));    
-            localContext.setAttribute(FlowControllerConstants.RESPONSE_PREFIX, responsePrefix);
-            ctx.setAttribute(FlowControllerConstants.RESPONSE_PREFIX, responsePrefix);
             dbservice.getFlowReferenceData(ctx, inParams, localContext);
 
             for (Object key : localContext.getAttributeKeySet()) {
@@ -96,302 +100,341 @@ public class FlowControlNode implements SvcLogicJavaPlugin{
                 log.debug("processFlow " + parmName +  "="  + parmValue);
 
             }
-            processFlowSequence(inParams, ctx, localContext);        
-            if(!ctx.getAttribute(responsePrefix + FlowControllerConstants.OUTPUT_PARAM_STATUS).equals(FlowControllerConstants.OUTPUT_STATUS_SUCCESS))
-                throw new SvcLogicException(ctx.getAttribute(responsePrefix +  FlowControllerConstants.OUTPUT_STATUS_MESSAGE));
-            
+            processFlowSequence(inParams, ctx, localContext);
+            if (!ctx.getAttribute(responsePrefix + FlowControllerConstants.OUTPUT_PARAM_STATUS)
+                .equals(FlowControllerConstants.OUTPUT_STATUS_SUCCESS)) {
+
+                throw new SvcLogicException(
+                    ctx.getAttribute(responsePrefix + FlowControllerConstants.OUTPUT_STATUS_MESSAGE));
+            }
+
         } catch (Exception e) {
-            ctx.setAttribute(responsePrefix + FlowControllerConstants.OUTPUT_PARAM_STATUS, FlowControllerConstants.OUTPUT_STATUS_FAILURE);
-            ctx.setAttribute(responsePrefix + FlowControllerConstants.OUTPUT_PARAM_ERROR_MESSAGE, e.getMessage());
-            e.printStackTrace();
+            ctx.setAttribute(responsePrefix + FlowControllerConstants.OUTPUT_PARAM_STATUS,
+                FlowControllerConstants.OUTPUT_STATUS_FAILURE);
+            ctx.setAttribute(responsePrefix + FlowControllerConstants.OUTPUT_PARAM_ERROR_MESSAGE,
+                e.getMessage());
+            log.error("Error occured in processFlow ", e);
             throw new SvcLogicException(e.getMessage());
         }
     }
 
-    private void processFlowSequence( Map<String, String> inParams, SvcLogicContext ctx, SvcLogicContext localContext) throws Exception 
-    {
+    private void processFlowSequence(Map<String, String> inParams, SvcLogicContext ctx, SvcLogicContext localContext)
+        throws Exception {
+
         String fn = "FlowExecutorNode.processflowSequence";
-        log.debug(fn + "Received model for flow : " + localContext.toString());    
+        log.debug(fn + "Received model for flow : " + localContext.toString());
         FlowControlDBService dbservice = FlowControlDBService.initialise();
-        String flowSequnce  =null;
+        String flowSequnce null;
         for (Object key : localContext.getAttributeKeySet()) {
             String parmName = (String) key;
             String parmValue = ctx.getAttribute(parmName);
             log.debug(parmName +  "="  + parmValue);
 
         }
-        if(localContext != null && localContext.getAttribute(FlowControllerConstants.SEQUENCE_TYPE) !=null){
-
-            if(localContext.getAttribute(FlowControllerConstants.GENERATION_NODE) != null){
+        if (localContext.getAttribute(FlowControllerConstants.SEQUENCE_TYPE) != null) {
+            if (localContext.getAttribute(FlowControllerConstants.GENERATION_NODE) != null) {
                 GraphExecutor transactionExecutor = new GraphExecutor();
-                Boolean generatorExists = transactionExecutor.hasGraph("APPC_COMMOM", localContext.getAttribute(FlowControllerConstants.GENERATION_NODE), null, "sync");
-                if(generatorExists){                    
-                    flowSequnce = transactionExecutor.executeGraph("APPC_COMMOM", localContext.getAttribute(FlowControllerConstants.GENERATION_NODE),
-                            null, "sync", null).getProperty(FlowControllerConstants.FLOW_SEQUENCE);
+                Boolean generatorExists = transactionExecutor.hasGraph(
+                    "APPC_COMMOM",
+                    localContext.getAttribute(FlowControllerConstants.GENERATION_NODE),
+                    null,
+                    "sync");
+
+                if (generatorExists) {
+                    flowSequnce = transactionExecutor.executeGraph(
+                        "APPC_COMMOM",
+                        localContext.getAttribute(FlowControllerConstants.GENERATION_NODE),
+                        null, "sync", null)
+                        .getProperty(FlowControllerConstants.FLOW_SEQUENCE);
+                } else {
+                    throw new Exception("Can not find Custom defined Flow Generator for "
+                        + localContext.getAttribute(FlowControllerConstants.GENERATION_NODE));
                 }
-                else
-                    throw new Exception("Can not find Custom defined Flow Generator for " + localContext.getAttribute(FlowControllerConstants.GENERATION_NODE));                
-            }            
-            else if(((String) localContext.getAttribute(FlowControllerConstants.SEQUENCE_TYPE)).equalsIgnoreCase(FlowControllerConstants.DESINGTIME)){
-                localContext.setAttribute(FlowControllerConstants.VNFC_TYPE, ctx.getAttribute(FlowControllerConstants.VNFC_TYPE));
+
+            } else if ((localContext.getAttribute(FlowControllerConstants.SEQUENCE_TYPE))
+                .equalsIgnoreCase(FlowControllerConstants.DESINGTIME)) {
+
+                localContext.setAttribute(FlowControllerConstants.VNFC_TYPE,
+                    ctx.getAttribute(FlowControllerConstants.VNFC_TYPE));
                 flowSequnce = dbservice.getDesignTimeFlowModel(localContext);
-                if(flowSequnce == null)
-                    throw new Exception("Flow Sequence is not found User Desinged VNF " + ctx.getAttribute(FlowControllerConstants.VNF_TYPE));
-            }
-            else if(((String) localContext.getAttribute(FlowControllerConstants.SEQUENCE_TYPE)).equalsIgnoreCase(FlowControllerConstants.RUNTIME)){
-                
+
+                if (flowSequnce == null) {
+                    throw new Exception("Flow Sequence is not found User Desinged VNF "
+                        + ctx.getAttribute(FlowControllerConstants.VNF_TYPE));
+                }
+
+            } else if ((localContext.getAttribute(FlowControllerConstants.SEQUENCE_TYPE))
+                .equalsIgnoreCase(FlowControllerConstants.RUNTIME)) {
+
                 Transaction transaction = new Transaction();
                 String input = collectInputParams(ctx,transaction);
-                log.info("collectInputParamsData" + input );
-                
-                RestExecutor restExe = new RestExecutor();    
-                HashMap<String,String>flowSeq= restExe.execute(transaction, localContext);
-                flowSequnce=flowSeq.get("restResponse");
-                
-                if(flowSequnce == null)
-                    throw new Exception("Failed to get the Flow Sequece runtime for VNF type" + ctx.getAttribute(FlowControllerConstants.VNF_TYPE));
+                log.info("CollectInputParamsData-Input: " + input);
 
-            }
-            else if(((String) localContext.getAttribute(FlowControllerConstants.SEQUENCE_TYPE)).equalsIgnoreCase(FlowControllerConstants.EXTERNAL)){
+                RestExecutor restExe = new RestExecutor();
+                Map<String,String> flowSeq = restExe.execute(transaction, localContext);
+
+                JSONObject sequence = new JSONObject(flowSeq.get("restResponse"));
+                if (sequence.has("output")) {
+                    flowSequnce = sequence.getJSONObject("output").toString();
+                }
+                log.info("MultistepSequenceGenerator-Output: " + flowSequnce);
+
+                if (flowSequnce == null) {
+                    throw new Exception("Failed to get the Flow Sequece runtime for VNF type"
+                        + ctx.getAttribute(FlowControllerConstants.VNF_TYPE));
+                }
+
+            } else if ((localContext.getAttribute(FlowControllerConstants.SEQUENCE_TYPE))
+                .equalsIgnoreCase(FlowControllerConstants.EXTERNAL)) {
                 //String input = collectInputParams(localContext);
                 //    flowSequnce = ""; //get it from the External interface calling the Rest End point - TBD
-                if(flowSequnce == null)
-                    throw new Exception("Flow Sequence not found for " + ctx.getAttribute(FlowControllerConstants.VNF_TYPE));                
-            }
-            else
-            {
-                //No other type of model supported...in Future can get flowModel from other generators which will be included here
+                //if(flowSequnce == null)
+
+                throw new Exception("Flow Sequence not found for "
+                    + ctx.getAttribute(FlowControllerConstants.VNF_TYPE));
+
+            } else {
+                //No other type of model supported...
+                //in Future can get flowModel from other generators which will be included here
                 throw new Exception("No information found for sequence Owner Design-Time Vs Run-Time" );
             }
-        }
-        else{
+
+        } else {
             FlowGenerator flowGenerator = new FlowGenerator();
             Transactions trans = flowGenerator.createSingleStepModel(inParams,ctx);
-            ObjectMapper mapper = new ObjectMapper();    
+            ObjectMapper mapper = new ObjectMapper();
             flowSequnce = mapper.writeValueAsString(trans);
-            log.debug("Single step Flow Sequence : " +  flowSequnce);
-
+            log.debug("Single step Flow Sequence : " + flowSequnce);
         }
-        log.debug("Received Flow Sequence : " +  flowSequnce);
 
+        log.debug("Received Flow Sequence : " + flowSequnce);
         HashMap<Integer, Transaction> transactionMap = createTransactionMap(flowSequnce, localContext);
-        exeuteAllTransaction(transactionMap, ctx); 
+        exeuteAllTransaction(transactionMap, ctx);
         log.info("Executed all the transacstion successfully");
-
     }
 
-    private void exeuteAllTransaction(HashMap<Integer, Transaction> transactionMap, SvcLogicContext ctx) throws Exception {
+    private void exeuteAllTransaction(HashMap<Integer, Transaction> transactionMap, SvcLogicContext ctx)
+        throws Exception {
 
         String fn = "FlowExecutorNode.exeuteAllTransaction ";
         int retry = 0;
-        FlowExecutorInterface flowExecutor = null;
-        for (int key = 1; key <= transactionMap.size() ; key++ ) 
-        {            
+        FlowExecutorInterface flowExecutor;
+        for (int key = 1; key <= transactionMap.size() ; key++) {
             log.debug(fn + "Starting transactions ID " + key + " :)=" + retry);
             Transaction transaction = transactionMap.get(key);
-            if(!preProcessor(transactionMap, transaction)){
+            if (!preProcessor(transactionMap, transaction)) {
                 log.info("Skipping Transaction ID " +  transaction.getTransactionId());
                 continue;
-            }            
-            if(transaction.getExecutionType() != null){
-                switch (transaction.getExecutionType()){
-                case FlowControllerConstants.GRAPH :
-                    flowExecutor = new GraphExecutor();
-                    break;
-                case FlowControllerConstants.NODE :
-                    flowExecutor =  new NodeExecutor();
-                    break;
-                case FlowControllerConstants.REST :
-                    flowExecutor = new RestExecutor();
-                    break;
-                default :
-                    throw new Exception("No Executor found for transaction ID" + transaction.getTransactionId());
+            }
+            if (transaction.getExecutionType() != null) {
+                switch (transaction.getExecutionType()) {
+                    case FlowControllerConstants.GRAPH :
+                        flowExecutor = new GraphExecutor();
+                        break;
+                    case FlowControllerConstants.NODE :
+                        flowExecutor =  new NodeExecutor();
+                        break;
+                    case FlowControllerConstants.REST :
+                        flowExecutor = new RestExecutor();
+                        break;
+                    default :
+                        throw new Exception("No Executor found for transaction ID" + transaction.getTransactionId());
                 }
                 flowExecutor.execute(transaction, ctx);
-                ResponseAction responseAction= handleResponse(transaction);
+                ResponseAction responseAction = handleResponse(transaction);
 
-                if(responseAction.getWait() != null && Integer.parseInt(responseAction.getWait()) > 0){
+                if (responseAction.getWait() != null && Integer.parseInt(responseAction.getWait()) > 0) {
                     log.debug(fn + "Going to Sleep .... " + responseAction.getWait());
-                    Thread.sleep(Integer.parseInt(responseAction.getWait())*1000);
+                    Thread.sleep(Integer.parseInt(responseAction.getWait()) * 1000L);
                 }
-
-                if(responseAction.isIntermediateMessage()){
+                if (responseAction.isIntermediateMessage()) {
                     log.debug(fn + "Sending Intermediate Message back  .... ");
                     sendIntermediateMessage();
                 }
-                if(responseAction.getRetry() != null && Integer.parseInt(responseAction.getRetry()) > retry ){                
+                if (responseAction.getRetry() != null && Integer.parseInt(responseAction.getRetry()) > retry ) {
                     log.debug(fn + "Ooppss!!! We will retry again ....... ");
-                        key--; 
-                        retry++;
+                    key--;
+                    retry++;
                     log.debug(fn + "key =" +  key +  "retry =" + retry);
-
                 }
-                if(responseAction.isIgnore()){
+                if (responseAction.isIgnore()) {
                     log.debug(fn + "Ignoring this Error and moving ahead  ....... ");
                     continue;
                 }
-                if(responseAction.isStop()){
+                if (responseAction.isStop()) {
                     log.debug(fn + "Need to Stop  ....... ");
                     break;
                 }
-                if(responseAction.getJump() != null && Integer.parseInt(responseAction.getJump()) > 0 ){
+                if (responseAction.getJump() != null && Integer.parseInt(responseAction.getJump()) > 0 ) {
                     key = Integer.parseInt(responseAction.getJump());
-                    key --;        
+                    key --;
                 }
                 log.debug(fn + "key =" +  key +  "retry =" + retry);
 
-            }
-            else{
+            } else {
                 throw new Exception("Don't know how to execute transaction ID " + transaction.getTransactionId());
             }
         }
 
     }
+
     private void sendIntermediateMessage() {
         // TODO Auto-generated method stub
-
     }
 
-    private ResponseAction handleResponse(Transaction transaction) {        
+    private ResponseAction handleResponse(Transaction transaction) {
         log.info("Handling Response for transaction Id " + transaction.getTransactionId());
-        DefaultResponseHandler defaultHandler = new DefaultResponseHandler();         
+        DefaultResponseHandler defaultHandler = new DefaultResponseHandler();
         return defaultHandler.handlerResponse(transaction);
     }
 
-    private boolean preProcessor(HashMap<Integer, Transaction> transactionMap, Transaction transaction) throws IOException {
+    private boolean preProcessor(HashMap<Integer, Transaction> transactionMap, Transaction transaction)
+        throws IOException {
 
         log.debug("Starting Preprocessing Logic ");
         boolean runthisStep = false;
-        try{
-            if(transaction.getPrecheck() != null && transaction.getPrecheck().getPrecheckOptions() != null 
-                    && !transaction.getPrecheck().getPrecheckOptions().isEmpty()){
+        try {
+            if (transaction.getPrecheck() != null
+                && transaction.getPrecheck().getPrecheckOptions() != null
+                && !transaction.getPrecheck().getPrecheckOptions().isEmpty()) {
+
                 List<PrecheckOption> precheckOptions  = transaction.getPrecheck().getPrecheckOptions();
-                for(PrecheckOption precheck : precheckOptions){
+                for (PrecheckOption precheck : precheckOptions) {
                     Transaction trans = transactionMap.get(precheck.getpTransactionID());
                     ObjectMapper mapper = new ObjectMapper();
                     log.info("Mapper= " + mapper.writeValueAsString(trans));
-                    HashMap<Object, Object> trmap = mapper.readValue(mapper.writeValueAsString(trans), HashMap.class);
-                    if(trmap.get(precheck.getParamName()) != null && 
-                            ((String) trmap.get(precheck.getParamName())).equalsIgnoreCase(precheck.getParamValue()))
+                    HashMap trmap = mapper.readValue(mapper.writeValueAsString(trans), HashMap.class);
+                    if (trmap.get(precheck.getParamName()) != null
+                        && ((String) trmap.get(precheck.getParamName())).equalsIgnoreCase(precheck.getParamValue())) {
                         runthisStep = true;
-                    else
+                    } else {
                         runthisStep = false;
+                    }
 
-                    if(transaction.getPrecheck().getPrecheckOperator() != null && 
-                            transaction.getPrecheck().getPrecheckOperator().equalsIgnoreCase("any") && runthisStep)
-                        break;                        
+                    if (("any").equalsIgnoreCase(transaction.getPrecheck().getPrecheckOperator()) && runthisStep) {
+                        break;
+                    }
                 }
-            }
-
-            else{
+            } else {
                 log.debug("No Pre check defined for transaction ID " + transaction.getTransactionId());
                 runthisStep = true;
-
             }
-        }
-        catch(Exception e)
-        {
-            e.printStackTrace();
+        } catch(Exception e) {
+            log.error("Error occured when Preprocessing Logic ", e);
             throw e;
         }
         log.debug("Returing process current Transaction = " + runthisStep);
-
         return runthisStep ;
     }
 
-    private HashMap<Integer, Transaction> createTransactionMap(String flowSequnce, SvcLogicContext localContext) throws SvcLogicException, JsonParseException, JsonMappingException, IOException {
-        ObjectMapper mapper = new ObjectMapper();    
+    private HashMap<Integer, Transaction> createTransactionMap(String flowSequnce, SvcLogicContext localContext)
+        throws Exception {
+
+        ObjectMapper mapper = new ObjectMapper();
         Transactions transactions = mapper.readValue(flowSequnce,Transactions.class);
-        HashMap<Integer, Transaction> transMap = new HashMap<Integer, Transaction>();    
-        for(Transaction transaction : transactions.getTransactions()){        
+        HashMap<Integer, Transaction> transMap = new HashMap<>();
+        for (Transaction transaction : transactions.getTransactions()) {
             compileFlowDependencies(transaction, localContext);
-            //loadTransactionIntoStatus(transactions, ctx); //parse the Transactions Object and create records in process_flow_status table 
-            transMap.put(transaction.getTransactionId(), transaction);            
-        }        
+            //parse the Transactions Object and create records in process_flow_status table
+            //loadTransactionIntoStatus(transactions, ctx);
+            transMap.put(transaction.getTransactionId(), transaction);
+        }
         return transMap;
     }
 
-    private void compileFlowDependencies(Transaction transaction, SvcLogicContext localContext) throws SvcLogicException, JsonParseException, JsonMappingException, IOException {
+    private void compileFlowDependencies(Transaction transaction, SvcLogicContext localContext) throws Exception {
 
-        String fn = "FlowExecutorNode.compileFlowDependencies";
         FlowControlDBService dbservice = FlowControlDBService.initialise();
         dbservice.populateModuleAndRPC(transaction, localContext.getAttribute(FlowControllerConstants.VNF_TYPE));
         ObjectMapper mapper = new ObjectMapper();
         log.debug("Indivisual Transaction Details :" + transaction.toString());
-        if((localContext.getAttribute(FlowControllerConstants.SEQUENCE_TYPE) == null) ||
-                ( localContext.getAttribute(FlowControllerConstants.SEQUENCE_TYPE) != null && 
-                ! localContext.getAttribute(FlowControllerConstants.SEQUENCE_TYPE).equalsIgnoreCase(FlowControllerConstants.DESINGTIME))){
+
+        if ((localContext.getAttribute(FlowControllerConstants.SEQUENCE_TYPE) == null)
+            || (localContext.getAttribute(FlowControllerConstants.SEQUENCE_TYPE) != null
+            && ! localContext.getAttribute(FlowControllerConstants.SEQUENCE_TYPE)
+            .equalsIgnoreCase(FlowControllerConstants.DESINGTIME))) {
+
             localContext.setAttribute("artifact-content", mapper.writeValueAsString(transaction));
             dbservice.loadSequenceIntoDB(localContext);
         }
         //get a field in transction class as transactionhandle interface and register the Handler here for each trnactions
     }
-    
-    private String collectInputParams(SvcLogicContext ctx, Transaction transaction) throws Exception {
+
+    private String collectInputParams(SvcLogicContext ctx,Transaction transaction) throws Exception {
 
         String fn = "FlowExecuteNode.collectInputParams";
         Properties prop = loadProperties();
         log.info("Loaded Properties " + prop.toString());
 
         String vnfId = ctx.getAttribute(FlowControllerConstants.VNF_ID);
+        String inputData = null;
         log.debug(fn + "vnfId :" + vnfId);
 
         if (StringUtils.isBlank(vnfId)) {
             throw new Exception("VnfId is missing");
         }
 
-        ActionIdentifier actionIdentifier = new ActionIdentifier();
-        actionIdentifier.setVnfId(vnfId);
-        actionIdentifier.setVserverId(ctx.getAttribute(FlowControllerConstants.VSERVER_ID));
-        actionIdentifier.setVnfcName(ctx.getAttribute(FlowControllerConstants.VNFC_NAME));
-
-        RequestInfo requestInfo = new RequestInfo();
-        requestInfo.setAction(ctx.getAttribute(FlowControllerConstants.ACTION));
-        requestInfo.setActionLevel(ctx.getAttribute(FlowControllerConstants.ACTION_LEVEL));
-        requestInfo.setPayload(ctx.getAttribute(FlowControllerConstants.PAYLOAD));
-        requestInfo.setActionIdentifier(actionIdentifier);
-        
-        InventoryInfo inventoryInfo = getInventoryInfo(ctx,vnfId);
-        DependencyInfo dependencyInfo = getDependencyInfo(ctx);
-        Capabilities capabilites = getCapabilitesData(ctx);
-        
-        Input input = new Input();
-        input.setRequestInfo(requestInfo);
-        input.setInventoryInfo(inventoryInfo);
-        input.setDependencyInfo(dependencyInfo);
-        input.setCapabilities(capabilites);
-        //input.setTunableParameters(null);
-        
-
-        log.info(fn + "Input parameters:" + input.toString());
-
-        String inputData = null;
         try {
+            ActionIdentifier actionIdentifier = new ActionIdentifier();
+            log.debug("Enter ActionIdentifier");
+            if (StringUtils.isNotBlank(vnfId)) {
+                actionIdentifier.setVnfId(vnfId);
+            }
+            if (StringUtils.isNotBlank(ctx.getAttribute(FlowControllerConstants.VSERVER_ID))) {
+                actionIdentifier.setVserverId(ctx.getAttribute(FlowControllerConstants.VSERVER_ID));
+            }
+            if (StringUtils.isNotBlank(ctx.getAttribute(FlowControllerConstants.VNFC_NAME))) {
+                actionIdentifier.setVnfcName(ctx.getAttribute(FlowControllerConstants.VNFC_NAME));
+            }
+            log.info("ActionIdentifierData" + actionIdentifier.toString());
+
+            RequestInfo requestInfo = new RequestInfo();
+            log.info("Enter RequestInfo");
+            requestInfo.setAction(ctx.getAttribute(FlowControllerConstants.REQUEST_ACTION));
+            requestInfo.setActionLevel(ctx.getAttribute(FlowControllerConstants.ACTION_LEVEL));
+            requestInfo.setPayload(ctx.getAttribute(FlowControllerConstants.PAYLOAD));
+            requestInfo.setActionIdentifier(actionIdentifier);
+            log.debug("RequestInfo: " + requestInfo.toString());
+
+            InventoryInfo inventoryInfo = getInventoryInfo(ctx, vnfId);
+            DependencyInfo dependencyInfo = getDependencyInfo(ctx);
+            Capabilities capabilites = getCapabilitesData(ctx);
+
+            Input input = new Input();
+            log.info("Enter InputData");
+            input.setRequestInfo(requestInfo);
+            input.setInventoryInfo(inventoryInfo);
+            input.setDependencyInfo(dependencyInfo);
+            input.setCapabilities(capabilites);
+            log.info(fn + "Input parameters:" + input.toString());
+
             ObjectMapper mapper = new ObjectMapper();
             mapper.setSerializationInclusion(Include.NON_NULL);
-            mapper.configure(SerializationFeature.WRAP_ROOT_VALUE,true);
+            mapper.configure(SerializationFeature.WRAP_ROOT_VALUE, true);
             inputData = mapper.writeValueAsString(input);
-            log.info("InputDataJson:"+inputData);
+            log.info("InputDataJson:" + inputData);
 
         } catch (Exception e) {
-            e.printStackTrace();
+            log.error("Error occured in " + fn, e);
         }
 
         String resourceUri = prop.getProperty(FlowControllerConstants.SEQ_GENERATOR_URL);
         log.info(fn + "resourceUri= " + resourceUri);
 
+        EncryptionTool et = EncryptionTool.getInstance();
+        String pass = et.decrypt(prop.getProperty(FlowControllerConstants.SEQ_GENERATOR_PWD));
+
         transaction.setPayload(inputData);
         transaction.setExecutionRPC("POST");
         transaction.setuId(prop.getProperty(FlowControllerConstants.SEQ_GENERATOR_UID));
-        transaction.setPswd(prop.getProperty(FlowControllerConstants.SEQ_GENERATOR_PWD));
+        transaction.setPswd(pass);
         transaction.setExecutionEndPoint(resourceUri);
 
         return inputData;
-
     }
-    
+
     private DependencyInfo getDependencyInfo(SvcLogicContext ctx) throws Exception {
-        
+
         String fn = "FlowExecutorNode.getDependencyInfo";
         DependencyInfo dependencyInfo = new DependencyInfo();
         FlowControlDBService dbservice = FlowControlDBService.initialise();
@@ -402,19 +445,17 @@ public class FlowControlNode implements SvcLogicJavaPlugin{
             ObjectMapper mapper = new ObjectMapper();
             mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES,false);
             mapper.enable(DeserializationFeature.ACCEPT_SINGLE_VALUE_AS_ARRAY);
-            JsonNode dependencyInfoData = mapper.readTree(dependencyData).get("dependencyInfo");
-            JsonNode vnfcData = mapper.readTree(dependencyInfoData.toString()).get("vnfcs");
+            //JsonNode dependencyInfoData = mapper.readTree(dependencyData).get("dependencyInfo");
+            JsonNode vnfcData = mapper.readTree(dependencyData).get("vnfcs");
             List<Vnfcs> vnfclist = Arrays.asList(mapper.readValue(vnfcData.toString(), Vnfcs[].class));
             dependencyInfo.getVnfcs().addAll(vnfclist);
-            
-            log.info("Dependency Output:"+ dependencyInfo.toString());
-        }
 
+            log.info("Dependency Output:" + dependencyInfo.toString());
+        }
         return dependencyInfo;
-
     }
-    
-    private Capabilities getCapabilitesData(SvcLogicContext ctx)throws Exception {
+
+    private Capabilities getCapabilitesData(SvcLogicContext ctx) throws Exception {
 
         String fn = "FlowExecutorNode.getCapabilitesData";
         Capabilities capabilities = new Capabilities();
@@ -430,41 +471,36 @@ public class FlowControlNode implements SvcLogicJavaPlugin{
             log.info("capabilitiesNode:" + capabilitiesNode.toString());
 
             JsonNode vnfs = capabilitiesNode.findValue(FlowControllerConstants.VNF);
-            List<String> vnfsList = new ArrayList<String>();
+            List<String> vnfsList = new ArrayList<>();
             if (vnfs != null) {
                 for (int i = 0; i < vnfs.size(); i++) {
-
                     String vnf = vnfs.get(i).asText();
                     vnfsList.add(vnf);
                 }
             }
 
             JsonNode vfModules = capabilitiesNode.findValue(FlowControllerConstants.VF_MODULE);
-            List<String> vfModulesList = new ArrayList<String>();
+            List<String> vfModulesList = new ArrayList<>();
             if (vfModules != null) {
                 for (int i = 0; i < vfModules.size(); i++) {
-
                     String vfModule = vfModules.get(i).asText();
                     vfModulesList.add(vfModule);
                 }
             }
 
             JsonNode vnfcs = capabilitiesNode.findValue(FlowControllerConstants.VNFC);
-            List<String> vnfcsList = new ArrayList<String>();
+            List<String> vnfcsList = new ArrayList<>();
             if (vnfcs != null) {
                 for (int i = 0; i < vnfcs.size(); i++) {
-
                     String vnfc1 = vnfcs.get(i).asText();
                     vnfcsList.add(vnfc1);
                 }
             }
 
             JsonNode vms = capabilitiesNode.findValue(FlowControllerConstants.VM);
-
-            List<String> vmList = new ArrayList<String>();
+            List<String> vmList = new ArrayList<>();
             if (vms != null) {
                 for (int i = 0; i < vms.size(); i++) {
-
                     String vm1 = vms.get(i).asText();
                     vmList.add(vm1);
                 }
@@ -474,89 +510,60 @@ public class FlowControlNode implements SvcLogicJavaPlugin{
             capabilities.getVnf().addAll(vnfsList);
             capabilities.getVfModule().addAll(vfModulesList);
             capabilities.getVm().addAll(vmList);
-            
-            log.info("Capabilities Output:"+ capabilities.toString());
 
+            log.info("Capabilities Output:" + capabilities.toString());
         }
-
         return capabilities;
-
     }
-    
-    private InventoryInfo getInventoryInfo(SvcLogicContext ctx, String vnfId) throws Exception{
-        
+
+    private InventoryInfo getInventoryInfo(SvcLogicContext ctx, String vnfId) throws Exception {
         String fn = "FlowExecutorNode.getInventoryInfo";
-        String vmcount = ctx.getAttribute("tmp.vnfInfo.vm-count");
-        int vmCount = Integer.parseInt(vmcount);
-        log.info(fn +"vmcount:"+ vmCount);
 
         VnfInfo vnfInfo = new VnfInfo();
         vnfInfo.setVnfId(vnfId);
         vnfInfo.setVnfName(ctx.getAttribute("tmp.vnfInfo.vnf.vnf-name"));
         vnfInfo.setVnfType(ctx.getAttribute("tmp.vnfInfo.vnf.vnf-type"));
 
-        Vm vm = new Vm();
-        Vnfcslist vnfc = new Vnfcslist();
-
-        if (vmCount > 0) {
+        String vmcount = ctx.getAttribute("tmp.vnfInfo.vm-count");
+        if (StringUtils.isNotBlank(vmcount)) {
+            int vmCount = Integer.parseInt(vmcount);
+            log.info(fn + "vmcount:" + vmCount);
 
+            Vm vm = new Vm();
+            Vnfcslist vnfc = new Vnfcslist();
             for (int i = 0; i < vmCount; i++) {
-
-                vm.setVserverId(ctx.getAttribute("tmp.vnfInfo.vm[" + i + "].vserverId"));
+                vm.setVserverId(ctx.getAttribute("tmp.vnfInfo.vm[" + i + "].vserver-id"));
                 String vnfccount = ctx.getAttribute("tmp.vnfInfo.vm[" + i + "].vnfc-count");
                 int vnfcCount = Integer.parseInt(vnfccount);
-
                 if (vnfcCount > 0) {
-                    vnfc.setVnfcName(ctx.getAttribute("tmp.vnfInfo.vm[" + i    + "].vnfc-name"));
-                    vnfc.setVnfcType(ctx.getAttribute("tmp.vnfInfo.vm[" + i    + "].vnfc-type"));
+                    vnfc.setVnfcName(ctx.getAttribute("tmp.vnfInfo.vm[" + i + "].vnfc-name"));
+                    vnfc.setVnfcType(ctx.getAttribute("tmp.vnfInfo.vm[" + i + "].vnfc-type"));
                     vm.setVnfc(vnfc);
                 }
                 vnfInfo.getVm().add(vm);
             }
         }
-
         InventoryInfo inventoryInfo = new InventoryInfo();
         inventoryInfo.setVnfInfo(vnfInfo);
-        
+        log.info(fn + "Inventory Output:" + inventoryInfo.toString());
+
         return inventoryInfo;
-        
     }
-        
-    private String getFlowSequence() throws IOException {
 
-        String sequenceModel = IOUtils.toString(FlowControlNode.class.getClassLoader().getResourceAsStream("sequence.json"), Charset.defaultCharset());
+    private static Properties loadProperties() throws Exception {
+        Properties props = new Properties();
+        String propDir = System.getenv(SDNC_CONFIG_DIR_VAR);
+        if (propDir == null) {
+            throw new Exception("Cannot find Property file -" + SDNC_CONFIG_DIR_VAR);
+        }
+        String propFile = propDir + FlowControllerConstants.APPC_FLOW_CONTROLLER;
+        try (InputStream propStream = new FileInputStream(propFile)) {
 
-        return null;
-    }
+            props.load(propStream);
 
-    
-private static Properties loadProperties() throws Exception {
-    Properties props = new Properties();
-    String propDir = System.getenv(SDNC_CONFIG_DIR_VAR);
-    if (propDir == null)
-        throw new Exception("Cannot find Property file -" + SDNC_CONFIG_DIR_VAR);
-    String propFile = propDir + FlowControllerConstants.APPC_FLOW_CONTROLLER;
-    InputStream propStream = new FileInputStream(propFile);        
-    try
-    {
-        props.load(propStream);
-    }
-    catch (Exception e)
-    {
-        throw new Exception("Could not load properties file " + propFile, e);
-    }
-    finally
-    {
-        try
-        {
-            propStream.close();
-        }
-        catch (Exception e)
-        {
-            log.warn("Could not close FileInputStream", e);
+        } catch (Exception e) {
+            throw new Exception("Could not load properties file " + propFile, e);
         }
+        return props;
     }
-    return props;
-}
-
 }