Code Review / msb / apigateway.git / blobdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | inline | side by side
fix powermock issue
[msb/apigateway.git] / apiroute / apiroute-service / src / test / java / org / onap / msb / apiroute / wrapper / service / IuiRouteServiceTest.java
diff --git a/apiroute/apiroute-service/src/test/java/org/onap/msb/apiroute/wrapper/service/IuiRouteServiceTest.java b/apiroute/apiroute-service/src/test/java/org/onap/msb/apiroute/wrapper/service/IuiRouteServiceTest.java
index 0ddbb32..6286658 100644 (file)
--- a/apiroute/apiroute-service/src/test/java/org/onap/msb/apiroute/wrapper/service/IuiRouteServiceTest.java
+++ b/apiroute/apiroute-service/src/test/java/org/onap/msb/apiroute/wrapper/service/IuiRouteServiceTest.java
@@ -1,6 +1,29 @@
+/*******************************************************************************
+ * Copyright 2016-2017 ZTE, Inc. and others.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License. You may obtain a copy of the License at
+ * 
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ ******************************************************************************/
 package org.onap.msb.apiroute.wrapper.service;
 
-import com.fiftyonred.mock_jedis.MockJedisPool;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+
+import java.lang.reflect.InvocationHandler;
+import java.lang.reflect.Method;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.List;
+
 import org.junit.Before;
 import org.junit.BeforeClass;
 import org.junit.Test;
@@ -8,32 +31,26 @@ import org.junit.runner.RunWith;
 import org.onap.msb.apiroute.api.IuiRouteInfo;
 import org.onap.msb.apiroute.api.RouteServer;
 import org.onap.msb.apiroute.wrapper.dao.RedisAccessWrapper;
-import org.onap.msb.apiroute.wrapper.service.IuiRouteService;
 import org.onap.msb.apiroute.wrapper.util.JedisUtil;
 import org.powermock.api.mockito.PowerMockito;
 import org.powermock.core.classloader.annotations.PowerMockIgnore;
 import org.powermock.core.classloader.annotations.PrepareForTest;
 import org.powermock.modules.junit4.PowerMockRunner;
-import redis.clients.jedis.JedisPool;
-import redis.clients.jedis.JedisPoolConfig;
 
-import java.lang.reflect.InvocationHandler;
-import java.lang.reflect.Method;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.Comparator;
-import java.util.List;
+import com.fiftyonred.mock_jedis.MockJedisPool;
 
-import static org.junit.Assert.*;
+import redis.clients.jedis.JedisPool;
+import redis.clients.jedis.JedisPoolConfig;
 
 @RunWith(PowerMockRunner.class)
-@PrepareForTest({JedisUtil.class,RedisAccessWrapper.class})
-@PowerMockIgnore( {"javax.management.*"})
+@PrepareForTest({JedisUtil.class, RedisAccessWrapper.class})
+@PowerMockIgnore({"javax.management.*", "jdk.internal.reflect.*"})
 public class IuiRouteServiceTest {
     private static IuiRouteService iuiRouteService = null;
     private static Comparator<IuiRouteInfo> iuiRouteComparator = null;
+
     @BeforeClass
-    public static void setUp() throws Exception{
+    public static void setUp() throws Exception {
         iuiRouteService = IuiRouteService.getInstance();
         iuiRouteComparator = new Comparator<IuiRouteInfo>() {
             @Override
@@ -44,11 +61,12 @@ public class IuiRouteServiceTest {
             }
         };
     }
+
     @Before
     public void setUpBeforeTest() throws Exception {
         final JedisPool mockJedisPool = new MockJedisPool(new JedisPoolConfig(), "localhost");
         PowerMockito.mockStatic(JedisUtil.class);
-        JedisUtil jedisUtil=PowerMockito.mock(JedisUtil.class);
+        JedisUtil jedisUtil = PowerMockito.mock(JedisUtil.class);
         PowerMockito.when(jedisUtil.borrowJedisInstance()).thenReturn(mockJedisPool.getResource());
 
         PowerMockito.replace(PowerMockito.method(RedisAccessWrapper.class, "filterKeys")).with(new InvocationHandler() {
@@ -58,17 +76,18 @@ public class IuiRouteServiceTest {
             }
         });
     }
+
     @Test
-    public void testGetIuiRouteInstance_key_not_exist(){
+    public void testGetIuiRouteInstance_key_not_exist() {
         try {
             assertNull(iuiRouteService.getIuiRouteInstance("msb:routing:iui:notexistservice:v1"));
         } catch (Exception e) {
-            assert false:"throw exception means error occured!"+e.getMessage();
+            assert false : "throw exception means error occured!" + e.getMessage();
         }
     }
 
     @Test
-    public void testGetIuiRouteInstance_key_exist(){
+    public void testGetIuiRouteInstance_key_exist() {
         IuiRouteInfo iuirouteInfo = new IuiRouteInfo();
         iuirouteInfo.setServiceName("testiui");
         iuirouteInfo.setStatus("1");
@@ -76,18 +95,18 @@ public class IuiRouteServiceTest {
         iuirouteInfo.setUseOwnUpstream("0");
         iuirouteInfo.setVisualRange("0");
         iuirouteInfo.setEnable_ssl(false);
-        RouteServer[] servers = new RouteServer[]{new RouteServer("10.74.148.88","8080")};
+        RouteServer[] servers = new RouteServer[] {new RouteServer("10.74.148.88", "8080")};
         iuirouteInfo.setServers(servers);
         try {
-            iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo,"msb:routing:iui:testiui");
+            iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo, "msb:routing:iui:testiui");
             assertEquals(iuirouteInfo, iuiRouteService.getIuiRouteInstance("msb:routing:iui:testiui"));
         } catch (Exception e) {
-            assert false:"throw exception means error occured!"+e.getMessage();
+            assert false : "throw exception means error occured!" + e.getMessage();
         }
     }
 
     @Test
-    public void testSaveIuiRouteService2Redis(){
+    public void testSaveIuiRouteService2Redis() {
         IuiRouteInfo iuirouteInfo = new IuiRouteInfo();
         iuirouteInfo.setServiceName("testiui");
         iuirouteInfo.setStatus("1");
@@ -95,18 +114,18 @@ public class IuiRouteServiceTest {
         iuirouteInfo.setUseOwnUpstream("0");
         iuirouteInfo.setVisualRange("0");
         iuirouteInfo.setEnable_ssl(true);
-        RouteServer[] servers = new RouteServer[]{new RouteServer("10.74.148.88","8080")};
+        RouteServer[] servers = new RouteServer[] {new RouteServer("10.74.148.88", "8080")};
         iuirouteInfo.setServers(servers);
         try {
-            iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo,"msb:routing:iui:testiui");
+            iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo, "msb:routing:iui:testiui");
             assertEquals(iuirouteInfo, iuiRouteService.getIuiRouteInstance("msb:routing:iui:testiui"));
         } catch (Exception e) {
-            assert false:"throw exception means error occured!"+e.getMessage();
+            assert false : "throw exception means error occured!" + e.getMessage();
         }
     }
 
     @Test
-    public void testDeleteIuiRouteService2Redis(){
+    public void testDeleteIuiRouteService2Redis() {
         IuiRouteInfo iuirouteInfo = new IuiRouteInfo();
         iuirouteInfo.setServiceName("testiui");
         iuirouteInfo.setStatus("1");
@@ -114,20 +133,20 @@ public class IuiRouteServiceTest {
         iuirouteInfo.setUseOwnUpstream("0");
         iuirouteInfo.setVisualRange("0");
         iuirouteInfo.setEnable_ssl(false);
-        RouteServer[] servers = new RouteServer[]{new RouteServer("10.74.148.88","8080")};
+        RouteServer[] servers = new RouteServer[] {new RouteServer("10.74.148.88", "8080")};
         iuirouteInfo.setServers(servers);
         try {
-            iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo,"msb:routing:iui:testiui");
+            iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo, "msb:routing:iui:testiui");
             assertNotNull(iuiRouteService.getIuiRouteInstance("msb:routing:iui:testiui"));
             iuiRouteService.deleteIuiRouteService2Redis("msb:routing:iui:testiui");
             assertNull(iuiRouteService.getIuiRouteInstance("msb:routing:iui:testiui"));
         } catch (Exception e) {
-            assert false:"throw exception means error occured!"+e.getMessage();
+            assert false : "throw exception means error occured!" + e.getMessage();
         }
     }
 
     @Test
-    public void testUpdateIuiRouteStatus2Redis(){
+    public void testUpdateIuiRouteStatus2Redis() {
         IuiRouteInfo iuirouteInfo = new IuiRouteInfo();
         iuirouteInfo.setServiceName("testiui");
         iuirouteInfo.setStatus("1");
@@ -135,15 +154,15 @@ public class IuiRouteServiceTest {
         iuirouteInfo.setUseOwnUpstream("0");
         iuirouteInfo.setVisualRange("0");
         iuirouteInfo.setEnable_ssl(true);
-        RouteServer[] servers = new RouteServer[]{new RouteServer("10.74.148.88","8080")};
+        RouteServer[] servers = new RouteServer[] {new RouteServer("10.74.148.88", "8080")};
         iuirouteInfo.setServers(servers);
         try {
-            iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo,"msb:routing:iui:testiui");
+            iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo, "msb:routing:iui:testiui");
             assertEquals("1", iuiRouteService.getIuiRouteInstance("msb:routing:iui:testiui").getStatus());
-            iuiRouteService.updateIuiRouteStatus2Redis("msb:routing:iui:testiui","0");
+            iuiRouteService.updateIuiRouteStatus2Redis("msb:routing:iui:testiui", "0");
             assertEquals("0", iuiRouteService.getIuiRouteInstance("msb:routing:iui:testiui").getStatus());
         } catch (Exception e) {
-            assert false:"throw exception means error occured!"+e.getMessage();
+            assert false : "throw exception means error occured!" + e.getMessage();
         }
     }
 
@@ -156,7 +175,7 @@ public class IuiRouteServiceTest {
         iuirouteInfo.setUseOwnUpstream("0");
         iuirouteInfo.setVisualRange("0");
         iuirouteInfo.setEnable_ssl(false);
-        iuirouteInfo.setServers(new RouteServer[]{new RouteServer("10.74.148.88","8080")});
+        iuirouteInfo.setServers(new RouteServer[] {new RouteServer("10.74.148.88", "8080")});
 
         IuiRouteInfo iuirouteInfo2 = new IuiRouteInfo();
         iuirouteInfo2.setServiceName("testiui2");
@@ -165,10 +184,10 @@ public class IuiRouteServiceTest {
         iuirouteInfo2.setUseOwnUpstream("0");
         iuirouteInfo2.setVisualRange("0");;
         iuirouteInfo.setEnable_ssl(true);
-        iuirouteInfo2.setServers(new RouteServer[]{new RouteServer("10.74.148.88","8088")});
+        iuirouteInfo2.setServers(new RouteServer[] {new RouteServer("10.74.148.88", "8088")});
 
-        iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo,"msb:routing:iui:testiui");
-        iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo2,"msb:routing:iui:testiui2");
+        iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo, "msb:routing:iui:testiui");
+        iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo2, "msb:routing:iui:testiui2");
 
         List<IuiRouteInfo> expected = new ArrayList<>();
         expected.add(iuirouteInfo);
@@ -190,7 +209,7 @@ public class IuiRouteServiceTest {
         iuirouteInfo.setUseOwnUpstream("0");
         iuirouteInfo.setVisualRange("0");
         iuirouteInfo.setEnable_ssl(false);
-        iuirouteInfo.setServers(new RouteServer[]{new RouteServer("10.74.148.88","8080")});
+        iuirouteInfo.setServers(new RouteServer[] {new RouteServer("10.74.148.88", "8080")});
 
         IuiRouteInfo iuirouteInfo2 = new IuiRouteInfo();
         iuirouteInfo2.setServiceName("testiui2");
@@ -199,23 +218,23 @@ public class IuiRouteServiceTest {
         iuirouteInfo2.setUseOwnUpstream("0");
         iuirouteInfo2.setVisualRange("0");;
         iuirouteInfo.setEnable_ssl(true);
-        iuirouteInfo2.setServers(new RouteServer[]{new RouteServer("10.74.148.88","8088")});
-        iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo,"msb:routing:iui:testiui");
-        iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo2,"msb:routing:iui:testiui2");
+        iuirouteInfo2.setServers(new RouteServer[] {new RouteServer("10.74.148.88", "8088")});
+        iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo, "msb:routing:iui:testiui");
+        iuiRouteService.saveIuiRouteService2Redis(iuirouteInfo2, "msb:routing:iui:testiui2");
 
-        assertEquals(2,iuiRouteService.getMultiIuiRouteInstances("msb:routing:iui:*").size());
-        assertEquals(2,iuiRouteService.deleteMultiIuiRouteService2Redis("msb:routing:iui:*"));
-        assertEquals(0,iuiRouteService.getMultiIuiRouteInstances("msb:routing:iui:*").size());
+        assertEquals(2, iuiRouteService.getMultiIuiRouteInstances("msb:routing:iui:*").size());
+        assertEquals(2, iuiRouteService.deleteMultiIuiRouteService2Redis("msb:routing:iui:*"));
+        assertEquals(0, iuiRouteService.getMultiIuiRouteInstances("msb:routing:iui:*").size());
     }
 
     @Test(expected = Exception.class)
     public void testUpdateIuiRouteStatus2Redis_keyNotExist() throws Exception {
-        iuiRouteService.updateIuiRouteStatus2Redis("msb:routing:iui:notexistservice","0");
+        iuiRouteService.updateIuiRouteStatus2Redis("msb:routing:iui:notexistservice", "0");
     }
 
     @Test(expected = Exception.class)
     public void testSaveIuiRouteService2Redis_null() throws Exception {
-        iuiRouteService.saveIuiRouteService2Redis(null,"msb:routing:iui:null");
+        iuiRouteService.saveIuiRouteService2Redis(null, "msb:routing:iui:null");
     }
 
 }
Service API gateway which provides client request routing, client request load balancing, transformation, such as https to http, authentication & authorization for service request with plugin of auth service provider,service request logging,service request rate-limiting,service monitoring,request result cache,solve cross-domain issue for web application and other functionalities with the pluggable architecture capability.