Code Review
/
dcaegen2
/
collectors
/
hv-ves.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Harmonize logging and add new logs
[dcaegen2/collectors/hv-ves.git]
/
sources
/
hv-collector-domain
/
src
/
test
/
kotlin
/
org
/
onap
/
dcae
/
collectors
/
veshv
/
domain
/
WireFrameCodecsTest.kt
diff --git
a/sources/hv-collector-domain/src/test/kotlin/org/onap/dcae/collectors/veshv/domain/WireFrameCodecsTest.kt
b/sources/hv-collector-domain/src/test/kotlin/org/onap/dcae/collectors/veshv/domain/WireFrameCodecsTest.kt
index
f17a79b
..
f8fbc0a
100644
(file)
--- a/
sources/hv-collector-domain/src/test/kotlin/org/onap/dcae/collectors/veshv/domain/WireFrameCodecsTest.kt
+++ b/
sources/hv-collector-domain/src/test/kotlin/org/onap/dcae/collectors/veshv/domain/WireFrameCodecsTest.kt
@@
-60,7
+60,7
@@
object WireFrameCodecsTest : Spek({
payloadSize = 0)
it("should fail validation") {
payloadSize = 0)
it("should fail validation") {
- assertThat(input.isValid()).isFalse()
+ input.validate().assertFailedWithError { it.isInstanceOf(InvalidMajorVersion::class.java) }
}
}
}
}
@@
-73,7
+73,7
@@
object WireFrameCodecsTest : Spek({
payloadSize = 0)
it("should pass validation") {
payloadSize = 0)
it("should pass validation") {
- assertT
hat(input.isValid()).isTrue(
)
+ assertT
rue(input.validate().isRight()
)
}
}
}
}
@@
-86,7
+86,7
@@
object WireFrameCodecsTest : Spek({
payloadSize = 0)
it("should fail validation") {
payloadSize = 0)
it("should fail validation") {
- assertThat(input.isValid()).isFalse()
+ input.validate().assertFailedWithError { it.isInstanceOf(UnsupportedPayloadContentType::class.java) }
}
}
}
}
@@
-99,7
+99,7
@@
object WireFrameCodecsTest : Spek({
payloadSize = 1)
it("should fail validation") {
payloadSize = 1)
it("should fail validation") {
- assertThat(input.isValid()).isFalse()
+ input.validate().assertFailedWithError { it.isInstanceOf(NotMatchingPayloadSize::class.java) }
}
}
}
}
@@
-112,7
+112,7
@@
object WireFrameCodecsTest : Spek({
payloadSize = 8)
it("should fail validation") {
payloadSize = 8)
it("should fail validation") {
- assertThat(input.isValid()).isFalse()
+ input.validate().assertFailedWithError { it.isInstanceOf(NotMatchingPayloadSize::class.java) }
}
}
}
}
@@
-126,7
+126,7
@@
object WireFrameCodecsTest : Spek({
payloadSize = payload.size)
it("should pass validation") {
payloadSize = payload.size)
it("should pass validation") {
- assertT
hat(input.isValid()).isTrue(
)
+ assertT
rue(input.validate().isRight()
)
}
}
}
}
@@
-214,7
+214,7
@@
object WireFrameCodecsTest : Spek({
.writeByte(0xAB)
val decoded = decoder.decodeFirst(buff).getMessageOrFail()
.writeByte(0xAB)
val decoded = decoder.decodeFirst(buff).getMessageOrFail()
- assertT
hat(decoded.isValid()).describedAs("should be valid").isTrue(
)
+ assertT
rue(decoded.validate().isRight(), "should be valid"
)
assertThat(buff.readableBytes()).isEqualTo(1)
}
}
assertThat(buff.readableBytes()).isEqualTo(1)
}
}