Code Review
/
policy
/
models.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Address sonar issues in policy/models
[policy/models.git]
/
models-interactions
/
model-actors
/
actor.so
/
src
/
main
/
java
/
org
/
onap
/
policy
/
controlloop
/
actor
/
so
/
SoOperation.java
diff --git
a/models-interactions/model-actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SoOperation.java
b/models-interactions/model-actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SoOperation.java
index
9020c0b
..
e3328e9
100644
(file)
--- a/
models-interactions/model-actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SoOperation.java
+++ b/
models-interactions/model-actors/actor.so/src/main/java/org/onap/policy/controlloop/actor/so/SoOperation.java
@@
-89,7
+89,7
@@
public abstract class SoOperation extends HttpOperation<SoResponse> {
* @param config configuration for this operation
* @param propertyNames names of properties required by this operation
*/
* @param config configuration for this operation
* @param propertyNames names of properties required by this operation
*/
- p
ublic
SoOperation(ControlLoopOperationParams params, HttpPollingConfig config, List<String> propertyNames) {
+ p
rotected
SoOperation(ControlLoopOperationParams params, HttpPollingConfig config, List<String> propertyNames) {
super(params, config, SoResponse.class, propertyNames);
this.modelCustomizationId = null;
super(params, config, SoResponse.class, propertyNames);
this.modelCustomizationId = null;
@@
-109,7
+109,7
@@
public abstract class SoOperation extends HttpOperation<SoResponse> {
* @param propertyNames names of properties required by this operation
* @param targetEntityIds Target Entity information
*/
* @param propertyNames names of properties required by this operation
* @param targetEntityIds Target Entity information
*/
- p
ublic
SoOperation(ControlLoopOperationParams params, HttpPollingConfig config, List<String> propertyNames,
+ p
rotected
SoOperation(ControlLoopOperationParams params, HttpPollingConfig config, List<String> propertyNames,
Map<String, String> targetEntityIds) {
super(params, config, SoResponse.class, propertyNames);
Map<String, String> targetEntityIds) {
super(params, config, SoResponse.class, propertyNames);
@@
-345,7
+345,7
@@
public abstract class SoOperation extends HttpOperation<SoResponse> {
* IllegalArgumentException if the desired data item is not found.
*/
* IllegalArgumentException if the desired data item is not found.
*/
- protected GenericVnf getVnfItem(
SoModelInfo soModelInfo
) {
+ protected GenericVnf getVnfItem() {
return getRequiredProperty(OperationProperties.AAI_VNF, "generic VNF");
}
return getRequiredProperty(OperationProperties.AAI_VNF, "generic VNF");
}